Re: [mpls] More comments from another Reviewer//Re: MPLS-RT review of draft-bryant-mpls-sfl-control

Stewart Bryant <stewart.bryant@gmail.com> Fri, 03 January 2020 16:58 UTC

Return-Path: <stewart.bryant@gmail.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 77FFE1200B9; Fri, 3 Jan 2020 08:58:15 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.998
X-Spam-Level:
X-Spam-Status: No, score=-1.998 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eZ5CeVa2oOVI; Fri, 3 Jan 2020 08:58:12 -0800 (PST)
Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D146912008F; Fri, 3 Jan 2020 08:58:11 -0800 (PST)
Received: by mail-wr1-x444.google.com with SMTP id b6so43093327wrq.0; Fri, 03 Jan 2020 08:58:11 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=MTN+eH5B3TP5r5xRbjudXMwTawhBIZFUCDKfmjfSlDw=; b=O1BKTKeh6VFR93MoGN+rFBa/nLbEm5z8OfTxdAJv9bXZcfCVHcW5/3LRPXNK6ojo5j YyE4N5EenGf/1h9o0/9VnudpWb9NdKDkKIdSYkV1Yc510Gx9HkYEQUjx8aisyQeuWv8r Y/Nwm78fG+Pr6bBWu+/lwWtSyf5bZEuncoLVku/cslbe0Em/b5nhwmxZ+SDauznVg4Am rgprtnMmzt63OZoEHqX7EyDe5QEhacIpSRUrw96SaC/qXqKWR/voXrupPCK5fCX1SRXP 0PzC6LMx/p62IObZfy3pPCGHgqscOB8nHJ0AJmA1Aasmakown0Z6TcxD/P04VlceFcaP +amQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=MTN+eH5B3TP5r5xRbjudXMwTawhBIZFUCDKfmjfSlDw=; b=T6IYaQCfZGsdJJuE0fFL+WGrctTctcfRB0XuF/2faSRf5bfBtH67XK1uAiogKodOdX jusJkvX0PWiDFk7X1jZ2uH5I/P28BHkjnO1CHX/lB1u7KsCXVI6a/2yIMLc9LtZN6OKm 7zILDYDdntnMTdwgAa4p8d4hlGwha4GrrLuddMNRYfql/OhveMvrWRK3/9tqDRoV84ZV peBwP9eMafgsrhvOr/XyaNoVeuN1j7CTO1JrsLAQbcv7otD/kX1zmKOpP3wyxeA2LHDh m1LII8J0dH6Ojb0rH+Reccq0m6U8CQjma0vaiDAQMqx7qziHJqSgJWaXTNNpQ0VlGwW2 3bAA==
X-Gm-Message-State: APjAAAVtnusa6EEGmMu+md0XRs65eIRROmb3hOvc1chlUIFwg/VcWN/1 id56WQE6olaleS6X12AyMNM=
X-Google-Smtp-Source: APXvYqyMEL7/jvOkMsJ2bhP0wQ194zc0InMxqn6WPWUmbHnEhfWPRpaFXTaa67dPX0QsfsuP54G3Bw==
X-Received: by 2002:adf:806e:: with SMTP id 101mr16768164wrk.300.1578070690225; Fri, 03 Jan 2020 08:58:10 -0800 (PST)
Received: from broadband.bt.com ([2a00:23a8:4140:0:3894:cb5f:d37a:1d9c]) by smtp.gmail.com with ESMTPSA id x10sm60737494wrp.58.2020.01.03.08.58.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 03 Jan 2020 08:58:09 -0800 (PST)
From: Stewart Bryant <stewart.bryant@gmail.com>
Message-Id: <26A6BF83-2345-42DC-82CC-9B7693F851D9@gmail.com>
Content-Type: multipart/alternative; boundary="Apple-Mail=_4B26820A-6830-4105-A828-83F329BC1B13"
Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3601.0.10\))
Date: Fri, 3 Jan 2020 16:58:07 +0000
In-Reply-To: <E0C26CAA2504C84093A49B2CAC3261A43B93BD37@dggeml511-mbx.china.huawei.com>
Cc: "Andrew G. Malis" <agmalis@gmail.com>, "draft-bryant-mpls-sfl-control@ietf.org" <draft-bryant-mpls-sfl-control@ietf.org>, mpls-chairs <mpls-chairs@ietf.org>, mpls <mpls@ietf.org>
To: Zhenghaomian <zhenghaomian@huawei.com>
References: <E0C26CAA2504C84093A49B2CAC3261A43B93BD37@dggeml511-mbx.china.huawei.com>
X-Mailer: Apple Mail (2.3601.0.10)
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/ZiCkZDlaqf_SkSknUmFfnZX9p04>
Subject: Re: [mpls] More comments from another Reviewer//Re: MPLS-RT review of draft-bryant-mpls-sfl-control
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 03 Jan 2020 16:58:15 -0000


> On 3 Jan 2020, at 02:44, Zhenghaomian <zhenghaomian@huawei.com> wrote:
> 
> Hi, All,
>  
> Happy new year to you all.
>  
> I am another MPLS-RT reviewer for this document, and would like to follow up in this thread, by starting from reviewing the latest draft-bryant-mpls-sfl-control-05. Generally I think this is a complete work with self-contained solution, and I assume the importance of the document has been evaluated by the WG chairs and experts. Some comments are listed below as a ‘MPLS beginner’J
>  
> 1.       Section 1 Introduction
> "well managed" should be "well-managed"; -> this also applies for section 7 security considerations.
>  "withdrawn" should be "withdraw", -> this also applies for the abstract text.

Withdrawn correction done.

I have put the hyphens in, but I am not sure whether they are required. 

>  
> 2. The RFC6374 looks slightly different than other RFC citations, as the '[]' is missing; please check the formatting.

Thanks for picking that I. I regenerated the .mkd from a .txt file and missed that reference. More importantly the RFC was not in the reference list at the end of the document.

It is now fixed in -06.


>  
> 3. section 3.1 SFL Control Message
> I am curious on the bits allocation "26-bit Session Identifier" and "6-bit SFL Batch", which is not typical (my intuitive is 24+8), and there is no reason in the explanation text below the TLV. We need to confirm 1) the allocation is intended to be 26+6; 2) add something to the TLV explanation, for example:


The choice of the 26 bit size is inherited from RFC 6374 and needs to be the same.

I have added in the (6-bits) because it is unusual, but it is obvious from the figure and we do not specify the size of any of the other fields.

The use of 6 bits was a compromise. Strictly the protocol would work without it, but at the cost of extra messages and extra state. Allowing the use of a 6-bit batch identifier is convenient in that it reuses the DS field in the RFC6374 structure. If we had made it larger we would have needed to use an additional longword in the protocol.

A batch size of 64 seemed a good engineering compromise when we drew up the design.


>  
> OLD:
> SFL Batch      Used where the SFLs for this Session Identifier
>                managed across multiple SFL Control Messages.  A given
>                set of SFLs MUST be retained in the same batch.
> NEW:
> SFL Batch (6 bits) Used where the SFLs for this Session Identifier
>                   managed across multiple SFL Control Messages.  A given
>                   set of SFLs MUST be retained in the same batch. 
>  

Done


> 4. section 3.1 SFL Control Message
> Regarding the flags, my understanding is that the intention is to use the first bit to indicate query/respond, and pad the other 3 bits as 0. The processing of '0' bits is understood as "MUST be set to 0 by sender and ignored by receiver". Is it correct? If yes, the following statement may be easier:
> OLD:
> Flags: The format of the Flags field is shown below.
>  
>                               +-+-+-+-+
>                               |R|0|0|0|
>                               +-+-+-+-+
>  
>                         SFL Control Message Flag
>  
>    R: Query/Response indicator.  Set to 0 for a Query and 1 for a
>       Response.
>  
>    0: Set to zero by the Sender and ignored by the Receiver.
>  
> NEW:
> Flags (4 bits): The first bit is set to 0 for a query and 1 for a
> response; the next 3 bits MUST be set to 0 by the Sender and ignored
> by the Receiver.
>  

Remember that this is inherited from RFC 6374 and I have tried to use a similar presentation of information.

I have tidied the text a little to mirror the RFC 6374 layout.

I really do not think it is necessary to say 4-bits.


It now looks like this - not sure it it is back to where it started:

 Flags: The format of the Flags field is shown below.

                           +-+-+-+-+
                           |R|0|0|0|
                           +-+-+-+-+

                    SFL Control Message Flags.

The meanings of the flag bits are:

    R: Query/Response indicator.  Set to 0 for a Query and set
       to 1 for a Response.

    0: Set to zero by the Sender and ignored by the Receiver.

Note that this then style matches the text that follows.



>  
> 5. section 3.1 SFL Control Message
> Regarding the 'Control Code', do we allocate specific value for the query/response actions? For example, we can have request (control code = 0), refresh (control code = 1) and withdraw (control code =2) for a query. Currently there is no such allocations.

Thank you for noting that. That is the most important review comment. I will address it in a separate email.


>  
> 6. section 3.2.1.  Request/Grant
> In the first paragraph, when you say 'It sets ...' and 'It chooses ...', does the “it” refer the Querier?
> This problem confused me some times in later sections as well.

I have worked on this a bit and changed most of the “It” to Querier or Responder as appropriate.

>  
> 7. section 4. Return Path
> 'mulit-point' -> 'multi-point'
> The usage of comma and bracket confused me, does it mean the following?
> Where the MPLS LSP  (or other construct) is a multi-point to point or
> multi-point to multi-point, the RFC6374 Address TLV MUST be included
> in Query packet even if the response is requested in-band, since it is
> necessary to provide the necessary return address for this request.

I have clarified this.

Thank you for the review

Best wishes

Stewart

>  
> Thank you.
>  
> Best wishes,
> Haomian
>  
>  
> 发件人: mpls [mailto:mpls-bounces@ietf.org <mailto:mpls-bounces@ietf.org>] 代表 Stewart Bryant
> 发送时间: 2020年1月3日 0:28
> 收件人: Andrew G. Malis <agmalis@gmail.com <mailto:agmalis@gmail.com>>
> 抄送: draft-bryant-mpls-sfl-control@ietf.org <mailto:draft-bryant-mpls-sfl-control@ietf.org>; mpls-chairs <mpls-chairs@ietf.org <mailto:mpls-chairs@ietf.org>>; mpls <mpls@ietf.org <mailto:mpls@ietf.org>>
> 主题: Re: [mpls] MPLS-RT review of draft-bryant-mpls-sfl-control
>  
>  
> Fixed in the master I will use for the next release.
>  
> - Stewart
> 
> 
> On 2 Jan 2020, at 14:47, Andrew G. Malis <agmalis@gmail.com <mailto:agmalis@gmail.com>> wrote:
>  
> Stewart,
>  
> Looking at the diff from the previous version, I just noticed a typo that I missed earlier. In the first paragraph of the introduction, "withdrawn" should be "withdraw". I also see that you added an Oxford comma, which is fine by me! :-)
>  
> Cheers,
> Andy
>  
>  
> On Thu, Jan 2, 2020 at 9:40 AM Andrew G. Malis <agmalis@gmail.com <mailto:agmalis@gmail.com>> wrote:
> Stewart,
>  
> Glad to be of assistance.
>  
> Cheers,
> Andy
>  
>  
> On Thu, Jan 2, 2020 at 9:09 AM Stewart Bryant <stewart.bryant@gmail.com <mailto:stewart.bryant@gmail.com>> wrote:
> 
> Hi Andy
> 
> Thank you for the review.
> 
> > On 30 Dec 2019, at 19:31, Andrew G. Malis <agmalis@gmail.com <mailto:agmalis@gmail.com>> wrote:
> > 
> > All,
> > 
> > I’ve been selected as an MPLS-RT reviewer for draft-bryant-mpls-sfl-control,
> > which is currently a candidate for MPLS WG adoption.
> > 
> > In general I believe that the draft is ready for WG adoption. However, I have a few minor comments which may be addressed either before or after WG adoption.
> > 
> > 1. The Security Considerations section says "It is assumed that this protocol is run in a well managed MPLS network with strict access controls preventing unwanted parties from generating MPLS OAM packets." While this is true of most (all?) MPLS networks, this assumption should also be stated in the abstract or Introduction as well.
> 
> I have added a line to the Introduction.
> 
> I generally work on the assumption that the purpose of the Abstract is to help the potential reader decide if they want to read the document (or more likely to help a search engine match the document against a query) and I am unconvinced as to value of the qualification text in deciding whether to read the rest of the document.
> 
> 
> > 
> > 2. Section 8 contains the line "Force references to appear with mkd [RFC3032] [RFC5036]". However, both references appear elsewhere as well, so this line can be removed.
> 
> The earlier references are in text that I included as a figure to force the layout style I wanted, and the markdown compiler ignores references in figures. The compiling process excluded unused references so they have to be forced. I have changed the text to
> 
> RFC Editor please remove this note which is used to force the following references to appear {{RFC3032}} {{RFC5036}}
> 
> > 
> > 3. I would move "I-D.ietf-mpls-sfl-framework" to the Normative References, as understanding it is necessary to understand this draft.
> > 
> 
> The framework is informational and so the reference would become a down-ref. I will leave it to the chairs and ADs on how they want to proceed with this. It is not unusual for a framework to be required reading and yet informational.
> 
> 
> > 4. The text in Section 2 is out of date. The current wording is:
> > 
> > The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL NOT", "SHOULD", "SHOULD NOT", "RECOMMENDED", "NOT RECOMMENDED", "MAY", and "OPTIONAL" in this document are to be interpreted as described in BCP 14 [RFC2119] [RFC8174] when, and only when, they appear in all capitals, as shown here.
> > 
> > RFC 8174 should also be added as a normative reference.
> 
> Done
> 
> > 
> > 5. When this draft was last updated, Stewart included the following in an email message to the MPLS WG:
> > 
> > "Next to do is authors of draft-bryant-mpls-sfl-control to check that 
> > this is suitable to be called by another protocol to act on its behalf.
> > When we are satisfied that that is that case and any consequentially 
> > necessary amendments have been make to the other drafts we will
> > request adoption of draft-bryant-mpls-sfl-control and then WGLC on all 
> > three."
> > 
> > There's been no follow-up indication that this analysis has occurred, or further revision to the draft. If it has, the authors should indicate as such on the list. If it hasn't, then this will serve as a reminder to the authors.
> 
> 
> George and I discussed this and concluded that the design was satisfactory.
> 
> I certainly indicated this to the chairs but I cannot remember if I posted that to the list. If any reader of this note (which will go to the MPLS list) has any technical concerns WRT this point, please raise them and we will work with you to address the issue.
> 
> New version (05) has been uploaded.
> 
> Best regards
> 
> Stewart
> 
> 
> 
> > 
> > Thanks,
> > Andy
> > 
>