Re: [mpls] MPLS-RT review of draft-chandra-mpls-ri-rsvp-frr

"lizho.jin@gmail.com" <lizho.jin@gmail.com> Thu, 19 November 2015 15:28 UTC

Return-Path: <lizho.jin@gmail.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EF9871B2B76; Thu, 19 Nov 2015 07:28:16 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 0.701
X-Spam-Level:
X-Spam-Status: No, score=0.701 tagged_above=-999 required=5 tests=[BAYES_50=0.8, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 25evqdlsmrVS; Thu, 19 Nov 2015 07:28:10 -0800 (PST)
Received: from mail-pa0-x231.google.com (mail-pa0-x231.google.com [IPv6:2607:f8b0:400e:c03::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2C9041B2B85; Thu, 19 Nov 2015 07:28:00 -0800 (PST)
Received: by pabfh17 with SMTP id fh17so86942827pab.0; Thu, 19 Nov 2015 07:27:59 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:references:mime-version:message-id :content-type; bh=+J2vpLpKk4j0MUzVJLznQT1KpUAWzkuBvK1kxaBHaJY=; b=LkgN5di3p0D0DuPrwN4d5HPIBxccXArpsLT1SbyWP/xckFqBse4v74YDm0mc0OnSN5 P2qOEjhVuSsjfPTD4KUAXAg5WYMw3yuFv2N3DoYZGaLPclz77gVEHPqsdPi7VQY2ncl+ 7fIe5QQR+S5sK4ebVFzwMcygQyNwHQx8zHpWq2Ptw0/Gxda20j1ndaDWSmvapyTjI2t1 HOoBkrNm1VOCzIGxR/bomS4erC0dTCQQuT17gVitpvyTyrYlipRn4CM/GEKmFdc+C3LE CSyVR3ESB8tCBQus2sF9HZItNuEM8psB/9CbOUTbFWwkV8pOOYmi5G6I/i5UtBK4jJN/ 7R0A==
X-Received: by 10.68.241.65 with SMTP id wg1mr11443196pbc.101.1447946879737; Thu, 19 Nov 2015 07:27:59 -0800 (PST)
Received: from Lizhong ([111.170.68.223]) by smtp.gmail.com with ESMTPSA id wq1sm11364767pbc.49.2015.11.19.07.27.53 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 19 Nov 2015 07:27:58 -0800 (PST)
Date: Thu, 19 Nov 2015 23:29:05 +0800
From: "lizho.jin@gmail.com" <lizho.jin@gmail.com>
To: loa <loa@pi.nu>, "sriganesh.kini" <sriganesh.kini@ericsson.com>, "mustapha.aissaoui" <mustapha.aissaoui@alcatel-lucent.com>, "lucy.yong" <lucy.yong@huawei.com>, "guijuan.wang" <guijuan.wang@ericsson.com>, draft-chandra-mpls-ri-rsvp-frr <draft-chandra-mpls-ri-rsvp-frr@ietf.org>, mpls-chairs <mpls-chairs@ietf.org>
References: <5628D430.4070602@pi.nu>
X-Priority: 3
X-GUID: FE23E52C-A93F-43D4-8B54-2A802546BA4D
X-Has-Attach: no
X-Mailer: Foxmail 7, 2, 5, 140[en]
Mime-Version: 1.0
Message-ID: <201511192320355454636@gmail.com>
Content-Type: multipart/alternative; boundary="----=_001_NextPart473838681311_=----"
Archived-At: <http://mailarchive.ietf.org/arch/msg/mpls/_c2UU_oX7lXdx4GoB017fSzd_do>
Cc: mpls <mpls@ietf.org>
Subject: Re: [mpls] MPLS-RT review of draft-chandra-mpls-ri-rsvp-frr
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Nov 2015 15:28:17 -0000

Hi All 
I reviewed review of draft-chandra-mpls-ri-rsvp-frr as the member of MPLS 
Review Team. I think the document resolves a real problem in FRR, and it is 
useful and technically sound. At the same time, I have several questions, and
would appreciate to resolve them before WG adoption. 

Abstract 
[Lizhong] When I finish reading Abstract, I hope to know what is the 
refresh-interval independent FRR. Could you add the key point of the 
solution in the Abstract section? 

Section 4.1.1. 
- After signaling protection availability, if the PLR finds that 
the protection becomes unavailable then it SHOULD attempt to make 
protection available. The PLR SHOULD wait for a time out before 
removing SUMMARY_FRR_BYPASS_ASSIGNMENT sub-object in RRO and 
triggering PATH downstream. On the other hand, the PLR need not 
wait for a time out to add SUMMARY_FRR_BYPASS_ASSIGNMENT sub- 
object in RRO and may immediately trigger PATH downstream. 
[Lizhong] what is "On the other hand" referring here? A bit confused. 

Section 4.1.5. 
The "remote" state is identical to the protected LSP path 
state except for the difference in HOP object. The HOP object 
[Lizhong] HOP is RSVP_HOP, right? If true, could you use RSVP_HOP as 
defined in RFC2205? 

Section 4.1.5. 
corresponding to the "remote" path state contains the address of 
remote node signaling adjacency with PLR. 
[Lizhong] a bit confused the above description. The HOP object contains 
the address of PLR, right? Then it seems it should be described as: 
"corresponding to the "remote" path state contains the address of 
remote node signaling adjacency with MP." 

Section 4.1.5. 
- MP receives PathTear, or 
[Lizhong] here, PathTear refers to normal or "Remote" PathTear, right? 

Section 4.1.5. 
Unlike the normal path state that is either locally generated on 
Ingress or created from PATH message from Phop node, the "remote" 
path state is not signaled explicitly form PLR. 
[Lizhong] typo, "form" should be "from". 

Section 4.1.5. 
Such message tearing down 
"remote" path state is called "Remote PathTear. 
[Lizhong] What's the TTL value of "Remote" PathTear message? 

Section 4.3.3.
M bit 
This bit indicates that the message SHOULD be processed based on the 
condition whether the receiving node is Merge Point or not. 
[Lizhong] should define the value of M bit. What's the meaning of "1" or "0". 

Section 4.4. 
If the Ingress wants to tear down the LSP because of a management 
event while the LSP is being locally repaired at a transit PLR, it 
would not be desirable to wait till backup LSP signaling to perform 
state cleanup. 
[Lizhong] The state "being locally repaired" refers to the state after 
step 1, before step 2 in section 3, right? Hope to describe explicitly. 

Section 4.4.1. PLR Behavior on Local Repair Failure 
[Lizhong] Consider the case in figure 1, if link between B and C fail, 
then B will send "remote" PathTear to D, and then D will send pathTear 
downstream. But How to clear the state on node C? We need some way to 
let A to send "remote" PathTear to C. 

The last one is, will you consider the impact to bidirectional LSP FRR described 
in draft-ietf-teas-gmpls-lsp-fastreroute-03?



Regards
Lizhong
 
From: Loa Andersson
Date: 2015-10-22 20:18
To: Sriganesh Kini; Lizhong Jin; Aissaoui, Mustapha (Mustapha); Lucy yong; Guijuan Wang 3; draft-chandra-mpls-ri-rsvp-frr@ietf.org; mpls-chairs@ietf.org
Subject: MPLS-RT review of draft-chandra-mpls-ri-rsvp-frr
Sri, Lizhong, Mustapha, Lucy, and Guijuan Wang,
 
You have be selected as MPLS-RT reviewers for 
draft-chandra-mpls-ri-rsvp-frr-02.
 
Note to authors: You have been CC'd on this email so that you can know
that this review is going on. However, please do not review your own
document.
 
Reviews should comment on whether the document is coherent, is it
useful (ie, is it likely to be actually useful in operational networks), 
and is the document technically sound?
 
We are interested in knowing whether the document is ready to be
considered for WG adoption (ie, it doesn't have to be perfect at this
point, but should be a good start).
 
Reviews should be sent to the document authors, WG co-chairs and WG
secretary, and CC'd to the MPLS WG email list. If necessary, comments
may be sent privately to only the WG chairs.
 
If you have technical comments you should try to be explicit about what
needs to be resolved before adopting it as a working group document, and
what can wait until the document is a working group document and the
working group has the revision control.
 
Are you able to review this draft by November 12, 2015? Please respond
in a timely fashion.
 
Thanks, Loa
(as MPLS WG chair)
 
 
 
-- 
 
 
Loa Andersson                        email: loa@mail01.huawei.com
Senior MPLS Expert                          loa@pi.nu
Huawei Technologies (consultant)     phone: +46 739 81 21 64