Re: [mpls] MPLS wglc draft-ietf-mpls-base-yang

tom petch <ietfc@btconnect.com> Fri, 21 February 2020 16:30 UTC

Return-Path: <ietfc@btconnect.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 69A06120879; Fri, 21 Feb 2020 08:30:17 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=btconnect.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cPLhywtvEA2s; Fri, 21 Feb 2020 08:30:14 -0800 (PST)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2102.outbound.protection.outlook.com [40.107.20.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 673E41201EA; Fri, 21 Feb 2020 08:30:13 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C6rZiYf5tarLLkYMFO7YI5oCk7w1w+d8Uc0B3jfQ7cHzO22KRpumysB945wD+wDd7SxNoHreMTJAWaRKl4f0EZZ8oDBOJKJLU9kb6JqfLHP4ZLbUUAWSQRwveVjxsw86SB/IrDAZtPXygQj8VMDRzeunOVnA3O0WpGC85nMPr65XusiDz/dr/9hcBEc4qFrjvSNxmZ+6GGllOW8uceoV9m43bgCvTNyhWmZXaJZKRh6P4axqFomt4BcrpNcVhmh7xjeQGvkjhDhOP0IKtrPkKw+mmDXlKPcZQpMy/xXLO4LlYKVjtULexEJ7GYA/adCuQZ5Uv7P5b+R/h/eibISl/g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UM0s/abXQ+Nw3r7KUCLdTgZuOUm3PcPv5JhmcJyxq10=; b=RpG3ScmIXVkZRjWSBPNm1DTQeOpvL0e/wVAv2rC8UpofnaALU9m7t5uj4x9lFBtcA74cUAjnkigB2r7X35TgM2zS7odwwtw4RhheF6MQUdu+/CazKEKnPZL/cgVoxTaPKJC6wYZ3M6+RJkhYmAPpjgusnFs7gVE7X5JkKe3HXTAbzJ2hw6XG9e7nZwhYn1EjuOS/uH90cFzMojb77lqQIkFnm37XT2togPXJ+PLyWoVAiTmyzMLEuBtdFsBxXK9tiWYEsmzFoq84TILds7vNxlNtBRdxEuEemsMen7HtP17u2ErONlpF8tz+Y1hYeAmuhU59hYtvS35iRKL0hQpkRg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=btconnect.com; dmarc=pass action=none header.from=btconnect.com; dkim=pass header.d=btconnect.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=btconnect.onmicrosoft.com; s=selector2-btconnect-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UM0s/abXQ+Nw3r7KUCLdTgZuOUm3PcPv5JhmcJyxq10=; b=q+DBvZmISvtE9avPY8uTxpEQ2pomKvsXPg/OuT4scrViQq2gFOA/O7Txp8EXJZhBLVbxBfZqPFDQfZpZFDsnfn6yqp/tgrLpePvXOQEwUFCgYTekOqYhOnMB8FZbNvfVFj5ORTk/dOxMUGPhOZJ3IQqxPNgeqKfEzDQCwPs3Wzc=
Received: from DB7PR07MB5657.eurprd07.prod.outlook.com (20.178.85.222) by DB7PR07MB5451.eurprd07.prod.outlook.com (20.178.45.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2750.9; Fri, 21 Feb 2020 16:30:12 +0000
Received: from DB7PR07MB5657.eurprd07.prod.outlook.com ([fe80::450e:a4e2:e88e:dbcb]) by DB7PR07MB5657.eurprd07.prod.outlook.com ([fe80::450e:a4e2:e88e:dbcb%6]) with mapi id 15.20.2750.016; Fri, 21 Feb 2020 16:30:11 +0000
From: tom petch <ietfc@btconnect.com>
To: Tarek Saad <tsaad@juniper.net>, Loa Andersson <loa@pi.nu>, "mpls@ietf.org" <mpls@ietf.org>
CC: "mpls-chairs@ietf.org" <mpls-chairs@ietf.org>, "draft-ietf-mpls-base-yang@ietf.org" <draft-ietf-mpls-base-yang@ietf.org>
Thread-Topic: [mpls] MPLS wglc draft-ietf-mpls-base-yang
Thread-Index: AQHVtlY6DqL/m7q1BUSyzqpktbiPc6fr772sgAlRoUKALSWZAIADz/8g
Date: Fri, 21 Feb 2020 16:30:11 +0000
Message-ID: <DB7PR07MB56577E28162DFB1CC17028FAA0120@DB7PR07MB5657.eurprd07.prod.outlook.com>
References: <2e2ce194-ed62-d225-ca7e-97e373c9c5c9@pi.nu> <DB7PR07MB565756000718666B19277A81A0370@DB7PR07MB5657.eurprd07.prod.outlook.com> <DB7PR07MB5657487FF5F4DB2E0F2006FCA00D0@DB7PR07MB5657.eurprd07.prod.outlook.com>, <080939AD-4BE0-4138-AAF6-34141CD36385@juniper.net>
In-Reply-To: <080939AD-4BE0-4138-AAF6-34141CD36385@juniper.net>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
msip_labels: MSIP_Label_9784d817-3396-4a4f-b60c-3ef6b345fe55_Enabled=true; MSIP_Label_9784d817-3396-4a4f-b60c-3ef6b345fe55_Name=Juniper Business Use Only; MSIP_Label_9784d817-3396-4a4f-b60c-3ef6b345fe55_Enabled=true; MSIP_Label_9784d817-3396-4a4f-b60c-3ef6b345fe55_SiteId=bea78b3c-4cdb-4130-854a-1d193232e5f4; MSIP_Label_9784d817-3396-4a4f-b60c-3ef6b345fe55_ContentBits=0; MSIP_Label_9784d817-3396-4a4f-b60c-3ef6b345fe55_Method=Standard; MSIP_Label_9784d817-3396-4a4f-b60c-3ef6b345fe55_ActionId=5c7ae61b-4200-4976-b63d-00007479d7aa; MSIP_Label_9784d817-3396-4a4f-b60c-3ef6b345fe55_SetDate=2020-02-19T05:55:45Z;
authentication-results: spf=none (sender IP is ) smtp.mailfrom=ietfc@btconnect.com;
x-originating-ip: [81.131.229.19]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: efcc1598-a3ef-4cf3-c105-08d7b6eb52cd
x-ms-traffictypediagnostic: DB7PR07MB5451:
x-microsoft-antispam-prvs: <DB7PR07MB54512E00071A4F23C5554E67A0120@DB7PR07MB5451.eurprd07.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:3631;
x-forefront-prvs: 0320B28BE1
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(396003)(136003)(376002)(366004)(39860400002)(346002)(199004)(189003)(76116006)(91956017)(66946007)(5660300002)(966005)(478600001)(81156014)(64756008)(4326008)(54906003)(66556008)(66476007)(66446008)(52536014)(81166006)(8936002)(110136005)(71200400001)(55016002)(186003)(316002)(9686003)(8676002)(26005)(2906002)(86362001)(33656002)(7696005)(6506007); DIR:OUT; SFP:1102; SCL:1; SRVR:DB7PR07MB5451; H:DB7PR07MB5657.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:0; MX:1;
received-spf: None (protection.outlook.com: btconnect.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: sT+ahNz/G5zvgS6DYRd7H2d5rnFkOLgupA1cUsdTPTUEv43hqTKFNRaIguoW/S41bKIaUANXQ6YpczrSbsgzTN54gJtvAp+0ZAAPYxf5HkPKS0i7GeDqBNd1dq4b5OTgaQTLj9BJ52DevhQFpBxXVaK9mSSpKOq3hheFG233zX8xw5FnpskZlohr7S5p919wos/CMgX/ZSmmvn+skm2dQFtgHd7LvTv1g6RRfvsjqRb0t1T4NuNmG96KBgqXM/7nVQokvxQoP92PBhzLrFMclGKEk79XR3z3jpJ9UTBNQCWNQ2AU2pLb0odP78JlqLl9AUoo2wsPmJYR1FUzy3pq/v6IF0ZBEQpjiwafURw1JuKG24eSj2W4MCep41WboqUgd/P5TmAjVSDkcvGrjHZ6r+Bz9DdFNOeJYEgTKmKvan82FJqk/9SX3yyape6gZyE6a1mRMQCG/+4ykgw5pNQ9B2HsG5rVVjIWP2WdMauJ0umN73JYmirDMTEk/t6ApdzOG8oUQyWDX6kGk69T6yZ3yQ==
x-ms-exchange-antispam-messagedata: wjYhLjxg/wDf+FATLlBHIIqmxdyb4VkXZV37KAiDgsr4AprAmD3qHFgMsz7TiE/YxN8Rs63+Mptw5h32+DIjYAQrNLRH13YQiFuEcWu9Re2Oz0d/NJ2a/6JgFKEu/y0CCc2DCKFie3aD5zrO99Go5w==
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: btconnect.com
X-MS-Exchange-CrossTenant-Network-Message-Id: efcc1598-a3ef-4cf3-c105-08d7b6eb52cd
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Feb 2020 16:30:11.7870 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: cf8853ed-96e5-465b-9185-806bfe185e30
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /XXXIlVWdpmNTpHjiKHC9FPhHUneg3S9Y0Ce+ryw3axamM5Bx9gF/P1eV73Vh8zFQAzoDollTmAev0zOunmnQw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR07MB5451
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/a2tXJpAjJF2glwUMUY6cj-5onIk>
Subject: Re: [mpls] MPLS wglc draft-ietf-mpls-base-yang
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Feb 2020 16:30:18 -0000

Tarek

progressing ... <tp> inline

________________________________________
From: Tarek Saad <tsaad@juniper.net>
Sent: 19 February 2020 06:00

Thanks much for your review and useful comments. We have posted a new revision -12 at https://tools.ietf.org/html/draft-ietf-mpls-base-yang-12 that addresses those. Let us know if you have further comments.
Also, see inline for responses on closure.

On 1/21/20, 7:38 AM, "tom petch" <ietfc@btconnect.com> wrote:

Some more technical thoughts on this I-D

        Abstract

        LSP is not in the RFC Editor list of 'so well known ...'
[TS]: it is listed at https://www.rfc-editor.org/materials/abbrev.expansion.txt

<tp> as Acee points out, it lacks the asterisk that says that no expansion is needed :-(

        s.2.1
           The other MPLS route(s) that are non-IP prefix routes are modelled by
           introducing a new "mpls" address-family RIB as per recommendation .

        Where is that?

<tp> I was looking for a reference for the recommendation - is this the routing RFC, RFC8349 s.5.2?


[TS]: Please refer to identity below defined in the model which has rt:address-family as base.
  identity mpls {
        base rt:address-family;
        description
          "This identity represents the MPLS address family.";
  }
        s.2.2
           interfaces-mpls:
                  A YANG grouping that describes the list of MPLS enabled interfaces
                  on a device.

           label-blocks:
                  A YANG grouping that describes the list of MPLS enabled interfaces
                  on a device.

        um?
[TS]: we corrected the description. See below:
NEW:
A YANG grouping that describes the list of assigned MPLS label blocks and its properties.


        YANG Module
                 Copyright (c) 2018 IETF Trust

                leaf loadshare {
        I  would  value a reference for this.
[TS]: rfc3031 section 3.11 and  3.12.

<TP>  well sort of; those sections talk about sharing across equal cost paths which seems somewhat simpler - I understand the YANG DESCRIPTION but would expect it to be described in an RFC somewhere.


          grouping interface-mpls-properties {
        ...
                  type boolean;
                  description
                   "'true' if mpls encapsulation is enabled on the interface.
                   'false' if mpls encapsulation is enabled  on the interface.";

<tp> so true means enabled and false means ..  enabled ; clear but logical?


                leaf mtu {  type uint32; description
                        "MPLS Maximum Transmission Unit (MTU) in bytes";

        um what is included in MTU here  c.f.draft-ietf-netmod-intf-ext-yang-07
        which  includes L2 header but not FCS in Layer 2 MTU;
        a reference might help
[TS]: includes L2 MTU + maximum MPLS label stack size. rfc3032 section 3.2.

<tp> well no; MTU does not appear in RFC3032 s.3.1; other terminology does and I want to map the terminology of this I-D - MTU- to the terminology of s.3.1

That is all

Tom Petch
</tp>

          grouping interfaces-mpls {    description "List of MPLS interfaces";
                list interface {   key "name";  description "List of MPLS
        interfaces";
                  leaf name {   type if:interface-ref;
                        description   "The name of a configured MPLS interface";

        no conditional so every RIP or dial up X.25 e.g.is going to get this:-( probably ok

          augment "/rt:routing" {
        ditto, although probably less significant
[TS]: added feature mpls, and added if-feature check under the augmentations.

          augment "/rt:routing/rt:ribs/rt:rib/rt:routes/rt:route/"
                        + "rt:next-hop/rt:next-hop-options/rt:simple-next-hop" {
                description
                  "Augment 'simple-next-hop' case in IP unicast routes.";

        other I-D augment control plane/protocols/static-routes
[TS]: the MPLS Static model is a separate model that is described in draft-ietf-mpls-static-yang.

Regards,
Tarek

        Tom Petch