[mpls] Rtgdir last call review of draft-ietf-mpls-rfc6374-sfl-08
Andy Smith via Datatracker <noreply@ietf.org> Mon, 28 December 2020 21:23 UTC
Return-Path: <noreply@ietf.org>
X-Original-To: mpls@ietf.org
Delivered-To: mpls@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id AF8873A0DF3; Mon, 28 Dec 2020 13:23:23 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: Andy Smith via Datatracker <noreply@ietf.org>
To: rtg-dir@ietf.org
Cc: draft-ietf-mpls-rfc6374-sfl.all@ietf.org, last-call@ietf.org, mpls@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 7.24.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <160919060367.7736.6482165412422849474@ietfa.amsl.com>
Reply-To: Andy Smith <ajsphila@gmail.com>
Date: Mon, 28 Dec 2020 13:23:23 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/aHBjifb6A5v6JmLt50zbFApMDKk>
Subject: [mpls] Rtgdir last call review of draft-ietf-mpls-rfc6374-sfl-08
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 28 Dec 2020 21:23:24 -0000
Reviewer: Andy Smith Review result: Has Nits Hello, I have been selected as the Routing Directorate reviewer for this draft. The Routing Directorate seeks to review all routing or routing-related drafts as they pass through IETF last call and IESG review, and sometimes on special request. The purpose of the review is to provide assistance to the Routing ADs. For more information about the Routing Directorate, please see http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir Although these comments are primarily for the use of the Routing ADs, it would be helpful if you could consider them along with any other IETF Last Call comments that you receive, and strive to resolve them through discussion or by updating the draft. Document: draft-ietf-mpls-rfc6374-sfl-08.txt Reviewer: Andy Smith Review 28 December 2020 IETF LC End Date: date-if-known Intended Status: Proposed Standard Summary: This document is basically ready for publication, but has nits that should be considered prior to publication. Comments: The document is easy to follow. It is a novel idea that solves a reasonable to understand problem. Major Issues: Nothing obvious. Minor Issues: Section 5: This it is proposed -> Thus it is proposed Section 6: large set of overlapping measurement type -> large set of overlapping measurement types "increased operation and capital cost" -> do you really want to make this claim? If so need to quantify it. Section 7.1: "when a packet had a delay relative to its predecessor of 2us both the up to 1us and the 2us counter" doesn't make sense. reword Section 7.2: "Characteristic’s 1 and 2" no apostrophe needed Section 7.3: "create a large demand on storage in the instrumentation system" -> quantify this if this claim is going to be made Section 9.1: "Editor’s Note we" - Clarify who 'we' is. The authors? the WG? don't use first person. Nits: A number of run-on sentences are in the document, especially in the Introduction. While not fatal, it makes it a chore to read in parts. Consider breaking some long sentences apart. There is a lack of comma usage throughout the document, a nit, but hurts readability.
- [mpls] Rtgdir last call review of draft-ietf-mpls… Andy Smith via Datatracker
- Re: [mpls] Rtgdir last call review of draft-ietf-… Stewart Bryant
- Re: [mpls] Rtgdir last call review of draft-ietf-… BRUNGARD, DEBORAH A