[mpls] Alvaro Retana's No Objection on draft-ietf-mpls-lsp-ping-lag-multipath-06: (with COMMENT)

Alvaro Retana via Datatracker <noreply@ietf.org> Fri, 08 March 2019 21:55 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: mpls@ietf.org
Delivered-To: mpls@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 1EC9B130DCD; Fri, 8 Mar 2019 13:55:00 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: Alvaro Retana via Datatracker <noreply@ietf.org>
To: "The IESG" <iesg@ietf.org>
Cc: draft-ietf-mpls-lsp-ping-lag-multipath@ietf.org, mpls-chairs@ietf.org, loa@pi.nu, mpls@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.93.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <155208210011.3264.12148702952456660789.idtracker@ietfa.amsl.com>
Date: Fri, 08 Mar 2019 13:55:00 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/bTcB2HeLCyYwlm2F9uZ9cmle_wA>
Subject: [mpls] Alvaro Retana's No Objection on draft-ietf-mpls-lsp-ping-lag-multipath-06: (with COMMENT)
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Mar 2019 21:55:05 -0000

Alvaro Retana has entered the following ballot position for
draft-ietf-mpls-lsp-ping-lag-multipath-06: No Objection

When responding, please keep the subject line intact and reply to all
email addresses included in the To and CC lines. (Feel free to cut this
introductory paragraph, however.)


Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
for more information about IESG DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://datatracker.ietf.org/doc/draft-ietf-mpls-lsp-ping-lag-multipath/



----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------

(1) The Update to rfc8029 is not clearly explained.  The new functionality
introduced in this document is clear, but it seems to me that it is optional
from the point of view that it is only needed when LAGs exist, and even then,
only the Initiator and the Responder need to implement the enhancements.  IOW,
the Update that this document presents is not one that is needed by all rfc8029
implementations.  I'm looking for text that explains that.

(2) §6: "Otherwise, if the responder does not know the LSR Capability TLV, an
MPLS echo reply with the return code set to "One or more of the TLVs was not
understood" MUST be sent back to the initiator LSR."  Given that this is the
case where the new TLV is not known, then we can't Normatively direct those
nodes to do anything (since they probably don't implement anything in this
document).  s/MUST/must + add a reference to rfc8029 (where the behavior is
specified) [The same text appears again in §3 and §3.2.  Writing the
specification is one place is enough.]

BTW, according to rfc8029, the return code will be sent back only if the TLV is
mandatory, but §6 defines it as optional.  Please be clear and specific about
the definition and the instructions to IANA.

(3) This document doesn't talk about what should be done if a response is not
received, at any point in the process.  I searched in rfc8029, but didn't find
anything related to timeouts...only §4.8 (Non-compliant Routers), which
includes a process on what to do if a reply is not received.  That process
doesn't seem to apply to this document -- what should an initiator do if a
reply is not received?  I am specially interested in the discovery phases.

(4) [nit] In §7, the DS Flags should look like this (see rfc8012):

       0 1 2 3 4 5 6 7
      +-+-+-+-+-+-+-+-+
      | MBZ |G|E|L|I|N|
      +-+-+-+-+-+-+-+-+

(5) RFC8126 should be a Normative reference.