Re: [mpls] MPLS-RT experts review for draft-gandhi-mpls-rfc6374-sr

Huaimo Chen <huaimo.chen@futurewei.com> Sat, 13 June 2020 04:12 UTC

Return-Path: <huaimo.chen@futurewei.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A6C053A0915; Fri, 12 Jun 2020 21:12:59 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.989
X-Spam-Level:
X-Spam-Status: No, score=-1.989 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, HTTPS_HTTP_MISMATCH=0.1, RCVD_IN_MSPIKE_H2=-0.001, T_SPF_PERMERROR=0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=futurewei.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oVivS0Q6SVWi; Fri, 12 Jun 2020 21:12:57 -0700 (PDT)
Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2124.outbound.protection.outlook.com [40.107.236.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id CAF033A08AA; Fri, 12 Jun 2020 21:12:54 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KfMpoc9+64A4xE7iyUlxR1/mnk0vmDvJKVJYe375tuYpD4zWG6Il50Q82t7bb+nQqovwmUP2agRhbDfy6UBqlfSHsof3ybmvJCNTX5+aGTi6dSgnnppo07YvhuK2nJXhlICSRqEocvabeoLsa/2lEiAJjGotapamH8SKnnrNwC/Wt8mhL1GgrRPR0HDh1+/V2+gVPb1dpmkecZZH060n+5N4kYxO7RyLzCivIC0FTAyx0Pd3OYri+WL4DJVoZZcCoZlPyQLWy2inklwehFl74tu7zSwgneU/6Q5G6GXPqEI14AY8xviue/EsFcoYIDTQu8E1J8GcKBBamD+YMTGaZA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=shz6EJ4pn5zVGXB5Ko6qdkoalzX5Po11xYqdJsZtk8s=; b=ael0vzpffgs79hbwOjBHNFKpZRa8GRg3mOzngj+FZY+T2TXzhknl/+1bb2B3g5pdZM0YcGezcKagbepTGoAVZckc+6RmhkdqER7GhRGdTsP9vECr3I45qsHWNU2b/DEcXw7OC2+wY4mVtmA97nXzLlMnELhtyO/r0X+KL1qZU9YYD0up892gBZeyjrkbpWbmwWIXZw7pHc6niy7pRxDjzTgINzGeyLZxrbtnMWuIHB6kvt20l1FY9K5HkSxI8Me5d2s5sOX40yo6OTKNyKPnxqFhoU5IPovFK98b/BYaoM77CwGnbbqRnvjjsStZYEm16qwrfEoFiKm1QMJgM0cP4A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=futurewei.com; dmarc=pass action=none header.from=futurewei.com; dkim=pass header.d=futurewei.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Futurewei.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=shz6EJ4pn5zVGXB5Ko6qdkoalzX5Po11xYqdJsZtk8s=; b=sROPXsfhBdKQKjWAyByCR87XHLVFb54Q5Ks5jZpNuKPQ3FtJ8gr3jQPpXXLR5vHD93PoMYYJJufg3SMvpZhUwHWRBrIeUi/J70dTtBoGeQPylEOmlAkv8/E6F50Il9GZrfVbHNe4HFVgcu2v9f+ukKD3Sme+DoMO9FVfJKyCotU=
Received: from MN2PR13MB3117.namprd13.prod.outlook.com (2603:10b6:208:13a::20) by MN2PR13MB3775.namprd13.prod.outlook.com (2603:10b6:208:1e3::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3109.10; Sat, 13 Jun 2020 04:12:51 +0000
Received: from MN2PR13MB3117.namprd13.prod.outlook.com ([fe80::d5b6:8550:9c40:eec2]) by MN2PR13MB3117.namprd13.prod.outlook.com ([fe80::d5b6:8550:9c40:eec2%7]) with mapi id 15.20.3109.012; Sat, 13 Jun 2020 04:12:51 +0000
From: Huaimo Chen <huaimo.chen@futurewei.com>
To: Rakesh Gandhi <rgandhi.ietf@gmail.com>
CC: Tarek Saad <tsaad.net@gmail.com>, "mpls@ietf.org" <mpls@ietf.org>, "mpls-chairs@ietf.org" <mpls-chairs@ietf.org>, "draft-gandhi-mpls-rfc6374-sr@ietf.org" <draft-gandhi-mpls-rfc6374-sr@ietf.org>
Thread-Topic: [mpls] MPLS-RT experts review for draft-gandhi-mpls-rfc6374-sr
Thread-Index: AQHWI7UWOG/zz9wDNU+Ica/MrmV3JqjPxRCtgAJCjICABB8Jpg==
Date: Sat, 13 Jun 2020 04:12:51 +0000
Message-ID: <MN2PR13MB31172BA24640D22EC6C79782F29E0@MN2PR13MB3117.namprd13.prod.outlook.com>
References: <CH2PR19MB40241A395AAD7976CD74FE11FCA40@CH2PR19MB4024.namprd19.prod.outlook.com> <MN2PR13MB3117086E43C785B4A327D942F2820@MN2PR13MB3117.namprd13.prod.outlook.com>, <CAMZsk6ewhjakQYhdrh-_EH1Tr8exczygkK_xxaj5YdG570ihfA@mail.gmail.com>
In-Reply-To: <CAMZsk6ewhjakQYhdrh-_EH1Tr8exczygkK_xxaj5YdG570ihfA@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=futurewei.com;
x-originating-ip: [2601:199:4300:8e5a:c4c6:15ee:f48a:8bb8]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 1f3443a6-dca8-4a0c-4a92-08d80f500a26
x-ms-traffictypediagnostic: MN2PR13MB3775:
x-microsoft-antispam-prvs: <MN2PR13MB377514233C5BD9BD61B3E947F29E0@MN2PR13MB3775.namprd13.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8882;
x-forefront-prvs: 0433DB2766
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: fwdF8pBqe4A/M1m/8Kn7eEOVr4UsSI/dZhUxWwK3r6YWlvj54ffFbtlfr9P1MfUm74OyQQVyvzjvcEuIGgKftv6ym0UiZPGLUYP4hZwGEJTY+O47UqcsLzEwO9W0ne+34iCRvwYr97VFz5ztXEX2U+ySEYKRu1sFzK9uFs3WKxrFC3J0HMBPxInwTr44UkjhUyOgxdrULOhImtX86W3ntfVBwwYEglIi5A2TpRGkyUPTyyX41PgVicYMc1ybmnK3997Lr5wrN749rF/FTtc9qyQL5siyP+fGTTUz2I9ghvgGeMpUx0qnIIl4fKp4eYkJvE1CRJAYO6qr6WWJb3lfqO3PCFpcpYA/chWEW1wEVZOIVtifKnPs8FLdpbRt6Ur4tKddzKxpLtkUz2+Qjy1f/w==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR13MB3117.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(39840400004)(346002)(376002)(366004)(396003)(478600001)(166002)(83380400001)(76116006)(66446008)(86362001)(64756008)(6506007)(33656002)(71200400001)(7696005)(52536014)(44832011)(66476007)(66556008)(186003)(53546011)(966005)(55016002)(2906002)(5660300002)(19627405001)(66946007)(6916009)(8936002)(8676002)(4326008)(54906003)(9686003)(316002); DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata: Ba/gNsiK01j1VbX/0T6FaYW/prblotVGVDtPI3bGb2pYWlyJbQK/g8wiMSlj3qXNwxRcBQqnFkR9vq4nmgzT6djf0TbqWDs1NdegiKpiuuQsYhO9EzF5CwegHVBKHOWZQyubxNWeRxRIjy3SEt5HuHjet48vOP0MU+F4JAq3IYObd2cCwnCKT4GBWDliQZCjiL3MyCkq+zGFbHuKkK8/Tk54tdzX/0dvQMFXiqTYTO+cFVjvM69PbiiT/j97sLvas4WzPXz5Nv9VwAfiGrQsWlt4atuHf2FxOngSRLRtd8AAr5zXjlq1NBETV/+X6jcRkYGB5AwFWi4P9SnyE2HumuFw0x4tvyQXFMt7PrzIVnkcZJ+6XR0ZY/cBx+QNVGF5axIirT2GuCwttzZPdSxaWaU9OGt765Kr8Kh9nKSXiGPZ37d7EHNHxo6mzDWITW10zlHLoUMEvYOtQM0hrs+aa4ff6u3aVTBM+EcjQmtx1Ke4KWPpGoYANTLP50HI3TGtXEU6kWySpo9QWCZE9UCVjtJ/AN0CSI38mYCJZqLme+eNSIlUCYA0OcszCWUx9SSp
x-ms-exchange-transport-forked: True
Content-Type: multipart/alternative; boundary="_000_MN2PR13MB31172BA24640D22EC6C79782F29E0MN2PR13MB3117namp_"
MIME-Version: 1.0
X-OriginatorOrg: Futurewei.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1f3443a6-dca8-4a0c-4a92-08d80f500a26
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jun 2020 04:12:51.3198 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 0fee8ff2-a3b2-4018-9c75-3a1d5591fedc
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: NHSeU6kDqXaVVARW5SwyNlQwAbhOrBCeGpgomvMQ0YJDUZ/WUeUvdh8LHaUEf6kgWFl6UZBtmrz0bVoN55U0zQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR13MB3775
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/kK_NN-0PaZrpkXqqW1PtK5qDw3g>
Subject: Re: [mpls] MPLS-RT experts review for draft-gandhi-mpls-rfc6374-sr
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 13 Jun 2020 04:13:06 -0000

Hi Rakesh,

    Another SR P2MP draft is draft-shen-spring-p2mp-transport-chain.

Best Regards,
Huaimo
________________________________
From: Rakesh Gandhi <rgandhi.ietf@gmail.com>
Sent: Wednesday, June 10, 2020 9:03 AM
To: Huaimo Chen <huaimo.chen@futurewei.com>
Cc: Tarek Saad <tsaad.net@gmail.com>om>; mpls@ietf.org <mpls@ietf.org>rg>; mpls-chairs@ietf.org <mpls-chairs@ietf.org>rg>; draft-gandhi-mpls-rfc6374-sr@ietf.org <draft-gandhi-mpls-rfc6374-sr@ietf.org>
Subject: Re: [mpls] MPLS-RT experts review for draft-gandhi-mpls-rfc6374-sr

Thank you Huaimo for the detailed review and your support for the adoption.
Attached please find the updated document and diffs that address your comments.
Please see responses inline with <RG>..

On Mon, Jun 8, 2020 at 11:52 PM Huaimo Chen <huaimo.chen@futurewei.com<mailto:huaimo.chen@futurewei.com>> wrote:
Hi All,

    I have reviewed the document and have the following comments.

    1.  The document is useful and technically sound. It can be considered for WG adoption.

<RG> Thank you.

    2.  The document seems talking about the Loss Measurement Message and Delay Measurement Message. Should it have some texts for Combined Loss/Delay Measurement Message?

<RG> Added section 6.3.

    3.  There are a couple of IETF drafts about SR P2MP Path.. The document just mentions one of them and the Performance Measurement for a SR P2MP Path (or policy) is based on this one draft. Should the Performance Measurement for a SR P2MP Path (or policy) be general enough for all?

<RG> do you have a specific P2MP draft on mind that should also be included in the example?

    4.  It seems that the Performance Measurement for a SR P2MP Path (or policy) is limited to one way and out-of-band. Should the document add some texts talking about these limitations?

<RG> Updated section 7.

    5.  The registry for the newly defined Return Path TLV Type and Block Number TLV Type is missing in the document. Is it the "MPLS Loss/Delay Measurement TLV Object" registry?

<RG> Updated IANA section.

    6.  It seems that a new registry should be defined for the Sub-TLV types under the Return Path TLV in the document.

<RG> Added in IANA section.


    7.  In section 5.1. and section 6.1., Should "For both SR Links and end-to-end measurement for SR-MPLS Policies" be changed to something like "For both SR Links and end-to-end SR-MPLS Policies measurements"?

<RG> Corrected.

    8.  In section 6.2., should something like a user case be added into the sentence "The Block Number TLV is Mandatory when used.."?

<RG> Expanded the sentence.

Thanks,
Rakesh



Best Regards,
Huaimo
_______________________________________________
mpls mailing list
mpls@ietf.org<mailto:mpls@ietf.org>
https://www.ietf.org/mailman/listinfo/mpls<https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.ietf.org%2Fmailman%2Flistinfo%2Fmpls&data=02%7C01%7Chuaimo.chen%40futurewei.com%7Cc31debd982dd4f82aba208d80d3eae44%7C0fee8ff2a3b240189c753a1d5591fedc%7C1%7C1%7C637273910199487505&sdata=v46CNS9WsmAblNY5nj%2F7yd%2BdWh6sROXzJbDPtXcrTsc%3D&reserved=0>