Re: [mpls] I-D Action: draft-ietf-mpls-static-yang-05.txt
"Tarek Saad (tsaad)" <tsaad@cisco.com> Mon, 05 November 2018 17:04 UTC
Return-Path: <tsaad@cisco.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D5D5A130E10; Mon, 5 Nov 2018 09:04:27 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.971
X-Spam-Level:
X-Spam-Status: No, score=-14.971 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2dPimzzU2Ap2; Mon, 5 Nov 2018 09:04:25 -0800 (PST)
Received: from rcdn-iport-6.cisco.com (rcdn-iport-6.cisco.com [173.37.86.77]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6744B127133; Mon, 5 Nov 2018 09:04:25 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=6774; q=dns/txt; s=iport; t=1541437465; x=1542647065; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=XGZvK7fS1aUgANviGyvefw0xyyTN7bST7gZUz6XYim4=; b=jEMRjP8ZrGS3zYoFoIW/WucU8hvnoTlSH5a7DsZNfukBMm4duHCkW7X+ EHgZ7C3AXHeTNrsNqvEAmIlZzS9Fn5R5s7Ja5kyXEMm0xZitE4cGHRcGc en8pBJZqaeNat/ZAD1hwJFllYaLS62I2zi+DjdssrnSkmdIjgwpIBBTeH k=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0AFAAA2d+Bb/5FdJa1lGQEBAQEBAQEBAQEBAQcBAQEBAQGBUgMBAQEBAQsBgVUvZn8oCoNslC+CDZctFIFmCwEBGAuESQIXgzoiNQwNAQMBAQIBAQJtHAyFOgEBAQECAQEBIRE6CwwEAgEIEQMBAQEDAiYCAgIlCxUICAIEAQ0FCYMYAYF5CA+pKoEuhC0BAwIMQIUcgQuKaxeBQT+BEScfgkyDEAsBAQEBAQEWgQyDPzGCJgKeY08JAoZsiiMYgVVMhDSKC4hFhEOCOIdfAhEUgSYeATaBVXAVGiEqAYJBCYsShT5vAY0CgR8BAQ
X-IronPort-AV: E=Sophos;i="5.54,468,1534809600"; d="scan'208";a="476942162"
Received: from rcdn-core-9.cisco.com ([173.37.93.145]) by rcdn-iport-6.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Nov 2018 17:04:24 +0000
Received: from XCH-RTP-004.cisco.com (xch-rtp-004.cisco.com [64.101.220.144]) by rcdn-core-9.cisco.com (8.15.2/8.15.2) with ESMTPS id wA5H4NOJ008696 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Mon, 5 Nov 2018 17:04:23 GMT
Received: from xch-rtp-001.cisco.com (64.101.220.141) by XCH-RTP-004.cisco.com (64.101.220.144) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 5 Nov 2018 12:04:19 -0500
Received: from xch-rtp-001.cisco.com ([64.101.220.141]) by XCH-RTP-001.cisco.com ([64.101.220.141]) with mapi id 15.00.1395.000; Mon, 5 Nov 2018 12:04:19 -0500
From: "Tarek Saad (tsaad)" <tsaad@cisco.com>
To: "t.petch" <ietfc@btconnect.com>, "mpls@ietf.org" <mpls@ietf.org>
CC: "draft-ietf-mpls-static-yang@ietf.org" <draft-ietf-mpls-static-yang@ietf.org>, "draft-ietf-mpls-base-yang@ietf.org" <draft-ietf-mpls-base-yang@ietf.org>
Thread-Topic: [mpls] I-D Action: draft-ietf-mpls-static-yang-05.txt
Thread-Index: AQHTpoRhXXP4i6uffkOa6gDoIaedaaOm3FIEgZzy+4A=
Date: Mon, 05 Nov 2018 17:04:19 +0000
Message-ID: <A7C87BD7-A6E5-474F-9D19-F3B9A6F83DA4@cisco.com>
References: <151871655164.7468.17697751302068907872@ietfa.amsl.com> <03b001d3a714$5e08dce0$4001a8c0@gateway.2wire.net>
In-Reply-To: <03b001d3a714$5e08dce0$4001a8c0@gateway.2wire.net>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/10.10.2.180910
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.86.254.238]
Content-Type: text/plain; charset="utf-8"
Content-ID: <0C38D0F5A0E62F4C9947B14E67BDD01D@emea.cisco.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-Outbound-SMTP-Client: 64.101.220.144, xch-rtp-004.cisco.com
X-Outbound-Node: rcdn-core-9.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/eg7kyvhJVvfkeuJieZdA4qXMJyc>
Subject: Re: [mpls] I-D Action: draft-ietf-mpls-static-yang-05.txt
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Nov 2018 17:04:32 -0000
Hi Tom, Thank you much for your review comments. We have addressed your comments in latest revision of the drafts (draft-ietf-mpls-static-yang-07 and draft-ietf-mpls-base-yang-09). Please let us know if you have any further comments or whether you're satisfied with the resolution. Regards, Tarek -----Original Message----- From: mpls <mpls-bounces@ietf.org> on behalf of "t.petch" <ietfc@btconnect.com> Date: Friday, February 16, 2018 at 5:55 PM To: "mpls@ietf.org" <mpls@ietf.org> Subject: Re: [mpls] I-D Action: draft-ietf-mpls-static-yang-05.txt As a YANG module, I think that this needs some - well, quite a lot of - work - Terminology section needs to reference RFC8174 - ietf-netmod-revised-datastores is the correct reference for most of the terms in the Terminology section - ietf-rib needs a reference (ietf-routing is the usual base routing module) - it references YANG 1.0 and not 1.1 - if this is justified, it needs an explanation - it is not NMDA compliant - this needs changing or justifying - " and augments the MPLS Base YANG model defined in module "ietf-mpls" in [I-D.saad-mpls-static-yang]. ietf-mpls does not appear an the referenced I-D - the I-D has five authors, the YANG module has ten - the module lacks a copyright clause - the imports need references, best provided with a reference clause for each, and again in the text of the I-D and in the I-D References section see draft-ietf-ccamp-alarm-module for an example of this - good practice is to list the prefix used and the RFC in which they can be found somewhere in the text of the I-D draft-ietf-netmod-rfc8022bis has an example of this - the YANG module needs a reference back to the RFC in which it appears along with a note to the RC editor to replace XXXX with the relevant number - you have a reference to RFC3031 which is sadly mistaken - If a reference to RFC3031 is warranted, then it needs to appear in the text of the I-D and in the References section - static-extended - same comments - Security Considerations needs updating - it needs to call out the vulnerable objects Tom Petch ----- Original Message ----- From: <internet-drafts@ietf.org> To: <i-d-announce@ietf.org> Cc: <mpls@ietf.org> Sent: Thursday, February 15, 2018 5:42 PM Subject: I-D Action: draft-ietf-mpls-static-yang-05.txt > > A New Internet-Draft is available from the on-line Internet-Drafts directories. > This draft is a work item of the Multiprotocol Label Switching WG of the IETF. > > Title : A YANG Data Model for MPLS Static LSPs > Authors : Tarek Saad > Kamran Raza > Rakesh Gandhi > Xufeng Liu > Vishnu Pavan Beeram > Filename : draft-ietf-mpls-static-yang-05.txt > Pages : 20 > Date : 2018-02-15 > > Abstract: > This document contains the specification for the MPLS Static Label > Switched Paths (LSPs) YANG model. The model allows for the > provisioning of static LSP(s) on LER(s) and LSR(s) devices along a > LSP path without the dependency on any signaling protocol. The MPLS > Static LSP model augments the MPLS base YANG model with specific data > to configure and manage MPLS Static LSP(s). > > > The IETF datatracker status page for this draft is: > https://datatracker.ietf.org/doc/draft-ietf-mpls-static-yang/ > > There are also htmlized versions available at: > https://tools.ietf.org/html/draft-ietf-mpls-static-yang-05 > https://datatracker.ietf.org/doc/html/draft-ietf-mpls-static-yang-05 > > A diff from the previous version is available at: > https://www.ietf.org/rfcdiff?url2=draft-ietf-mpls-static-yang-05 > > > Please note that it may take a couple of minutes from the time of submission > until the htmlized version and diff are available at tools.ietf.org. > > Internet-Drafts are also available by anonymous FTP at: > ftp://ftp.ietf.org/internet-drafts/ > > _______________________________________________ > I-D-Announce mailing list > I-D-Announce@ietf.org > https://www.ietf.org/mailman/listinfo/i-d-announce > Internet-Draft directories: http://www.ietf.org/shadow.html > or ftp://ftp.ietf.org/ietf/1shadow-sites.txt _______________________________________________ mpls mailing list mpls@ietf.org https://www.ietf.org/mailman/listinfo/mpls
- [mpls] I-D Action: draft-ietf-mpls-static-yang-05… internet-drafts
- Re: [mpls] I-D Action: draft-ietf-mpls-static-yan… t.petch
- Re: [mpls] I-D Action: draft-ietf-mpls-static-yan… Tarek Saad (tsaad)
- Re: [mpls] I-D Action: draft-ietf-mpls-static-yan… Tarek Saad (tsaad)
- Re: [mpls] I-D Action: draft-ietf-mpls-static-yan… tom petch
- Re: [mpls] I-D Action: draft-ietf-mpls-static-yan… tom petch
- [mpls] Structure of draft-ietf-mpls-static-yang tom petch
- Re: [mpls] Structure of draft-ietf-mpls-static-ya… Tarek Saad (tsaad)
- Re: [mpls] Structure of draft-ietf-mpls-static-ya… tom petch
- Re: [mpls] Structure of draft-ietf-mpls-static-ya… Tarek Saad (tsaad)
- Re: [mpls] Structure of draft-ietf-mpls-static-ya… tom petch
- Re: [mpls] Structure of draft-ietf-mpls-static-ya… tom petch