Re: [mpls] [spring] RTG-DIR Last Call review of draft-ietf-spring-segment-routing-mpls-18

Przemyslaw Krol <pkrol@google.com> Sat, 30 March 2019 04:13 UTC

Return-Path: <pkrol@google.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F1ABE1203DA for <mpls@ietfa.amsl.com>; Fri, 29 Mar 2019 21:13:48 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -17.49
X-Spam-Level:
X-Spam-Status: No, score=-17.49 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_KAM_HTML_FONT_INVALID=0.01, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=google.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sXhalW2px7_N for <mpls@ietfa.amsl.com>; Fri, 29 Mar 2019 21:13:45 -0700 (PDT)
Received: from mail-it1-x133.google.com (mail-it1-x133.google.com [IPv6:2607:f8b0:4864:20::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 00B471203D0 for <mpls@ietf.org>; Fri, 29 Mar 2019 21:13:44 -0700 (PDT)
Received: by mail-it1-x133.google.com with SMTP id m137so7059090ita.0 for <mpls@ietf.org>; Fri, 29 Mar 2019 21:13:44 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pwJ7RfF8feu4vFo74s9ZOiw95wCHvWkpgnpz8+zjfAE=; b=oFClJgpR6KSCBxr+VDO/V1JONXxseaaPrEOCMWFxS0qpKXy/vN93H043ZQ4S/YPF2M TgWuRvUZGY+VRy40c876/Ahv5mbSHrTqINR0d/ivvxXYUKmAR034s3IY5T/Fc4iy895F 28RyfScQGp+cdgiIA4bpS17sy0S1zoioIuLvejR/tvgyZRfR+QDSoAcuPbgJktl28H4s NAgXHutCQR1PbSlaAGgGlJckQAvzHBUoDNPDO3q3YX7NeDCHnxSqoBAuTdICnSo8YUPb 0rJBS/hqtnMmh9Hrg9jsXjbPPmNQt+WdAw5Ym6D7tfzEs1C7CHs8yTHGz2lb1vjinfdb VxdA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pwJ7RfF8feu4vFo74s9ZOiw95wCHvWkpgnpz8+zjfAE=; b=N+yFxCmM/RSwJO8gYBCLp2zr+3z2KkuBL45uI4BSeipgMKofXC5wqtZV5+jp2yM7bG ROXa47aYYYxMWxqYeUkruTa5eLezdhybkG9Fiemawty/3q593lyHT7pdZ8RIgnIV4iet lcl/LKmDSS58fhk6DDM/6jF27e6UzoDk4peMyfxmrHC+83/EK0AQSdjfThW6ybAXCJ1D whMGVicIXj977nJuj7PdQ/u8kwJfN8CJVx8bO/dnyvpQsPUA6DhUBaM0Gz/kqaDwr7AZ DSLe+0NZiEc2oNyDE9u7yAWbwN68Wr/oWOukTZCUIO7yJ8+/cxvwAPoqmPM5J4Y+Ta+1 21Yw==
X-Gm-Message-State: APjAAAUiqpruHMZUDkkh1K/L2XfZeFsoaL2r9eYj/BVEsBP5IPgnY772 DaoVTArQP2foLN599HMZOryClja1FzqcBO+Q3ATl/Q==
X-Google-Smtp-Source: APXvYqxA05Uq3I5alUaQsIME5HJ8vf3zKHGCJsTK5l8JDcOpgvK38+ux8jxKANvwLrq2XYB+pyWvWP9HKxXQHFFuJ5Q=
X-Received: by 2002:a24:7c52:: with SMTP id a79mr84450itd.51.1553919223787; Fri, 29 Mar 2019 21:13:43 -0700 (PDT)
MIME-Version: 1.0
References: <VI1PR03MB3839B5FA07EADE57084F8E389D4F0@VI1PR03MB3839.eurprd03.prod.outlook.com> <65361777-db63-9a7a-9199-dd04425b4785@gmail.com>
In-Reply-To: <65361777-db63-9a7a-9199-dd04425b4785@gmail.com>
From: Przemyslaw Krol <pkrol@google.com>
Date: Sat, 30 Mar 2019 05:13:05 +0100
Message-ID: <CACH2EkU01XsLPT1ow15q+y6GLzgfeKiFkNPWg7jWX+FF0OPZnw@mail.gmail.com>
To: Ahmed Bashandy <abashandy.ietf@gmail.com>
Cc: Alexander Vainshtein <Alexander.Vainshtein@ecitele.com>, "rtg-ads@ietf.org" <rtg-ads@ietf.org>, "rtg-dir@ietf.org" <rtg-dir@ietf.org>, "spring@ietf.org" <spring@ietf.org>, "draft-ietf-spring-segment-routing-mpls.authors@ietf.org" <draft-ietf-spring-segment-routing-mpls.authors@ietf.org>, Min Ye <amy.yemin@huawei.com>, "mpls@ietf.org" <mpls@ietf.org>
Content-Type: multipart/alternative; boundary="000000000000585d6d05854803bb"
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/emF57Z_zgX8h6dPatX3FEMHQynk>
Subject: Re: [mpls] [spring] RTG-DIR Last Call review of draft-ietf-spring-segment-routing-mpls-18
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 30 Mar 2019 04:13:49 -0000

Hi Ahmed,

Cosmetic minor nit:
2.5. Incoming Label Collision
[...]
both links in the '(Mirrored SID)' section need a cleanup / update

thanks,
pk


On Fri, Mar 29, 2019 at 2:14 AM Ahmed Bashandy <abashandy.ietf@gmail.com>;
wrote:

> Thanks a lot for the review
>
> I uploaded version 19 of the draft, which, IMO, addresses all your comments
>
> See the reply "#Ahmed"
> On 3/10/19 9:55 AM, Alexander Vainshtein wrote:
>
> Hello,
>
> I have been selected as the Routing Directorate reviewer for this draft.
> The Routing Directorate seeks to review all routing or routing-related
> drafts as they pass through IETF last call and IESG review, and sometimes
> on special request. The purpose of the review is to provide assistance to
> the Routing ADs. For more information about the Routing Directorate, please
> see ​http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir
>
> Although these comments are primarily for the use of the Routing ADs, it
> would be helpful if you could consider them along with any other IETF Last
> Call comments that you receive, and strive to resolve them through
> discussion or by updating the draft.
>
> Document: review of draft-ietf-spring-segment-routing-mpls-18
> Reviewer: Alexander (“Sasha”) Vainshtein
> Review Date: 10-Mar-19
> IETF LC End Date: 07-Mar-2019
> Intended Status: Proposed Standard
>
> *Summary:* I have some minor concerns about this document that I think
> should be resolved before publication.
>
> *Comments*:
>
> I have done an early RTG-DIR review of the -14 version of the draft half a
> year ago, and the issues I’ve raised then have been resolved in the
> subsequent versions one way or another). Therefore this review has been
> intentionally focused on the changes done to the draft in the few recent
> versions.
>
> In my previous review I have noticed that the draft was not easy reading
> for me. Since then readability of the draft has been improved. However,
> there are still several places in the new text that are still difficult to
> parse.
>
> I did not run the nits checker on the draft, so my list of nits is
> probably incomplete.
>
> Just as with my earlier review, I send this one also to the MPLS WG list –
> and for the same reasons.
>
> I tried to discuss my review privately with the authors, but they did not
> respond.
>
> *Major Issues*: No major issues found.
>
> *Minor Issues*:
>
> 1.    The text in Section 1 states that “*a network operator SHOULD configure at least one node segment per routing instance, topology, algorithm*” and continues that “*An implementation MAY check that an IGP node-SID is not associated with a prefix that is owned by more than one router within the same routing domain, If so, it SHOULD NOT use this Node-SID, MAY use another one if available, and SHOULD log an error*”. This looks somewhat controversial to me because:
>
> a.    The check of the Node SID not being owned by more than one router in the routing domain is defined as purely optional. According to RFC 2119, implementations that choose to implement such a check must be able to interoperate with implementations that do not implement it
>
> b.    The recommended handling of the results of this check (fully aligned with the text in Section 3.2 pf RFC 8402 that prohibits using prefixes owned by more than one router in the domain as Node-SODs) strongly suggests that the prefix that is owned by more than one router in the domain is unusable as the Node SID
>
> I see two possibilities to resolve this controversy: either make the check in question a “real requirement” (i.e., replace *MAY* with *SHOULD* or even *MUST*), or explain why it is safe enough not to implement such a check (i.e., how implementations that support this check and implementations that do not support it can interoperate within a given routing domain). The first of these options seems to me aligned with Section 3.2 in RFC 8402 that says that “*An IGP Node-SID MUST NOT be associated with a prefix that is owned by more than one router within the same routing domain*”.
>
> #Ahmed: I replaced the MAY with SHOULD
>
> 2.       I have  a problem with the highlighted part of the following
> text in Section 2.5:
>
>    *An implementation MUST NOT allow the MCCs belonging to the same*
>
> *   router to assign the same incoming label to more than one SR FEC. An*
>
> *   implementation that allows such behavior is considered as faulty.*
>
> *   Procedures defined in this document equally applies to this case,*
>
> *   both for incoming label collision (Section 2.5
> <https://tools.ietf.org/html/draft-ietf-spring-segment-routing-mpls-18#section-2.5>)
> and the effect on*
>
> *   outgoing label programming (Section 2.6
> <https://tools.ietf.org/html/draft-ietf-spring-segment-routing-mpls-18#section-2.6>).*
>
> a.    The Section in question deals with incoming label collision (in fact, the text that immediately follows the problematic fragment states that “*The objective of the following steps is to deterministically install in the MPLS Incoming Label Map, also known as label FIB, a single FEC with the incoming label "L1"*”
>
> b.    As a consequence, any mention of  *outgoing label programming*, looks out of context (even accompanied by a forward reference to Section 2.6)
>
> c.    Section 2.6 covers the impact of incoming label collision on programming of outgoing labels in quite a generic way. Therefore I think that the  highlighted part of the quoted fragment can be safely removed (complete with the grammar mistake).
>
> d.    I also do not see any value in stating that an implementations that violates a mandatory requirement of the spec is faulty – isn’t that self-evident?
>
> #Ahmed: I removed the highlighted text because I agree with what you said
> in item (d) that it has no value
>
>
> 3.    The highlighted text in Section 2.8 is not accurate:
>
> *   For Local SIDs, the MCC is responsible for downloading the correct*
>
> *   label value to FIB. For example, an IGP with SR extensions [I-D.ietf-*
>
> *   isis-segment-routing-extensions, I-D.ietf-ospf-segment-routing-*
>
> *   extensions] allocates and downloads the MPLS label corresponding to*
>
> *   an Adj-SID [RFC8402 <https://tools.ietf.org/html/rfc8402>].*
>
> *a.  *IGP with SR extensions may indeed dynamically allocate and download MPLS labels acting as local Adj-SIDs
>
> *b.  *However, these labels can be allocated by configuration (e.g. as mentioned in the tie-breaking rules in Section 2.5.1 and in the example in Section A.2.3 in the draft), in which case IGP with SR extensions would only responsible for its advertisement and installation.
>
> #Ahmed: I removed the highlighted word "allocated"
>
>
>
> *NITS*:
>
>  :
>
> 1.    In section 2.5:
>
> a.    In the sentence “*Procedures defined in this document equally applies to this case*” the noun is in plural but the verb is in singular. (If this sentence is removed as suggested above, this nit disappears)
>
> b.    The same problem exists in the sentence “*An incoming label collision occurs if the SIDs of the set of FECs {FEC1, FEC2,..., FECk} maps to the same incoming SR MPLS label "L1"*”
>
> #Ahmed: The sentence is removed as you suggested
>
> 2.       In section 2.10.1 the preposition “*to*” between the words “
> *according*” and “*MPLS*” is missing in the fragment “*Push the
> calculated label according the MPLS label pushing rules specified in
> [RFC3032]*”.
>
> #Ahmed added the missing "to"
>
> 3.       Problems with references:
>
> a.       As reported by Sergey
> <https://mailarchive.ietf.org/arch/msg/spring/C_W3KBcL2AWxmlB7Sp53_PvqbQA>;,
> there are two occurrences of references to RFC 8042 “OSPF Two-Part Metric”
> instead of RFC 8402. Lots of thanks to Sergey for catching this
>
> #Ahmed: Corrected, thanks again
>
> b.       Reference to RFC 8174 mistakenly contains a link to  RFC 7274.
>
> #Ahmed: Corrected
>
> Hopefully these notes will be useful.
>
> #Ahmed: VERY useful
>
> Regards,
>
> Sasha
>
>
>
> Office: +972-39266302
>
> Cell:      +972-549266302
>
> Email:   Alexander.Vainshtein@ecitele.com
>
>
>
> ___________________________________________________________________________
>
> This e-mail message is intended for the recipient only and contains
> information which is
> CONFIDENTIAL and which may be proprietary to ECI Telecom. If you have
> received this
> transmission in error, please inform us by e-mail, phone or fax, and then
> delete the original
> and all copies thereof.
> ___________________________________________________________________________
>
> _______________________________________________
> spring mailing list
> spring@ietf.org
> https://www.ietf.org/mailman/listinfo/spring
>


-- 
Przemyslaw "PK" Krol |  Strategic Network Engineer ing | pkrol@google.com