Re: [mpls] Opsdir last call review of draft-ietf-mpls-sr-over-ip-02

"Adrian Farrel" <adrian@olddog.co.uk> Sun, 17 February 2019 11:19 UTC

Return-Path: <adrian@olddog.co.uk>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C92AA127AC2; Sun, 17 Feb 2019 03:19:19 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.601
X-Spam-Level:
X-Spam-Status: No, score=-2.601 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JMQeJbzdsQe0; Sun, 17 Feb 2019 03:19:17 -0800 (PST)
Received: from mta5.iomartmail.com (mta5.iomartmail.com [62.128.193.155]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id F19CE128B01; Sun, 17 Feb 2019 03:19:13 -0800 (PST)
Received: from vs1.iomartmail.com (vs1.iomartmail.com [10.12.10.121]) by mta5.iomartmail.com (8.14.4/8.14.4) with ESMTP id x1HBJ7uP021004; Sun, 17 Feb 2019 11:19:07 GMT
Received: from vs1.iomartmail.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5D4882203B; Sun, 17 Feb 2019 11:19:07 +0000 (GMT)
Received: from asmtp2.iomartmail.com (unknown [10.12.10.249]) by vs1.iomartmail.com (Postfix) with ESMTPS id 46B822203A; Sun, 17 Feb 2019 11:19:07 +0000 (GMT)
Received: from LAPTOPK7AS653V ([59.37.21.226]) (authenticated bits=0) by asmtp2.iomartmail.com (8.14.4/8.14.4) with ESMTP id x1HBJ1Pd025578 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sun, 17 Feb 2019 11:19:05 GMT
Reply-To: <adrian@olddog.co.uk>
From: "Adrian Farrel" <adrian@olddog.co.uk>
To: "'Al Morton'" <acmorton@att.com>, <ops-dir@ietf.org>
Cc: <mpls@ietf.org>, <ietf@ietf.org>, <draft-ietf-mpls-sr-over-ip.all@ietf.org>
References: <155035125470.28448.13188042604940095760@ietfa.amsl.com>
In-Reply-To: <155035125470.28448.13188042604940095760@ietfa.amsl.com>
Date: Sun, 17 Feb 2019 11:18:59 -0000
Organization: Old Dog Consulting
Message-ID: <00ef01d4c6b2$98102420$c8306c60$@olddog.co.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQGBGQl8mGC2K5R3NLNQWApPimb6ZKaLMFcA
Content-Language: en-gb
X-Originating-IP: 59.37.21.226
X-Thinkmail-Auth: adrian@olddog.co.uk
X-TM-AS-GCONF: 00
X-TM-AS-Product-Ver: IMSVA-9.0.0.1623-8.2.0.1013-24434.007
X-TM-AS-Result: No--11.092-10.0-31-10
X-imss-scan-details: No--11.092-10.0-31-10
X-TMASE-Version: IMSVA-9.0.0.1623-8.2.1013-24434.007
X-TMASE-Result: 10--11.092100-10.000000
X-TMASE-MatchedRID: fE0JoqABJp3xIbpQ8BhdbOYAh37ZsBDCC/ExpXrHizzlJZht6cF9xFM1 EzrOOwvWQkIpLU6y2ndal/o0mVdrU054kNlzd6J3cFEiuPxHjsUICu6i14k6HPgnJH5vm2+gFhM gncTYqyS0JGeVHQ04WopMlj66NgD77Hz728uiamCcnm0v4tsY4ziAbW+oEE345VavBrAV4wUNqg 8odlnkKKaBafyu8kavPvqiJzbDmiyrSqv5DWrMSh47EGkpGeA9OkDbNlgmO/UN+H+9vY7EAGVYY C40jpLGTupBKcY88KK4VxGFQBNJeNUMAwTDOBnsbuFuYBIpyuk38FNTll9lEuedK36PXYKWmi3F G4ndT6WEjbv1/pAnVVb+d1W2AA/qhPc4FTJN6V5I9rD1ir7Z9L8+q17GFLKRmyiLZetSf8my5/t FZu9S3AV1uwb6J5fHC24oEZ6SpSkj80Za3RRg8B5g4ELUg4CGm+Yg55upS4XCkIkNXnqRGLbSWE lXgokXEze1V/T0TyU=
X-TMASE-SNAP-Result: 1.821001.0001-0-1-12:0,22:0,33:0,34:0-0
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/ij32NAOSK9y8S0mcREvv22Uv9D4>
Subject: Re: [mpls] Opsdir last call review of draft-ietf-mpls-sr-over-ip-02
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 17 Feb 2019 11:19:20 -0000

Hi Al,

Thanks very much for reviewing.

Responses in line.

> Thanks for preparing this draft.
> Providing transition methods is very welcome to
> Operations.

We aim to please 😊

> There seem to be a few more opportunities to employ
> Requirements Language in this draft (currently only
> 3 MUSTs and 2 MAYs), to improve the consistency of 
> implementations and subsequent adoption in operations.

You are right.
The original vision for this document was Informational (telling you how to use existing tools), so the Requirements language only crept in as we moved to Standards Track, and we should probably have more of it.

> For example:
> Section 2:
>   o  Incremental deployment of the SR-MPLS technology may be
>      facilitated by tunneling SR-MPLS packets across parts of a network
>      that are not SR-MPLS enabled using an IP tunneling mechanism such
>      as MPLS-in-UDP [RFC7510].  The tunnel destination address is the
>	                                                           ^^^^
>      address of the next SR-MPLS capable node along the path (i.e., the
>      egress of the active node segment).  This is shown in Figure 1.
>
> Setting the Dst address correctly seems to be a requirement,
> because this material in Section 2 is referenced later, in 3.2.3.
> This seems a reasonable spot for s/is/SHOULD be/ at least.

Well, in this specific case I'm going to agree with you, but for a different reason. You don't set a destination address, you pick a tunnel that has an end point.

So we should probably write...
OLD
      The tunnel destination address is the
      address of the next SR-MPLS capable node along the path (i.e., the
      egress of the active node segment).
NEW
      The tunnel selected MUST have its remote end point (destination)
      Address equal to the address of the next SR-MPLS capable node 
      along the path (i.e., the egress of the active node segment).
END

> Section 3.1 FIB construction relies on about 5 drafts: 
> much work in progress, just noting dependencies (no action)

Yes, it is sad for me that the SR work still lingers in the pipe.

> SRGB - ?? spell-out at first use

Good catch.
Segment Routing Global Block

> Section 3.2.3. Additional Forwarding Procedures
>.... 
>      IP Header Fields:  When encapsulating an MPLS packet in UDP, the
>      resulting packet is further encapsulated in IP for transmission.
>      IPv4 or IPv6 may be used according to the capabilities of the
>      network.  The address fields are set as described in Section 2.
>	                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>      The other IP header fields (such as DSCP code point, or IPv6 Flow
>      Label) on each UDP-encapsulated segment can be set according to
>	                                          ^^^^^^^^^^
>      the operator's policy:
>Suggest:
> s/can be set/SHOULD be configurable/

Yes