Re: [mpls] MPLS-RT review of draft-esale-mpls-ldp-rmr-extensions-02

Santosh Easale <sesale@juniper.net> Sun, 04 November 2018 20:35 UTC

Return-Path: <sesale@juniper.net>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5AE15126F72; Sun, 4 Nov 2018 12:35:42 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.172
X-Spam-Level:
X-Spam-Status: No, score=-1.172 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, KHOP_DYNAMIC=1.999, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=juniper.net
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Vw7CB1mN982N; Sun, 4 Nov 2018 12:35:41 -0800 (PST)
Received: from mx0b-00273201.pphosted.com (mx0b-00273201.pphosted.com [67.231.152.164]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C1187123FFD; Sun, 4 Nov 2018 12:35:40 -0800 (PST)
Received: from pps.filterd (m0108163.ppops.net [127.0.0.1]) by mx0b-00273201.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id wA4KYSVX002399; Sun, 4 Nov 2018 12:35:38 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=PPS1017; bh=JOE1plV0lqbQhUVncKnHtL8CG5UgCP169cbi8TT5hto=; b=lJiLDoNXdYm0yLh45+SjYKG/DJPv6Xp0iaDHsCHpj4vaEO2wBTjuWm6vOjJqP1hQz4Og EC8zywFAh12fuEz6WOC/33oXLgJuHiFCq8X6/bOyt5dBWhxnGdb+kSqnTdN2Mmr1l83Y grI3X5XtFONeUwut82SakR6yBTrMHhpytB6ZqMOb8UGS7XLWk48fMXBIy/iyY3/0carV xYM4vuqXjpHpRau2oE5WZ+7Q7ANbYgGLlKuxNR/Ad4bzL0+sJ9neeZq64vVg1Zma5Q3Y l6fFCuHT6h7rGT4gamPAP4FX5YYdDuyIP+ttz2ngjh+rp8054YXMIP0gQM0ETer3OYqL qg==
Received: from nam05-co1-obe.outbound.protection.outlook.com (mail-co1nam05lp0087.outbound.protection.outlook.com [216.32.181.87]) by mx0b-00273201.pphosted.com with ESMTP id 2nh6wqskk4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 04 Nov 2018 12:35:38 -0800
Received: from BY1PR0501MB1528.namprd05.prod.outlook.com (10.160.203.139) by BY1PR0501MB1349.namprd05.prod.outlook.com (10.160.200.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1294.17; Sun, 4 Nov 2018 20:35:34 +0000
Received: from BY1PR0501MB1528.namprd05.prod.outlook.com ([fe80::6476:94fb:f857:8143]) by BY1PR0501MB1528.namprd05.prod.outlook.com ([fe80::6476:94fb:f857:8143%9]) with mapi id 15.20.1294.032; Sun, 4 Nov 2018 20:35:34 +0000
From: Santosh Easale <sesale@juniper.net>
To: "huubatwork@gmail.com" <huubatwork@gmail.com>, "mpls@ietf.org" <mpls@ietf.org>
CC: "draft-esale-mpls-ldp-rmr-extensions@ietf.org" <draft-esale-mpls-ldp-rmr-extensions@ietf.org>, mpls-chairs <mpls-chairs@ietf.org>
Thread-Topic: [mpls] MPLS-RT review of draft-esale-mpls-ldp-rmr-extensions-02
Thread-Index: AQHUAn6qzmVDAGFf5kSz8Lms2DqRaqRly5CAgNqlNIA=
Date: Sun, 04 Nov 2018 20:35:34 +0000
Message-ID: <4C6BCE42-CF82-4C77-A870-BF41437F8B8D@juniper.net>
References: <CAA=duU0dKCTHbZCw6XuVJSo72ExUuXVxRgzWwhvw1f3HbrGHuA@mail.gmail.com> <0b3a5be7-0ed0-c55c-f6ec-6b146ced9965@gmail.com>
In-Reply-To: <0b3a5be7-0ed0-c55c-f6ec-6b146ced9965@gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/10.12.0.181014
x-originating-ip: [66.129.239.14]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; BY1PR0501MB1349; 6:hRkZ9pCJky9/SR/G1P1EbXO6v1O5t/fgcGam3jl+orYcfWYkT6dDS+Tk59R2kvLV1I71ap5wtnLFyMa2GoDLTljiv0M8SH2E2qZJJDjrvz96UdyffD5C98vie8JDO8lCqYTLV5Lt8LNNZTWpN0MqCzL50aKeigkcxJ76Xbi7ez8JCMRo2kpDpk3wNFAMnxUGClx8MvKhvb7Iej//GyEVmO+fusoeYrF7pp2sR5YWe/AI/bB7pNkUZUWRFuYOn5w2E4vhkjBKJdtGFzhiCLHeXtS6DLwrIQ4HGf2q8bUTnUv3+HtoIdghn/oar5g5seF8dEYVLw8bJnARHF4lrSttgCX10EualZ1/FfL+zbXNUF1P0n81x/WMTr5eSQL3RL2p9I6YPbJN0elL/eWOqd/QjxmAlYw/RhboQGpa45yVfj2HoXnr3vgRsYuoEjZDlLvA07LTIp0eBY6Q9Up61J9JrQ==; 5:HVnHCLB+AnERmFNLFguKtK93M8AK8rW52+ePWff2/LUlcDM20PVzDkBklStH4ipJ+VVBLNZ6eCnOFoSCrjLX0Rt+t0o0dQZFGUaMWyhHyXRQ3ynx61ybM/DOeJzGioJqg3L4oKRgX9abnF93O783UfwvdYjvmokA0nFQM7cYN6c=; 7:nTVFu38RF3ve2zAuVmqezHegPJMdkAZhxYX4/QBIs+LitQ+9YcfCQsvDAlVsqpqn98Ci6X1UYBb7E27Vc/3rlvi6p5E246yFZJZNXiqrTPLZbU9cFXMY8DnqGsBQM/cFw1SyzzCGbUp4ecez0ZBc1Q==
x-ms-exchange-antispam-srfa-diagnostics: SOS;
x-ms-office365-filtering-correlation-id: 216a0da4-f00e-4050-bfa5-08d642951257
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(5600074)(711020)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:BY1PR0501MB1349;
x-ms-traffictypediagnostic: BY1PR0501MB1349:
x-microsoft-antispam-prvs: <BY1PR0501MB13490DBAF4B5C9B2FD352047D9C90@BY1PR0501MB1349.namprd05.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(85827821059158);
x-ms-exchange-senderadcheck: 1
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(3231382)(944501410)(52105095)(6055026)(148016)(149066)(150057)(6041310)(20161123562045)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(201708071742011)(7699051)(76991095); SRVR:BY1PR0501MB1349; BCL:0; PCL:0; RULEID:; SRVR:BY1PR0501MB1349;
x-forefront-prvs: 084674B2CF
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(396003)(366004)(39860400002)(376002)(346002)(136003)(199004)(189003)(66066001)(68736007)(256004)(2900100001)(186003)(316002)(110136005)(54906003)(58126008)(53936002)(81166006)(76176011)(81156014)(8936002)(6436002)(26005)(6246003)(8676002)(102836004)(6506007)(36756003)(86362001)(39060400002)(6346003)(345774005)(6512007)(82746002)(7736002)(305945005)(106356001)(105586002)(71200400001)(2906002)(71190400001)(5660300001)(4326008)(478600001)(99286004)(14454004)(476003)(2616005)(97736004)(11346002)(446003)(486006)(6486002)(2501003)(25786009)(83716004)(6116002)(3846002)(229853002)(33656002)(42262002); DIR:OUT; SFP:1102; SCL:1; SRVR:BY1PR0501MB1349; H:BY1PR0501MB1528.namprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1;
received-spf: None (protection.outlook.com: juniper.net does not designate permitted sender hosts)
x-microsoft-antispam-message-info: 9L5bMH1cBTFqBetITiBoJ+576j0jIN8b+cd0bkreP4aGcTr1lhiK8PZuNYHf+0JcOwLyPCIa+QYBZ38uehj/34R/3xNWQXtR3sR0XzX1bKpUt77CeIFXeFqr+qvacQIsOMp0HYLk9Hy0MrRaNSosYZVITvRpBroSX5rs0XWVJksS1bd3DLPwRbOAiw2AnvyBVkjDOvC91RXnb+yAdXvKbcGFoxFVHMD3UMS1D5+JBD7xGiaHYWrFm4xD/zY5mFmgeYEs6BYWGExs/GPSz3w+/7OtroYF4O2AYiNnPY3dsIXIhc+qrXPdpgsZq1Nu+gS8vBdAhO7NqlkMShCR1LOiKM7dRMkF8mhgkNmiQkG551E=
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="utf-8"
Content-ID: <A499C0734FDD7D408D68992204979D04@namprd05.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: juniper.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 216a0da4-f00e-4050-bfa5-08d642951257
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Nov 2018 20:35:34.2763 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: bea78b3c-4cdb-4130-854a-1d193232e5f4
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0501MB1349
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2018-11-04_15:, , signatures=0
X-Proofpoint-Spam-Details: rule=outbound_spam_notspam policy=outbound_spam score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1811040197
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/jk3vwCYcw_otWrJAA_okOrGKto0>
Subject: Re: [mpls] MPLS-RT review of draft-esale-mpls-ldp-rmr-extensions-02
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 04 Nov 2018 20:35:43 -0000

Hi Huub, 
               Thank you for reviewing. We have addressed your comments in 01 version that will be posted shortly.
                      
Regards,
Santosh
On 6/18/18, 2:39 AM, "Huub van Helvoort" <huubatwork@gmail.com> wrote:

    All,
    
    I am one of the selected MPLS-RT reviewers 
    for draft-esale-mpls-ldp-rmr-extensions.
    This draft is currently a candidate for MPLS WG adoption.
    
    The draft describes extensions required to LDP for signalling resilient 
    MPLS ring LSPs
    to be used in the RMR architecture described in draft-ietf-mpls-rmr.
    
    The described extensions to LDP, and their operation, are written 
    clearly enough for
    WG input and review. I think wider WG review will enhance the description.
    
    My opinion is that the current draft is ready for WG adoption.
    
    I have a few nits that can be addressed before or after adoption.
    
    In section 4.2.2, the section begins:
    
        A node X wishing to participate in LDP RMR signaling SHOULD negotiate
        the RMR capability with all its neighbors.
    
    IMHO the SHOULD should be a MUST.
    
    The same remark for the last paragraph in section 4.2.3.
    
        When the node is no longer part of the ring, it SHOULD tear down its
        egress LSPs - CW and AC - by sending a label withdraw message.
    
    The links in figures 1 and 3 should be drawn more clearly.
    In figure 3. there are two nodes R9.
    
    Cheers, Huub.
    
    -- 
    ================================================================
    Always remember that you are unique...just like everyone else...