Re: [mpls] Stephen Farrell's No Objection on draft-ietf-mpls-lsp-ping-relay-reply-10: (with COMMENT)

Stephen Farrell <stephen.farrell@cs.tcd.ie> Wed, 30 September 2015 21:19 UTC

Return-Path: <stephen.farrell@cs.tcd.ie>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 39AF81A90AE; Wed, 30 Sep 2015 14:19:55 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.311
X-Spam-Level:
X-Spam-Status: No, score=-4.311 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AgSxPjq0_Vz0; Wed, 30 Sep 2015 14:19:52 -0700 (PDT)
Received: from mercury.scss.tcd.ie (mercury.scss.tcd.ie [134.226.56.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 98F901A90B0; Wed, 30 Sep 2015 14:19:52 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by mercury.scss.tcd.ie (Postfix) with ESMTP id 622B5BE32; Wed, 30 Sep 2015 22:19:51 +0100 (IST)
X-Virus-Scanned: Debian amavisd-new at scss.tcd.ie
Received: from mercury.scss.tcd.ie ([127.0.0.1]) by localhost (mercury.scss.tcd.ie [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4bDLWNmF9iar; Wed, 30 Sep 2015 22:19:49 +0100 (IST)
Received: from [10.87.48.73] (unknown [86.46.22.228]) by mercury.scss.tcd.ie (Postfix) with ESMTPSA id 55A46BDF9; Wed, 30 Sep 2015 22:19:43 +0100 (IST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cs.tcd.ie; s=mail; t=1443647989; bh=6GxNETwmzb2M0gQa/59mDFsYRXAmmLsBVnkyq9BJp84=; h=Subject:To:References:Cc:From:Date:In-Reply-To:From; b=svdI9mldsLquMsRrKq6Af9AmFac7iAA2OjNA6dxsfZWroSiE0q/+nO8n/wZKPZcUi L9t1pFatdSEl9QsFQQEU0aBsocX8LXqX1ECYNvE8DGy93Tci1+T2LeXNorzIa9MMYE MB18wFKQ8STMD6Jkh70+8112CX2NoCAwLX1mzRfY=
To: "George Swallow (swallow)" <swallow@cisco.com>, Lizhong Jin <lizho.jin@gmail.com>
References: <20150930124330.1948.32154.idtracker@ietfa.amsl.com> <CAH==cJwSx51qXJ7f29tWDHa9xfuGXd_dze=UizLW3jFEf-0xYQ@mail.gmail.com> <D2319C15.1226DC%swallow@cisco.com>
From: Stephen Farrell <stephen.farrell@cs.tcd.ie>
Openpgp: id=D66EA7906F0B897FB2E97D582F3C8736805F8DA2; url=
Message-ID: <560C51E9.60804@cs.tcd.ie>
Date: Wed, 30 Sep 2015 22:19:37 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <D2319C15.1226DC%swallow@cisco.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Archived-At: <http://mailarchive.ietf.org/arch/msg/mpls/kFAo7oh7KtMIr4JcMVyBrPQAkOQ>
Cc: "mpls@ietf.org" <mpls@ietf.org>, draft-ietf-mpls-lsp-ping-relay-reply <draft-ietf-mpls-lsp-ping-relay-reply@ietf.org>, The IESG <iesg@ietf.org>, mpls-chairs <mpls-chairs@ietf.org>
Subject: Re: [mpls] Stephen Farrell's No Objection on draft-ietf-mpls-lsp-ping-relay-reply-10: (with COMMENT)
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 30 Sep 2015 21:19:55 -0000


On 30/09/15 19:50, George Swallow (swallow) wrote:
> Lizhong, Stephen,
> 
> Perhaps less in more!
> 
> 
>   Destination Address Offset: the offset in octets from the top-of-stack
>   to the destination address entry.

That might be better yes. Maybe with a forward pointer to the 4.x
sections that clarify it.

S

> 
> 
> Lizhong –
> 
> There are several places in the draft where the term "destination address” should be "destination address entry”
> 
> It would also be good to add a column to the table on page 6 indicating the size of each entry
> 
> Null              4
> 
> IPv4      8
> 
> IPv6    20
> 
> George
> 
> From: Lizhong Jin <lizho.jin@gmail.com<mailto:lizho.jin@gmail.com>>
> Date: Wednesday, September 30, 2015 at 11:57 AM
> To: Stephen Farrell <stephen.farrell@cs.tcd.ie<mailto:stephen.farrell@cs.tcd.ie>>
> Cc: The IESG <iesg@ietf.org<mailto:iesg@ietf.org>>, mpls-chairs <mpls-chairs@ietf.org<mailto:mpls-chairs@ietf.org>>, draft-ietf-mpls-lsp-ping-relay-reply <draft-ietf-mpls-lsp-ping-relay-reply@ietf.org<mailto:draft-ietf-mpls-lsp-ping-relay-reply@ietf.org>>, "mpls@ietf.org<mailto:mpls@ietf.org>" <mpls@ietf.org<mailto:mpls@ietf.org>>
> Subject: Re: Stephen Farrell's No Objection on draft-ietf-mpls-lsp-ping-relay-reply-10: (with COMMENT)
> 
> Hi Stephen,
> See inline below. Thanks.
> 
> Lizhong
> 
> On Wed, Sep 30, 2015 at 8:43 PM, Stephen Farrell <stephen.farrell@cs.tcd.ie<mailto:stephen.farrell@cs.tcd.ie>> wrote:
> Stephen Farrell has entered the following ballot position for
> draft-ietf-mpls-lsp-ping-relay-reply-10: No Objection
> 
> When responding, please keep the subject line intact and reply to all
> email addresses included in the To and CC lines. (Feel free to cut this
> introductory paragraph, however.)
> 
> 
> Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
> for more information about IESG DISCUSS and COMMENT positions.
> 
> 
> The document, along with other ballot positions, can be found here:
> https://datatracker.ietf.org/doc/draft-ietf-mpls-lsp-ping-relay-reply/
> 
> 
> 
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
> 
> 
> - 3.2: The description of the destination address offset isn't
> clear to me. If this is some common thing in MPLS though, that's
> fine. If not, maybe it'd be worth being clearer here.
> (It does become clear later though, so this is a nit.)
> 
> [Lizhong] I read several times, and try to make it more clear as below:
> 
> Destination Address Offset: an offset (octets) to indicate the
>       position of the Relayed Address Entry which is also the
> 
>       destination address of the Reply or Relayed Reply message.
> 
>       E.g., to point the first entry on the top of the Stack of
> 
>       Relayed Addresses will have offset of 0, and to point to
> 
>       the second entry will have offset of the length of the first entry.
> 
>