IETF Logo Mail Archive

Re: [mpls] [Last-Call] Genart last call review of draft-ietf-mpls-lsp-ping-ospfv3-codepoint-04

Lars Eggert <lars@eggert.org> Mon, 29 November 2021 13:15 UTC

Return-Path: <lars@eggert.org>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B72293A09B2; Mon, 29 Nov 2021 05:15:33 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.099
X-Spam-Level:
X-Spam-Status: No, score=-2.099 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=eggert.org
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wZl837NiqtdV; Mon, 29 Nov 2021 05:15:29 -0800 (PST)
Received: from mail.eggert.org (mail.eggert.org [91.190.195.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B37693A0963; Mon, 29 Nov 2021 05:15:25 -0800 (PST)
Received: from smtpclient.apple (unknown [IPv6:2a00:ac00:4000:400:c1a3:8155:80b9:705b]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.eggert.org (Postfix) with ESMTPSA id 5D9116022E9; Mon, 29 Nov 2021 15:15:13 +0200 (EET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eggert.org; s=dkim; t=1638191713; bh=uw3c+r9zcnAgLTIm0wquZdYuDjZAkuIdzpU3KqA4w8w=; h=Subject:From:In-Reply-To:Date:Cc:References:To; b=yj13cihhDPDCoR4d7kCm0r1dEXCR2KlG6XrxBuClMKeUfZ0tSmhWc/+dP59aUVhMS Zvay8E7n9yOpUFx2hkqNphCf0WC5Gx5SYXWlocLd9+pvKL3ESU/B9Zg8AYxBLJejON aSNEpnycYIj8OmQlec7Gpdd4BlcbF+mQBuEsr7xs=
Content-Type: multipart/signed; boundary="Apple-Mail=_57BD75FF-AEEA-42BD-93EC-EAEA8D67AEA4"; protocol="application/pgp-signature"; micalg="pgp-sha512"
Mime-Version: 1.0 (Mac OS X Mail 15.0 \(3693.20.0.1.32\))
From: Lars Eggert <lars@eggert.org>
In-Reply-To: <162339832253.24163.8210945265296547396@ietfa.amsl.com>
Date: Mon, 29 Nov 2021 15:15:11 +0200
Cc: General Area Review Team <gen-art@ietf.org>, draft-ietf-mpls-lsp-ping-ospfv3-codepoint.all@ietf.org, mpls@ietf.org, last-call@ietf.org
Message-Id: <50BA5147-18BE-46DD-90FC-65B3D9A6B7AC@eggert.org>
References: <162339832253.24163.8210945265296547396@ietfa.amsl.com>
To: Christer Holmberg <christer.holmberg@ericsson.com>
X-MailScanner-ID: 5D9116022E9.A0A4B
X-MailScanner: Found to be clean
X-MailScanner-From: lars@eggert.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/kSKJByXg0GXI3WrxVcJWZAODLLU>
Subject: Re: [mpls] [Last-Call] Genart last call review of draft-ietf-mpls-lsp-ping-ospfv3-codepoint-04
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 29 Nov 2021 13:15:41 -0000

Christer, thank you for your review. I have entered a No Objection ballot for this document.

Lars


> On 2021-6-11, at 10:58, Christer Holmberg via Datatracker <noreply@ietf.org> wrote:
> 
> Reviewer: Christer Holmberg
> Review result: Almost Ready
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-ietf-mpls-lsp-ping-ospfv3-codepoint-04
> Reviewer: Christer Holmberg
> Review Date: 2021-06-11
> IETF LC End Date: 2021-06-21
> IESG Telechat date: Not scheduled for a telechat
> 
> Summary: The document is easy to read, and is almost ready for publication.
> However, I do have a few editorial comments that I would like the authors to
> address.
> 
> Major issues: N/A
> 
> Minor issues: N/A
> 
> Nits/editorial comments:
> 
> Q1:
> 
> The Abstract and Introductions says:
> 
>   "This document proposes the code point to be used in the Segment ID
>     Sub-TLV and Downstream Detailed Mapping TLV when the IGP is OSPFv3."
> 
> I suggest to say "specifies" or "defines" instead of "proposes".
> 
> Q2:
> 
> Would it be more clear to call Section 6 "Update to RFC 8287"?
> 
> Q3:
> 
> Section 6 says:
> 
>   "This document specifies that the above code points will be used only for
>   OSPFv2."
> 
> I suggest to be more explicit, and say something like:
> 
>   "This document updates RFC 8287, by specifying that the "OSPF" code points
>   will be used only for OSPFv2."
> 
> Q4:
> 
> Section 7.2 adds a note to the IANA registry for the existing "OSPF" code
> point. Should this specification also be added as a reference for the existing
> "OSPF" code point (in addition to RFC 8287?
> 
> 
> 
> --
> last-call mailing list
> last-call@ietf.org
> https://www.ietf.org/mailman/listinfo/last-call

v2.14.0 | Report a Bug | By Email