[mpls] MPLS-RT review of draft-bryant-mpls-sfl-control

"Andrew G. Malis" <agmalis@gmail.com> Mon, 30 December 2019 19:31 UTC

Return-Path: <agmalis@gmail.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost []) by ietfa.amsl.com (Postfix) with ESMTP id 98969120099; Mon, 30 Dec 2019 11:31:31 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.998
X-Spam-Status: No, score=-1.998 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([]) by localhost (ietfa.amsl.com []) (amavisd-new, port 10024) with ESMTP id cpaJy6O1EfMD; Mon, 30 Dec 2019 11:31:29 -0800 (PST)
Received: from mail-qk1-x735.google.com (mail-qk1-x735.google.com [IPv6:2607:f8b0:4864:20::735]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C80F7120B4E; Mon, 30 Dec 2019 11:31:29 -0800 (PST)
Received: by mail-qk1-x735.google.com with SMTP id r14so26924615qke.13; Mon, 30 Dec 2019 11:31:29 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=qwUdX1Op00mvSgGFJeO7l6uP2LJVMXHeAg7ipcf3tWM=; b=oFTsORFu5D2JeC0rV/7Pp6DeuzKPKWQRotFr3O8uzZzIoP3AwQPbBbwaRY8t00Gj9n uDTau9AvcvuS0jUkiVBZpi9+tZEmTwfuKjjjym8XIrKHuKZpvtCHMyY0ubKA5ZSmsNBr PbFHLMePo2P01i4z9/tJKK6gfNXn7maweMbbJKMgleOgrNnNIrLXOzLzjYu8LEKC6qmQ IgpvW3QdHxrxxR46lHcH6fbFii9xhw20+lauIuRRv+AVEZZXOuS7+RRyH3nTHpaASZ0W wrWKXUCUzM3ATet0cVhmRGEJoRw38V+djzUyKxyjOoBu0dofaWZIW/IxtEdjmmrXGG4h c/jQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=qwUdX1Op00mvSgGFJeO7l6uP2LJVMXHeAg7ipcf3tWM=; b=B14rmqMDNBrv8cVJbLLOhu0gyF5uKUobSCDTR5oOw6tta01QZmy0vyRbO3saBmT/dJ 1E1pFkUmwxh2ITSkUKubiVQF15Hv0Ik7uvXTKTr6mcHwG9dRqo7yZE4dPB9FgG1nfs9h hiM/WC0d1917lvaYJZTHpxOTror837F56GSNhYSrWgknEqkFwGbAB9rMhAMiiAucEZ3b zpLiGyeBLXtb9gtSTlPnxHqPKjWH1a9wwG4TkxdDPxlv2XBjBIoVxyHygkdNyRWN0jxA ESntPxAMMDw5kCangkTEAQV9SFbdjoRg3KpWvy1VpcehOzzmbZE8vpAz/PY3B+4gUeym CiJg==
X-Gm-Message-State: APjAAAWnNI1VtJNzu7Mi3l+HbjdRZyj3rK74/XCDJjgTkC7Hys1ki3Pz AsfIXmeyJu+13PMlC09MycucRt5HtUYhSgLorITUxgOgymM=
X-Google-Smtp-Source: APXvYqzimgI5CmUmcnF2Hzumjwg88ytwKVM5sOYw4Ya5cZWrROEgNV+7X+Nf4vHXrSpKhc3GMZuSe/mSe/2/s1BbeLo=
X-Received: by 2002:a37:a4cf:: with SMTP id n198mr55250943qke.483.1577734288757; Mon, 30 Dec 2019 11:31:28 -0800 (PST)
MIME-Version: 1.0
From: "Andrew G. Malis" <agmalis@gmail.com>
Date: Mon, 30 Dec 2019 14:31:18 -0500
Message-ID: <CAA=duU3_AaiH4J7o0vai=KCL_LY93e2xc0JQO3t6WsUSWM3dJg@mail.gmail.com>
To: draft-bryant-mpls-sfl-control@ietf.org, mpls <mpls@ietf.org>, mpls-chairs <mpls-chairs@ietf.org>
Content-Type: multipart/alternative; boundary="000000000000d4d569059af0e35a"
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/lMbTeUl7LN0AXdQLA2gx6MSs8wI>
Subject: [mpls] MPLS-RT review of draft-bryant-mpls-sfl-control
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 30 Dec 2019 19:31:32 -0000


I’ve been selected as an MPLS-RT reviewer for draft-bryant-mpls-sfl-control,
which is currently a candidate for MPLS WG adoption.

In general I believe that the draft is ready for WG adoption. However, I
have a few minor comments which may be addressed either before or after WG

1. The Security Considerations section says "It is assumed that this
protocol is run in a well managed MPLS network with strict access controls
preventing unwanted parties from generating MPLS OAM packets." While this
is true of most (all?) MPLS networks, this assumption should also be stated
in the abstract or Introduction as well.

2. Section 8 contains the line "Force references to appear with mkd
[RFC3032] [RFC5036]". However, both references appear elsewhere as well, so
this line can be removed.

3. I would move "I-D.ietf-mpls-sfl-framework" to the Normative References,
as understanding it is necessary to understand this draft.

4. The text in Section 2 is out of date. The current wording is:

The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL NOT",
"OPTIONAL" in this document are to be interpreted as described in BCP 14
[RFC2119] [RFC8174] when, and only when, they appear in all capitals, as
shown here.

RFC 8174 should also be added as a normative reference.

5. When this draft was last updated, Stewart included the following in an
email message to the MPLS WG:

"Next to do is authors of draft-bryant-mpls-sfl-control to check that
this is suitable to be called by another protocol to act on its behalf.
When we are satisfied that that is that case and any consequentially
necessary amendments have been make to the other drafts we will
request adoption of draft-bryant-mpls-sfl-control and then WGLC on all

There's been no follow-up indication that this analysis has occurred, or
further revision to the draft. If it has, the authors should indicate as
such on the list. If it hasn't, then this will serve as a reminder to the