[mpls] MPLS-RT review of draft-mirsky-mpls-p2mp-bfd-04

"Andrew G. Malis" <agmalis@gmail.com> Wed, 24 October 2018 16:17 UTC

Return-Path: <agmalis@gmail.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 76577130DC9; Wed, 24 Oct 2018 09:17:28 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.999
X-Spam-Level:
X-Spam-Status: No, score=-1.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ySXoX97urbL6; Wed, 24 Oct 2018 09:17:26 -0700 (PDT)
Received: from mail-qt1-x833.google.com (mail-qt1-x833.google.com [IPv6:2607:f8b0:4864:20::833]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5F778130934; Wed, 24 Oct 2018 09:17:23 -0700 (PDT)
Received: by mail-qt1-x833.google.com with SMTP id q41-v6so6195406qtq.10; Wed, 24 Oct 2018 09:17:23 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=i0yAfrQabh6mal0mRAFodwmNZKziwZTt83e2n6RQev8=; b=pbQI6pa2SJZZRAMVsVznkEKWnPATiJvoHu5NuK/Tf4YaG96tBi2akPpHL34oEb9LWn CF9efxP8vZlneDN3z/T/iQ17pmBZYxPXwPqFQzo78a1ORa6IS5mFDOpDNknkpCCOtUy1 vcqqgt5nptADORHJ4KDGSnVZxpgqCuI+1mxJBbwzpx18uNyA7i7KmCFYfkECXCi+Smbr W5naB6mrwCsmWZEx72zvCmJY/K74mSeiBeqwrN44w9dkNpndWHxyRv1yIBQDli8TJnFo 143ObdqUp0Kk4hMtvhmLdUTJrSTrQ84QgwPIt6A90XrK+XFr1t2fdwDUr2hqwS+onHwV l8uQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=i0yAfrQabh6mal0mRAFodwmNZKziwZTt83e2n6RQev8=; b=m1fd537EMMJbDws2y9FvFaG4V6RC/7I9LI1h9sIlVO6ufEw2BSx3rhxXn6wBhQYy0p g8/W556Cn9lasAS8E7A7cwdBf2UvBSTBsTvsHWwnwFfbx6FwQrfY8g8nWK+6duI8JkgL ZUJMyd/XKAK+c9qs8LDQtp6PObafDMAfyLnlUDK+2QDibET0M4pTX2T5IgaibBhozHtr Ts2k1fCZx/i6LepqDSnP35Kl8VbTmXvpNfmzVY3uzv0Bj4ahpdCdA3FVRoLjUf5uvoAr Bs56kcbwFwPwSeqj+UHamouJzhOARIQ+qbrKRgcST9kqufcIYhR/JAwIYp1ZCWugINWU PnJQ==
X-Gm-Message-State: AGRZ1gJ7Lr1GHq0A6UmNZxyQyy2tQLlAhJMu5uQClUSgaxF62oVA8RST i+VtoRYH9A2kxtycjwKuBjoLBg85d04oH0ugJcPO1hzT
X-Google-Smtp-Source: AJdET5feNU+W0c5zLO5kt1Cye76XOB7Fd7Y5XEiNhl+4SOmnheTL6USi0PTOL0S2TkJ3QNtphP7fFGuEiyIHtYMWKz0=
X-Received: by 2002:a0c:a086:: with SMTP id c6mr3117635qva.21.1540397842098; Wed, 24 Oct 2018 09:17:22 -0700 (PDT)
MIME-Version: 1.0
From: "Andrew G. Malis" <agmalis@gmail.com>
Date: Wed, 24 Oct 2018 12:17:11 -0400
Message-ID: <CAA=duU2kQWCg5CfidXAw8M+1VivgY=C2cehCcEVUQ0D_1yYxSg@mail.gmail.com>
To: mpls-chairs <mpls-chairs@ietf.org>, draft-mirsky-mpls-p2mp-bfd@ietf.org
Cc: mpls@ietf.org
Content-Type: multipart/alternative; boundary="00000000000030efae0578fbd220"
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/mOKLvk4xWoObl2KJJGIUtaohT0s>
Subject: [mpls] MPLS-RT review of draft-mirsky-mpls-p2mp-bfd-04
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Oct 2018 16:17:28 -0000

I’ve been selected as an MPLS-RT reviewer for
draft-mirsky-mpls-p2mp-bfd-04, which is currently a candidate for MPLS WG
adoption. This draft documents procedures for using BFD for multipoint
networks to detect data plane failures in MPLS p2mp LSPs.

The BFD WG has been working on draft-ietf-bfd-multipoint, which describes
BFD procedures for multipoint and multicast networks.
draft-mirsky-mpls-p2mp-bfd uses that draft as a basis to detect MPLS data
plane failures for p2mp LSPs. This is a straightforward and useful
application of the BFD draft for MPLS data plane failure detection.

However, I would have expected to see at least a reference to RFC 4687,
"Operations and Management (OAM) Requirements for Point-to-Multipoint MPLS
Networks", and some text on how this draft addresses the requirements in
that draft.

I also expected more text on the relationship between this draft and RFC
6425, "Detecting Data-Plane Failures in Point-to-Multipoint MPLS -
Extensions to LSP Ping"', and more of an explanation of why the keyword MAY
is used in sections 4.1 and 4.2 - what are the implications of following or
not following the MAY in each case?

The draft also needs an editing pass, for example "MaultipointHead"
for "MultipointHead"
and some incorrect English grammar in several places.

Once these items have been addressed, I think that the draft should be
ready for an adoption call.

Cheers,
Andy