Re: [mpls] Genart last call review of draft-ietf-mpls-sr-over-ip-02

"Adrian Farrel" <adrian@olddog.co.uk> Tue, 26 February 2019 15:11 UTC

Return-Path: <adrian@olddog.co.uk>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 363BD12D7EA; Tue, 26 Feb 2019 07:11:16 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.6
X-Spam-Level:
X-Spam-Status: No, score=-2.6 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KB2SDuhLR_Rc; Tue, 26 Feb 2019 07:11:14 -0800 (PST)
Received: from mta6.iomartmail.com (mta6.iomartmail.com [62.128.193.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B9187128CB7; Tue, 26 Feb 2019 07:11:12 -0800 (PST)
Received: from vs3.iomartmail.com (vs3.iomartmail.com [10.12.10.124]) by mta6.iomartmail.com (8.14.4/8.14.4) with ESMTP id x1QFB9wj019585; Tue, 26 Feb 2019 15:11:09 GMT
Received: from vs3.iomartmail.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0F6602203A; Tue, 26 Feb 2019 15:11:09 +0000 (GMT)
Received: from asmtp3.iomartmail.com (unknown [10.12.10.224]) by vs3.iomartmail.com (Postfix) with ESMTPS id ED8B62203D; Tue, 26 Feb 2019 15:11:08 +0000 (GMT)
Received: from LAPTOPK7AS653V ([87.112.237.8]) (authenticated bits=0) by asmtp3.iomartmail.com (8.14.4/8.14.4) with ESMTP id x1QFB7K5021209 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 26 Feb 2019 15:11:08 GMT
Reply-To: <adrian@olddog.co.uk>
From: "Adrian Farrel" <adrian@olddog.co.uk>
To: "'Robert Sparks'" <rjsparks@nostrum.com>, <gen-art@ietf.org>
Cc: <mpls@ietf.org>, <ietf@ietf.org>, <draft-ietf-mpls-sr-over-ip.all@ietf.org>
References: <155067766687.31388.18349714938448955572@ietfa.amsl.com> <04c001d4c938$7e3d86e0$7ab894a0$@olddog.co.uk>
In-Reply-To: <04c001d4c938$7e3d86e0$7ab894a0$@olddog.co.uk>
Date: Tue, 26 Feb 2019 15:11:07 -0000
Organization: Old Dog Consulting
Message-ID: <03b801d4cde5$805c6250$811526f0$@olddog.co.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQF4uyAuQiUz1zT6JW7t9AabcMIgdgHycLykppqz0xA=
Content-Language: en-gb
X-Originating-IP: 87.112.237.8
X-Thinkmail-Auth: adrian@olddog.co.uk
X-TM-AS-GCONF: 00
X-TM-AS-Product-Ver: IMSVA-9.0.0.1623-8.2.0.1013-24456.007
X-TM-AS-Result: No--1.827-10.0-31-10
X-imss-scan-details: No--1.827-10.0-31-10
X-TMASE-Version: IMSVA-9.0.0.1623-8.2.1013-24456.007
X-TMASE-Result: 10--1.826500-10.000000
X-TMASE-MatchedRID: oTBA/+sdKabxIbpQ8BhdbDPDkSOzeDWWLdLfmiFS7fuCsBeCv8CM/ZrA SHsnChAHd2QT87u7mshnhucj2oZw/Bo6ii/kmFPVkPoFsM336M67atxTbKDEIFfXgfL55invSrb VtmpRMdLnICRLH3OSnjU3TINr6s6sbLfoydCzQDMOrlBkQa9qFsJM5lajW8KVawV8+oOjgHW/3z i6gThtqWT6dMLWZRRFUUErNEX81EB3nyYl4u5Yq43NgkEqAN0RfS0Ip2eEHnwa2S8rkvtFcbDsz p3K5gqDjoczmuoPCq1DHoTAgYx154moSQyCBYrTSe5KpHN17R4k0L68Ij/yq0PRS1Axoykn0nN6 XDQRgqq/s9DvLvr7P0yszgODJXuFIizUmqfqTWsl4nVYwIRGQa1+3JijYrAOMqmhG/M0o4/0MHw zu2JowBZt/2+KOWzz
X-TMASE-SNAP-Result: 1.821001.0001-0-1-12:0,22:0,33:0,34:0-0
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/qJzDv-uRMls03jUlTd2ZztTb3Xc>
Subject: Re: [mpls] Genart last call review of draft-ietf-mpls-sr-over-ip-02
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 26 Feb 2019 15:11:16 -0000

Hey Robert,

Some detailed responses.

The revision will be posted when the authors have signed off.

Regards,
Adrian

> The 2nd sentence of the introduction is complex. It should
> be easy to simplify.

Done

> It would help to place the reference to draft-ietf-mpls-spring-entropy
> label at "If encoding of entropy is desired". (Or if some other reference
> is better, use that)

Used RFC 6790.

> In that same paragraph, something is wrong at "make use of entropy
> label mechanism." Should that be "the entropy label mechanism"?

Yes. I have done some gardening.

> SRGB is used without expansion.

Fixed.

> Where is "the lower bound" of an SRGB defined? The string "lower bound"
> doesn't occur in either of the routing-extensions drafts referenced where
> SRGB is first used.

The concept of an SRGB is defined in RFC 8402. I've added a reference to this at the first use of 'SRGB'.

> Section 3.1 is about ostensibly about constructing a FIB entry, but its
> last step is sending a packet.

Yes. Overly enthusiastic engineers! 😊
I have jiggled the text so that the last couple of points are about how the FIB is used.

> The first sentence in section 3.2 is more complex than it needs to be. It
> should be easy to simplify.

OK

> It would be nice if you could make the differences between the routers in
> figures 3 and 4 visually apparent rather than relying on text to explain the
> difference. Something like (view in a fixed width font):

We looked at this, but decided against. If we adopt some kind of notation, we will still need to explain it in the text, and the explanation will only complicate things.

> At the first paragraph on page 9: s/and then process/and then processes/

Yes