Re: [mpls] MPLS-RT review of draft-malis-mpls-sfc-encapsulation-02

"Andrew G. Malis" <agmalis@gmail.com> Wed, 10 October 2018 19:06 UTC

Return-Path: <agmalis@gmail.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A57F7124C04; Wed, 10 Oct 2018 12:06:51 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.999
X-Spam-Level:
X-Spam-Status: No, score=-1.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CIn2ZuDyxhPs; Wed, 10 Oct 2018 12:06:50 -0700 (PDT)
Received: from mail-qt1-x829.google.com (mail-qt1-x829.google.com [IPv6:2607:f8b0:4864:20::829]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1A91612426A; Wed, 10 Oct 2018 12:06:50 -0700 (PDT)
Received: by mail-qt1-x829.google.com with SMTP id q41-v6so6979191qtq.10; Wed, 10 Oct 2018 12:06:50 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=btudcEDcDvR1o1QFbzYPK7PZCvGK2AEtK9OYQ0befWs=; b=llu+aNdk6fIlcXI3k92MZ9vpIdcBjz9A6mg1BOzotO5QhmXDr56+H6up10RSnm101F kHOGrqT7RM7aS/5t1zFvxVqdmHLj7ceJIRGKFbCbMswmTD6PsDm3kP7G51LKtDm6x0JC qVnOYDe2oHmAILh3PaKNjLVD+zZMRPwWpe9aARnJgnbo3sgdb3i5AquvzigoC6tn/EsJ pvAz7/mXlCfGiC46kTWx25oPs9Dev22XKTRRJq9+hny0ot3rf845yS55RRMclTOzliK5 EkJqTEs/fVH/etUWWLETHYcQ0g1VH/GuuHCAvTl0mTy/Rjn6BJn8UmxNgoX/mhESG95F HeFw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=btudcEDcDvR1o1QFbzYPK7PZCvGK2AEtK9OYQ0befWs=; b=gXV1O8TXo2U+kcz3WvGx6b7gSmHqTYGm8XysEccHCJXxLWN9TjWdqXhWL3HDiunrQj WG54gMX+gyNpWKpNJNMeOSNDKUyr+KayNZlWl2niSbeP3Y4EHp97mpQNBLAvdAo3tGjk KJ1B6+uFa44OPVCIhY2h4QIwvcxSqFx1F8bsEqztlEfLTAprpj7rpbqjUfEERih4MhJk U5eTkHwuiB/fSzbT4ZxxoiLONid3eH8hTRV6LMkNX/t99Opd1XNqLk5NOIF/Wp6LFo+L EKJeQRBS5OgajNIINj4tn4WfV2VRXiZSubiv47ABecHdMszG5Zc2w36ihz4ffrHTWiW3 NGiw==
X-Gm-Message-State: ABuFfois+TT+atrEfdissu0gJzC2oDHmefPkb6bFAKMHI8AkHClLOQ5+ AL7xJpxSrLUZF3OXo0tPC16b2qhgX0DHFDDeuDU=
X-Google-Smtp-Source: ACcGV63Fevty0RHH20cqDKGNjwMcEl3XQNAGuUQJRoo59LpmpY8kKiwybNGHOdhUZoLLnIVGaXd2LaqbOmRhtVRiSvQ=
X-Received: by 2002:ac8:48d9:: with SMTP id l25-v6mr3831278qtr.235.1539198409143; Wed, 10 Oct 2018 12:06:49 -0700 (PDT)
MIME-Version: 1.0
References: <8B6C4F00-8747-4C97-8BFB-DB48BD6FFF9A@nokia.com>
In-Reply-To: <8B6C4F00-8747-4C97-8BFB-DB48BD6FFF9A@nokia.com>
From: "Andrew G. Malis" <agmalis@gmail.com>
Date: Wed, 10 Oct 2018 15:06:37 -0400
Message-ID: <CAA=duU13GP2Le-ovAv4OxU75EWZs2SsUJrDV8TBvJ+mpodYcMw@mail.gmail.com>
To: BOCCI Matthew <matthew.bocci@nokia.com>
Cc: mpls-chairs <mpls-chairs@ietf.org>, draft-malis-mpls-sfc-encapsulation@ietf.org, mpls@ietf.org
Content-Type: multipart/alternative; boundary="0000000000006a78c50577e48ea7"
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/qfaokLIWj_gHY17ej07WPxIY0uQ>
Subject: Re: [mpls] MPLS-RT review of draft-malis-mpls-sfc-encapsulation-02
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Oct 2018 19:06:52 -0000

Matthew,

Thanks for your review. I'll incorporate the changes post WG adoption.

Cheers,
Andy


On Wed, Oct 10, 2018 at 6:59 AM Bocci, Matthew (Nokia - GB) <
matthew.bocci@nokia.com> wrote:

> I’ve been selected as an MPLS-RT reviewer for
> draft-malis-mpls-sfc-encapsulation-02.
>
>
>
> This draft documents a method for encapsulating SFC packets (including an
> NSH) in an MPLS label stack that includes a label (the SFF label) allocated
> to the chain, in conformance with the MPLS architecture.
>
>
>
> I found the draft well written and the scheme makes sense if SFC needs to
> be transported directly over MPLS.
>
>
>
> In my opinion, the draft is ready for WG adoption at this time.
>
>
>
> I have a few nits that can be resolved either before or after adoption.
>
>
>
> In section 2:
>
>
>
> “...by having the receiving advertise...” should read “...by having the
> receiving node advertise...”
>
> “...cases where additional label stack entries...” should read “... cases
> where there are additional label stack entries...”
>
> “...when ACH...” should read “...when an ACH...”
>
>
>
> Regards
>
>
>
> Matthew
>
>
>
>
>