[mpls] Re: Éric Vyncke's No Objection on draft-ietf-mpls-rfc6374-sr-15: (with COMMENT)

[Rakesh Gandhi <[e-mail]>]

Hi Éric,

Thank you for the detailed review of the document.

We have posted a new revision 16 with the suggested changes. Please see
replies inline with <RG>...

URL:      https://www.ietf.org/archive/id/draft-ietf-mpls-rfc6374-sr-16.txt
Status:   https://datatracker.ietf.org/doc/draft-ietf-mpls-rfc6374-sr/
HTML:     https://www.ietf.org/archive/id/draft-ietf-mpls-rfc6374-sr-16.html
HTMLized: https://datatracker.ietf.org/doc/html/draft-ietf-mpls-rfc6374-sr
Diff:
https://author-tools.ietf.org/iddiff?url2=draft-ietf-mpls-rfc6374-sr-16



On Wed, Oct 16, 2024 at 11:13 AM Éric Vyncke via Datatracker <
[e-mail]> wrote:

> Éric Vyncke has entered the following ballot position for
> draft-ietf-mpls-rfc6374-sr-15: No Objection
>
> When responding, please keep the subject line intact and reply to all
> email addresses included in the To and CC lines. (Feel free to cut this
> introductory paragraph, however.)
>
>
> Please refer to
> https://www.ietf.org/about/groups/iesg/statements/handling-ballot-positions/
> for more information about how to handle DISCUSS and COMMENT positions.
>
>
> The document, along with other ballot positions, can be found here:
> https://datatracker.ietf.org/doc/draft-ietf-mpls-rfc6374-sr/
>
>
>
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
>
>
> # Éric Vyncke, INT AD, comments for draft-ietf-mpls-rfc6374-sr-14
>
> Thank you for the work put into this document, it is always important to
> understand the performance of a system.
>
> Please find below some non-blocking COMMENT points (but replies would be
> appreciated even if only for my own education), and some nits.
>
> Special thanks to Tony Li for the shepherd's write-up including the WG
> consensus *and* the justification of the intended status.
>
> Other thanks to Brian Haberman, the Internet directorate reviewer (at my
> request), he found no issue in his int-dir review:
>
> https://datatracker.ietf.org/doc/review-ietf-mpls-rfc6374-sr-13-intdir-telechat-haberman-2024-10-10/
>
> I hope that this review helps to improve the document,
>
> Regards,
>
> -éric
>
> # COMMENTS (non-blocking)
>
> ## IPPM
>
> Was this document also reviewed by the IPPM WG where there is a lot of
> knowledge about measurement?
>

<RG> I can't recall to confirm.
<RG> There are a number of participants who are active in both IPPM and
MPLS WGs (including myself) that this work benefited from.



>
> ## Section 3
>
> Make the reader's task easy by providing a section reference for `Return
> Path
> TLV extension`.
>

<RG> Added.


>
> ## Section 4.2.3
>
> Where is "circular SR-MPLS path" defined ?
>

<RG> Added reference and reworded the sentence.


>
> Suggest adding a figure showing the forward & return paths in the label
> stack.
>

<RG> Added.


>
> ## Sections 5.1 and 6.1
>
> Suggest not using sub-sections but simply having the text in sections 5
> and 6
>

<RG> Updated.


>
> ## Section 6.2
>
> This seems a weird location in the flow. Suggest merging 5 & 6 in a single
> section "Measurements"
>

<RG> Updated.


>
> ## Section 7.1
>
> I was about to DISCUSS this point but shouldn't s/Length MUST NOT be
> 0/Length
> MUST NOT be less than 2/ to take into account the length of the reserved
> field
>

<RG> This was fixed in Revision 15.


>
> Suggest having the last sentence (about reserved field) on its own
> paragraph.
> (Same for section 7.1.1)
>

<RG> Updated.


>
> # NITS (non-blocking / cosmetic)
>
> ## Abstract
>
> The abstract could be shorter, e.g., by not explaining for SR is or not
> listing
> twice a set of RFCs.
>

<RG> Updated.


>
> ## Section 2.3
>
> Consider using aasvg for the graphical elements (nicer on HTML rendering).
>

<RG> I am not too familiar with the SVG syntax. I like to skip this change.


>
> ## Section 3
>
> Consider avoiding text repetition in the delay / loss bullets.
>

<RG> Updated.


>
> ## Section 9 (and possibly others)
>
> s/ISIS/IS-IS/
>
>
RG> Updated.

Thanks again,
Rakesh




>
>
> _______________________________________________
> mpls mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]
>