[mpls] Opsdir last call review of draft-ietf-mpls-inband-pm-encapsulation-14
Daniele Ceccarelli via Datatracker <noreply@ietf.org> Fri, 23 August 2024 12:34 UTC
Return-Path: <noreply@ietf.org>
X-Original-To: mpls@ietf.org
Delivered-To: mpls@ietfa.amsl.com
Received: from [10.244.2.19] (unknown [104.131.183.230]) by ietfa.amsl.com (Postfix) with ESMTP id D03EAC14F604; Fri, 23 Aug 2024 05:34:25 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Daniele Ceccarelli via Datatracker <noreply@ietf.org>
To: ops-dir@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 12.22.1
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <172441646548.123182.4661494998424128985@dt-datatracker-584cd6c8dd-fvr2f>
Date: Fri, 23 Aug 2024 05:34:25 -0700
Message-ID-Hash: KTKXPLUCX5NQC5JW3FDYUMHNPPPKTHVM
X-Message-ID-Hash: KTKXPLUCX5NQC5JW3FDYUMHNPPPKTHVM
X-MailFrom: noreply@ietf.org
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-mpls.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: draft-ietf-mpls-inband-pm-encapsulation.all@ietf.org, last-call@ietf.org, mpls@ietf.org
X-Mailman-Version: 3.3.9rc4
Reply-To: Daniele Ceccarelli <daniele.ietf@gmail.com>
Subject: [mpls] Opsdir last call review of draft-ietf-mpls-inband-pm-encapsulation-14
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/rhHX76p_5ypHOoZtYUXjXTzoQeI>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Owner: <mailto:mpls-owner@ietf.org>
List-Post: <mailto:mpls@ietf.org>
List-Subscribe: <mailto:mpls-join@ietf.org>
List-Unsubscribe: <mailto:mpls-leave@ietf.org>
Reviewer: Daniele Ceccarelli Review result: Has Issues General comments: The intro says: "Considering the MPLS performance measurement with the Alternate-Marking method can also be achieved by MNA encapsulation, it is agreed that this document will be made Historic once the MNA solution of performance measurement with the Alternate-Marking method is published as an RFC." The first reaction to this statement is: how long will it take for the MNA encapsulation to be delivered? If we already know that this will be obsoleted by the MNA encapsulation, is it worth publishing it? Detailed comments below: - Section 3: I was expecting a bit of intro/explanation here. The section starts saying that the encapsulation has this format. Boom. Is it something that already exists? If so where has it been defined? If not could we say something like" this document defines a new encapsulation as shown in figure below..." - Section 3 suggest rephrasing. OLD The Traffic Class (TC) and Time To Live (TTL) [RFC3032] for the XL and FLI MUST use the same field values as the label immediately preceding the XL. unless it is known that the XL will not be exposed as the top label at any point along the LSP. NEW The Traffic Class (TC) and Time To Live (TTL) fields of the XL and FLI MUST use the same values of the label immediately preceding the XL, unless it is known that the XL will not be exposed as the top label at any point along the LSP. Is the "unless..." really necessary? Can't this be always the case? - Section 3: "The BoS bit for the FL depends on whether the FL is placed at the bottom of the MPLS label stack, i.e., the BoS bit for the FL is set only when the FL is placed at the bottom of the MPLS label stack. Isn't this always the case? - Section 3: To achieve the purpose of coloring the MPLS traffic, and to distinguish between hop-by-hop measurement and edge-to-edge measurement, the TC for the FL is defined as follows: The TC is a single field 3 bits long and here it's used as 3 independent flags. I'm not sure if this is possible, but if it is it must at least be explained. - Examples section highly appreciated - Section 4,5 and 6 clear
- [mpls] Opsdir last call review of draft-ietf-mpls… Daniele Ceccarelli via Datatracker
- [mpls] Re: Opsdir last call review of draft-ietf-… xiao.min2
- [mpls] Re: Opsdir last call review of draft-ietf-… Daniele Ceccarelli (dceccare)
- [mpls] Re: Opsdir last call review of draft-ietf-… xiao.min2
- [mpls] Re: Opsdir last call review of draft-ietf-… xiao.min2
- [mpls] Re: Opsdir last call review of draft-ietf-… Daniele Ceccarelli (dceccare)