Re: [mpls] [yang-doctors] Yangdoctors last call review of draft-ietf-mpls-ldp-yang-06

"Kamran Raza (skraza)" <skraza@cisco.com> Mon, 23 December 2019 18:03 UTC

Return-Path: <skraza@cisco.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6C0A3120CA9; Mon, 23 Dec 2019 10:03:21 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.501
X-Spam-Level:
X-Spam-Status: No, score=-14.501 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com header.b=hl66cwGN; dkim=pass (1024-bit key) header.d=cisco.onmicrosoft.com header.b=0XUan+dJ
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id m-sJPST3PvKo; Mon, 23 Dec 2019 10:03:19 -0800 (PST)
Received: from alln-iport-1.cisco.com (alln-iport-1.cisco.com [173.37.142.88]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 635B0120CA0; Mon, 23 Dec 2019 10:03:19 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=3248; q=dns/txt; s=iport; t=1577124199; x=1578333799; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=6cteWym/Mo2hOHGwVVy9qv8OhjdFhnOoaWVPD5irLHA=; b=hl66cwGNne2i+CK6gu59j8Zi/N8Gp3CAjta2MupiaM0KViXrUxOB8dRD 7xiN4Q66j2pCHshF9VDq1ap4phIMr12Z4r9DHipKB+sXttY41XeguMb6R qDjAOtIhp6e9sxhF1FvkcOK1/ojmD1XPmbeEe0bg3XbUuNY3IfUYbeKOU w=;
IronPort-PHdr: =?us-ascii?q?9a23=3AyHjsMB/QEY8m1f9uRHGN82YQeigqvan1NQcJ65?= =?us-ascii?q?0hzqhDabmn44+/bR7E/fs4iljPUM2b8P9Ch+fM+4HYEW0bqdfk0jgZdYBUER?= =?us-ascii?q?oMiMEYhQslVdWGE0TpJdbhbjcxG4JJU1o2t3w=3D?=
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0DYAABxAAFe/4ENJK1lGgEBAQEBAQE?= =?us-ascii?q?BAQMBAQEBEQEBAQICAQEBAYF8gVJQBYFEIAQLKoQIg0YDinqCOpgtglIDVAk?= =?us-ascii?q?BAQEMAQEtAgEBhEACF4IHJDgTAgMNAQEEAQEBAgEFBG2FNwyFXwIBAxIREQw?= =?us-ascii?q?BATcBDwIBCA4MAiYCAgIwFRACBAENBSKDAIJHAy4BAqIEAoE4iGF1gTKCfgE?= =?us-ascii?q?BBYUaGIIMCYEOKIpWgUMaggCBOAwUghc1PoRggnkyggoikAE5hXuJPY8iCoI?= =?us-ascii?q?0kXeEIhuCRod7kBaOUppWAgQCBAUCDgEBBYFpIoFYcBU7KgGCQVAYDY0SDRa?= =?us-ascii?q?DUIpTdIEoj0EBAQ?=
X-IronPort-AV: E=Sophos;i="5.69,348,1571702400"; d="scan'208";a="389095025"
Received: from alln-core-9.cisco.com ([173.36.13.129]) by alln-iport-1.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 23 Dec 2019 18:03:18 +0000
Received: from XCH-RCD-001.cisco.com (xch-rcd-001.cisco.com [173.37.102.11]) by alln-core-9.cisco.com (8.15.2/8.15.2) with ESMTPS id xBNI3IUs001139 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Mon, 23 Dec 2019 18:03:18 GMT
Received: from xhs-rcd-001.cisco.com (173.37.227.246) by XCH-RCD-001.cisco.com (173.37.102.11) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 23 Dec 2019 12:03:17 -0600
Received: from xhs-rcd-001.cisco.com (173.37.227.246) by xhs-rcd-001.cisco.com (173.37.227.246) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 23 Dec 2019 12:03:17 -0600
Received: from NAM12-BN8-obe.outbound.protection.outlook.com (72.163.14.9) by xhs-rcd-001.cisco.com (173.37.227.246) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Mon, 23 Dec 2019 12:03:17 -0600
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XTGlVuyGQ94LUc4G8K8w2qlQJAYZUftekfVdCAGUgZgBJLirKMOj1KRlSOatTk6TZ5QwtYdV/U3xQmkFaJTrpFZIbf/sIPUxqeq5qjHf25wm3F3hNnjwqwXuLVmcFS2st/E4TOMdhZ7Gy3yVgYrupiKgBwYa8judwhl32WgToO4M/rFY82/E/ekrEos6nt0LQvmol/4OLxiIt7EKd2U7sJGGMRI9K0d+A3gTScwIanmlFaJ/Hm4Tzg48AxGsVxD4eGUsZk7CB+303NQ60S/pA09zkIp8cDwb0UETmApiFMC1hJ8QWu99gyIOUwJxwdkS9fo/4Cz4GYtnXUAVo2gIAw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6cteWym/Mo2hOHGwVVy9qv8OhjdFhnOoaWVPD5irLHA=; b=NAdJm6xpyW13H4i8Y70bBC/mvhRJ+sAKIiRnFZEp+YZ+C665I2pClaN9QKgVWT7Nz5p1sia3yHLByEBrnOECxUS0NEzlDPx5Tq/PxOcNyYdDBiVl5lKEUz1i/VaAB2rEnatjRqyOu9piiCTAeEHbkcJocmsCWb8RFeF/jTqb4Fa+llcvnXNkmN6A2HdV5Q558j07OwSY6QB1m7Dw6n56UB4F5duPCf4gemOsLvWs+R7LWhvgBAA+5D1+eKR868oUejpHWP0BIRSuOrwYgTmKw97bAD/GxbPDh5D8W6AovNoGP5Dzcv3rpy6ks4BahFOkvJeylvZ1iBG7xGLs3ORtyw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cisco.com; dmarc=pass action=none header.from=cisco.com; dkim=pass header.d=cisco.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6cteWym/Mo2hOHGwVVy9qv8OhjdFhnOoaWVPD5irLHA=; b=0XUan+dJllfsuZyakuOMfd8jXH7oGor2HchUExu+kH/9oVWe62PBp2T59rSyxSS0yICJ5A3YA3+wVim3mgY5QZXf2BeN61I6l3OclEUHq9tMd6a3qYBVVv+kSpydTbwzCJq1B0MMvVcDlVC/1gFONAxfSUHsjAZRL/4gVjaMTPo=
Received: from DM6PR11MB3865.namprd11.prod.outlook.com (20.176.127.159) by DM6PR11MB2906.namprd11.prod.outlook.com (20.177.218.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2559.17; Mon, 23 Dec 2019 18:03:16 +0000
Received: from DM6PR11MB3865.namprd11.prod.outlook.com ([fe80::8955:6ce6:45c6:77ed]) by DM6PR11MB3865.namprd11.prod.outlook.com ([fe80::8955:6ce6:45c6:77ed%6]) with mapi id 15.20.2559.017; Mon, 23 Dec 2019 18:03:16 +0000
From: "Kamran Raza (skraza)" <skraza@cisco.com>
To: Martin Bjorklund <mbj@tail-f.com>, "janl@tail-f.com" <janl@tail-f.com>
CC: "yang-doctors@ietf.org" <yang-doctors@ietf.org>, "mpls@ietf.org" <mpls@ietf.org>, "draft-ietf-mpls-ldp-yang.all@ietf.org" <draft-ietf-mpls-ldp-yang.all@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>, "draft-ietf-mpls-ldp-yang@ietf.org" <draft-ietf-mpls-ldp-yang@ietf.org>
Thread-Topic: [yang-doctors] Yangdoctors last call review of draft-ietf-mpls-ldp-yang-06
Thread-Index: AQHVg1EltAi0uXkfJ0+36WG0fwUl4KdboKQAgGx7ZQA=
Date: Mon, 23 Dec 2019 18:03:16 +0000
Message-ID: <118693EA-E4F0-435B-8292-155D1C162B18@cisco.com>
References: <157114122559.18000.6531210525259761076@ietfa.amsl.com> <20191015.142532.855473702701065549.mbj@tail-f.com>
In-Reply-To: <20191015.142532.855473702701065549.mbj@tail-f.com>
Accept-Language: en-CA, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/10.1e.0.191013
authentication-results: spf=none (sender IP is ) smtp.mailfrom=skraza@cisco.com;
x-originating-ip: [2001:420:2840:1250:4c27:6c90:817d:cf21]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: ae76451a-d45c-41cf-2d89-08d787d2628b
x-ms-traffictypediagnostic: DM6PR11MB2906:
x-microsoft-antispam-prvs: <DM6PR11MB290614BD665C3755D6B2C22FD02E0@DM6PR11MB2906.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8882;
x-forefront-prvs: 0260457E99
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(396003)(136003)(39860400002)(346002)(376002)(199004)(189003)(5660300002)(8676002)(81166006)(81156014)(316002)(4001150100001)(71200400001)(186003)(6506007)(478600001)(6486002)(6512007)(36756003)(33656002)(4326008)(86362001)(110136005)(2906002)(91956017)(54906003)(8936002)(76116006)(64756008)(66556008)(66476007)(66946007)(2616005)(66446008); DIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR11MB2906; H:DM6PR11MB3865.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1;
received-spf: None (protection.outlook.com: cisco.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: hhEu+dBd74the25mUZ8q8kE78/mvi6ckkmEa5iLDsAQ1o7RNW42tc+Ir4N/UMZtjiQSKdnPnrI88YhuJuqtVWbt5pwNAsSdDrzM7fLymptBAYFf34w9eYiuulmQtx1JonQN3ZnuJJXZxvX9H6tH7l2mjp9raSZjhAAk+2b38sCxIdWQJquyQ5MVECcNn2qDfxyoeTqbB2wz/xSi5z+1P+QDitlsNNZYmkHwguvWhi7OKG99zZDhb9d8wHHPNCfZvjbKoBLCWe3rWgm3LIfgntmYg2x8dAFNhwh0A1XPXQ54SOWNGTkZTxwLbzdHf3gPza2ehw5bkKun/tRTFYS/Js7Cxljndzb5cd6Dg40TlCD72oICOkZauMWxhxRit0DuFb8hpjF+3+24ymZVGeIMmU3r10XqIfM60WiikNCBOaVXpGnzydbo1jtM29Do1r0yf
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-ID: <4515AD6D11286F428A78771E996496DA@namprd11.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: ae76451a-d45c-41cf-2d89-08d787d2628b
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Dec 2019 18:03:16.1305 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: zXz4KzMMzQjSTN86RKlAORT7V+VmBOjIjlTTDA7Fri50RFDn/w0NQCOVi/OBYaO/nBjPWsTkg6JFr4++Zl0h6Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2906
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.37.102.11, xch-rcd-001.cisco.com
X-Outbound-Node: alln-core-9.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/vrMUCudmM2U662jo8zU7HxZmEQo>
Subject: Re: [mpls] [yang-doctors] Yangdoctors last call review of draft-ietf-mpls-ldp-yang-06
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Dec 2019 18:03:22 -0000

Hi Martin,

Please see inline [skraza]:


On 2019-10-15, 8:26 AM, "Martin Bjorklund" <mbj@tail-f.com> wrote:

    Hi,
    
    Some comments inline.
    
    Jan Lindblad via Datatracker <noreply@ietf.org> wrote:
    
    > #4) Weakly defined types for neighbor-list-ref, prefix-list-ref, peer-list-ref
    > 
    > These types are not leafrefs, but strings without any YANG substatements to
    > define the format. The only thing the description does is to claim that the
    > entities they refer to are outside the scope of this document. For an
    > operator/programmer encountering this type, that isn't very helpful, and is not
    > going to be interoperable.
    > 
    >   typedef neighbor-list-ref {
    >     type string;
    >     description
    >       "A type for a reference to a neighbor address list.
    >        The string value is the name identifier for uniquely
    >        identifying the referenced address list, which contains a list
    >        of addresses that a routing policy can applied. The definition
    >        of such an address list is outside the scope of this
    >        document.";
    >   }
    > 
    > I'm not sure if this is fixable by sharpening the YANG module, but maybe more
    > could be done to guide a confused reader. What would the user do to find out
    > the format of this type and valid values? Add to the description.
    
    If the target of such a reference is outside the scope of this
    document, it is reasonable to also leave this leaf as outside the
    scope of this document.  When a new module defines such a list, it can
    easily augment this module with a proper leafref.   I.e., I suggest
    that you can remove this leaf and perhaps explain in text how a future
    module can add the reference.
    
    > #6) MD5 key
    > 
    > There is a leaf md5-key of type string. Is this leaf sensitive from a security
    > point of view? A plaintext string would not be ideal if that is the case.
    > Choose a crypto type instead.
    
    Or perhaps mark the node with nacm:default-deny-all.

[skraza]: This should be decided on RTG area level so that all protocols follow the same approach. 
   We will defer this to RTG AD for guidance. Please also refer our response to Jan's review.
    
    
    
    
    /martin