Re: [mpls] MPLS wglc draft-ietf-mpls-base-yang

"Acee Lindem (acee)" <acee@cisco.com> Wed, 19 February 2020 12:47 UTC

Return-Path: <acee@cisco.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1FF7812003F; Wed, 19 Feb 2020 04:47:22 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.501
X-Spam-Level:
X-Spam-Status: No, score=-14.501 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com header.b=DzPpLFTi; dkim=pass (1024-bit key) header.d=cisco.onmicrosoft.com header.b=ELE7RTBJ
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2K1_15bhUnGa; Wed, 19 Feb 2020 04:47:17 -0800 (PST)
Received: from alln-iport-3.cisco.com (alln-iport-3.cisco.com [173.37.142.90]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 32436120019; Wed, 19 Feb 2020 04:47:17 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=5034; q=dns/txt; s=iport; t=1582116437; x=1583326037; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=n1kk9q5yi0xRhOvGjU7GaAtxhT8gmHp981fAy1j/mpY=; b=DzPpLFTiPricpeOZ6GVDu08IT/fvNn8IwBYMwv/Q2VjLS/i9uy1eDPq/ 3t/Rui0pDzinfsJTzIEFdUMehiP6brYkrNEdNtzSqeoO2F5jtBEfRxoWh Zokr4UVQSZI31iKHgcR8xz3PvDeW5cSAaAQUQZdnKHzVitkdC8DN8sISu s=;
X-IPAS-Result: =?us-ascii?q?A0CfBQD5LU1e/49dJa1dCRwBAQEBAQcBAREBBAQBAYF7g?= =?us-ascii?q?VRQBWxYIAQLKoQUg0YDinGGIZRPgUKBEANUCQEBAQwBARgLCgIEAQGEQAIXg?= =?us-ascii?q?W0kOBMCAwEBAQMCAwEBAQEFAQEBAgEFBG2FNwyFZwIBAwEBEBERDAEBLAsBD?= =?us-ascii?q?wIBCBoCJgICAiULFRACBAENBSKDBAGCSgMuAQIMokMCgTmIYnWBMoJ/AQEFg?= =?us-ascii?q?TMChA8YggwJgQ4qjCQaggCBEScggkw+gmQBAQIBgSURLIMQMoIskGOGFJguc?= =?us-ascii?q?AqCO4dPjxEcgkmIG4t7hEyOb4h5hiCIMIN8AgQCBAUCDgEBBYFpIoFYcBU7K?= =?us-ascii?q?gGCQQlHGA2OHQkag1CCaYIrhT90AgGBJo1qAQE?=
IronPort-PHdr: =?us-ascii?q?9a23=3AMsM2nhXTsjO4iu0Sa8tfNx7vkH/V8LGuZFwc94?= =?us-ascii?q?YnhrRSc6+q45XlOgnF6O5wiEPSANiJ8OpK3uzRta2oGXcN55qMqjgjSNRNTF?= =?us-ascii?q?dEwd4TgxRmBceEDUPhK/u/Zic3EexJVURu+DewNk0GUJ+kNUffqXCz8zMeXw?= =?us-ascii?q?7nO1opdMLyHIOaz9yt0Py/8IHSZAMOgyehZbR1L1O9qgCD/sIXmoBlbK02z1?= =?us-ascii?q?PFpXZTM+JR2StkKEmSkBD1+srVntZ7/j5Vuu49+sIISqj8c6kiBbxfFyg9cm?= =?us-ascii?q?0=3D?=
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-AV: E=Sophos;i="5.70,459,1574121600"; d="scan'208";a="418752218"
Received: from rcdn-core-7.cisco.com ([173.37.93.143]) by alln-iport-3.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 19 Feb 2020 12:47:16 +0000
Received: from XCH-RCD-002.cisco.com (xch-rcd-002.cisco.com [173.37.102.12]) by rcdn-core-7.cisco.com (8.15.2/8.15.2) with ESMTPS id 01JClFSY010733 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Wed, 19 Feb 2020 12:47:16 GMT
Received: from xhs-rtp-003.cisco.com (64.101.210.230) by XCH-RCD-002.cisco.com (173.37.102.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 19 Feb 2020 06:47:15 -0600
Received: from xhs-rtp-002.cisco.com (64.101.210.229) by xhs-rtp-003.cisco.com (64.101.210.230) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 19 Feb 2020 07:47:13 -0500
Received: from NAM12-DM6-obe.outbound.protection.outlook.com (64.101.32.56) by xhs-rtp-002.cisco.com (64.101.210.229) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Wed, 19 Feb 2020 07:47:13 -0500
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZT6w3u/WpWfeWdFYHod+LIz4fyWsTyLMBUGKdWbsvvh/xnHckEyZKOaat25Ypj7hlwh1n6cmWfrArt6ylpIpYdj1GZhv/sQsTbyNEwoSiUUgJouAsDn81DgEqpK/GgkZHs5ows/JabQ+016/yako+nTo/bsc5i+kIUaPfn7cFNMt8BWm74uTQWx2UIpw5VyGGV55dLYMJVAT6BBnLpFE1+3SJxJIQuRgK4deYmTvCGLQBsS9A8HU7IK0J7uWMpmsVSgE17yWoFQcg2/N7K9uurKSCPBMNKjcOlj/q3qp2tNIogDKpXcmeGbgbgHEmVPoJT7V17F8b7Kq2OhvtZtVFg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n1kk9q5yi0xRhOvGjU7GaAtxhT8gmHp981fAy1j/mpY=; b=MbBzDwHLfFs2wp+o4mGU/TLAa1RzXsUZbzzjxlPIN/jqolTJUXCqsuk8U5NlQ+gyBCoboMeOVRZQ6DvwaIsy//PrlA2qzNIQ7YOW7YTLEfcFtnanFUPZjpultrFeYJTluLZI5zGRuSELX/aODrl6vA0ymWwfHNF410gk0Hpkfo1qAiprITyKZkOeWOwzHPf+JCNBmWokKJ9rsiTQMMg6JurCwSTHVxw1TfrOGNOmSD7opBS9Vrn9l1UDDCjUk+/hjT6zGntW9OQ09dEwaXgwKun68mHUkBHW+pwoTjUkbn2+SJSz//WVdeC3OO2xtz0aLwXaAr1HFEev4MlQHhBo7Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cisco.com; dmarc=pass action=none header.from=cisco.com; dkim=pass header.d=cisco.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n1kk9q5yi0xRhOvGjU7GaAtxhT8gmHp981fAy1j/mpY=; b=ELE7RTBJogN1pRZ4mzWn6jv47ewULnV3v4mY95OD/hmwSW+7dh36pNBg+Emq5Sh4ab1ur9/DWi7Whjcw+U1CfhMHKDf//iY9IzCQB46ZyDouEL22jjTnQ0qpIq1zb93XA9Q9jM84M+AgDbjNFPgLAC8wYOkR9Le7U9Ryv8I0tXw=
Received: from BN8PR11MB3794.namprd11.prod.outlook.com (20.178.221.205) by BN8PR11MB3826.namprd11.prod.outlook.com (20.178.219.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2729.25; Wed, 19 Feb 2020 12:47:12 +0000
Received: from BN8PR11MB3794.namprd11.prod.outlook.com ([fe80::d939:a6fb:475:cddd]) by BN8PR11MB3794.namprd11.prod.outlook.com ([fe80::d939:a6fb:475:cddd%4]) with mapi id 15.20.2729.032; Wed, 19 Feb 2020 12:47:12 +0000
From: "Acee Lindem (acee)" <acee@cisco.com>
To: Tarek Saad <tsaad=40juniper.net@dmarc.ietf.org>, tom petch <ietfc@btconnect.com>, Loa Andersson <loa@pi.nu>, "mpls@ietf.org" <mpls@ietf.org>
CC: "mpls-chairs@ietf.org" <mpls-chairs@ietf.org>, "draft-ietf-mpls-base-yang@ietf.org" <draft-ietf-mpls-base-yang@ietf.org>
Thread-Topic: [mpls] MPLS wglc draft-ietf-mpls-base-yang
Thread-Index: AQHVtlZI7ZkNGDET+USpMzFLNMccbafr8FqAgAlSWgCALSRDAIAAHfEA
Date: Wed, 19 Feb 2020 12:47:11 +0000
Message-ID: <3468A953-CD74-43D6-AE9D-4EB2B81084EE@cisco.com>
References: <2e2ce194-ed62-d225-ca7e-97e373c9c5c9@pi.nu> <DB7PR07MB565756000718666B19277A81A0370@DB7PR07MB5657.eurprd07.prod.outlook.com> <DB7PR07MB5657487FF5F4DB2E0F2006FCA00D0@DB7PR07MB5657.eurprd07.prod.outlook.com> <080939AD-4BE0-4138-AAF6-34141CD36385@juniper.net>
In-Reply-To: <080939AD-4BE0-4138-AAF6-34141CD36385@juniper.net>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
msip_labels: MSIP_Label_9784d817-3396-4a4f-b60c-3ef6b345fe55_Enabled=true; MSIP_Label_9784d817-3396-4a4f-b60c-3ef6b345fe55_Name=Juniper Business Use Only; MSIP_Label_9784d817-3396-4a4f-b60c-3ef6b345fe55_Enabled=true; MSIP_Label_9784d817-3396-4a4f-b60c-3ef6b345fe55_SiteId=bea78b3c-4cdb-4130-854a-1d193232e5f4; MSIP_Label_9784d817-3396-4a4f-b60c-3ef6b345fe55_ContentBits=0; MSIP_Label_9784d817-3396-4a4f-b60c-3ef6b345fe55_Method=Standard; MSIP_Label_9784d817-3396-4a4f-b60c-3ef6b345fe55_ActionId=5c7ae61b-4200-4976-b63d-00007479d7aa; MSIP_Label_9784d817-3396-4a4f-b60c-3ef6b345fe55_SetDate=2020-02-19T05:55:45Z;
authentication-results: spf=none (sender IP is ) smtp.mailfrom=acee@cisco.com;
x-originating-ip: [2001:420:c0c4:1004::17d]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: df30257e-b49a-4507-a6f0-08d7b539d71a
x-ms-traffictypediagnostic: BN8PR11MB3826:
x-microsoft-antispam-prvs: <BN8PR11MB3826C59A58990E35E51DCB92C2100@BN8PR11MB3826.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:3826;
x-forefront-prvs: 0318501FAE
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(346002)(366004)(396003)(136003)(39860400002)(376002)(189003)(199004)(36756003)(5660300002)(81156014)(110136005)(81166006)(8676002)(53546011)(66946007)(6506007)(4326008)(86362001)(54906003)(64756008)(66476007)(66556008)(186003)(8936002)(66446008)(76116006)(2616005)(91956017)(71200400001)(2906002)(6486002)(33656002)(966005)(316002)(478600001)(6512007); DIR:OUT; SFP:1101; SCL:1; SRVR:BN8PR11MB3826; H:BN8PR11MB3794.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1;
received-spf: None (protection.outlook.com: cisco.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: SYV7R/nuyd9ZvN7DzaRBpc4dOyKZwXIoPtR5akYi3Tem2frb1GZrT0oTMVbW/Xm/I7rWsiuWAbXsxoviEl8OTyYpP1W7IHsSCVbMlT0zGc9bvuQrHiTE/JBVvxlZ9O48iwgIKzCVs48DX5W5cBxY8BlXmlybSYTZOMaPIb3zeqHWdpu86o/j3K8EVvgpbsMgWjF5PJAwCffvFLKREAtiVg/EayBtnzHaurHq4DW6RIIXpnGUK+iZROH79HaudtnFCcsAmcCkCDOEr80piKRIeh+ildhJp8X2pBinLUgz7DRudvHFw9Vh8dA+MNs4eIcH+/D19H8keQgQU4GJhdxFFMt5k1DUxRXMHQm/WWnQBJkeKZ6PAntVLi3H1n+gdFkuIgBhnoOCIXUSBkd0IuYbDV0SLgLFINOluNWO8I3R0kbnjnjPSK1pnMe8zPlEX69+qbhl8i7IlhVihG3u/I79LsbgKzR1YekDSC4ddSPUpTIJjB9hrQ6CVOjV3PKP68Nr+5y58eax7AizvtZkrUg//A==
x-ms-exchange-antispam-messagedata: C9+MbMbItcRZcTmrIYFEvt8IdljAwKuwJhEqbidQz2Ju47p8FvTr1SBjc+FRnP+uYIlucSy/d94yhwOn9wYDaoaUYar26Qqi7J+gFXxqa5V+qKZpjSfrfXpfzZa/Yo2P1h3p89buhKSoiWh1NREJhg0esLFSSIs/kxvtdK6+Bss=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-ID: <CD27E455AD2BF14F9BCB7A92FF041360@namprd11.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: df30257e-b49a-4507-a6f0-08d7b539d71a
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Feb 2020 12:47:12.0657 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ked/gnJwA8gIrZOg8/21roBSGDM+J2Y2nJ48jLBYzrWWy+3sLs/A30LqQPo9CSrC
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR11MB3826
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.37.102.12, xch-rcd-002.cisco.com
X-Outbound-Node: rcdn-core-7.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/yNUYEGXbTF8JkYpan69NWpdgKBI>
Subject: Re: [mpls] MPLS wglc draft-ietf-mpls-base-yang
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Feb 2020 12:47:22 -0000

Hi Tarek,

On 2/19/20, 1:00 AM, "mpls on behalf of Tarek Saad" <mpls-bounces@ietf.org on behalf of tsaad=40juniper.net@dmarc.ietf.org> wrote:

    Hi Tom,
    
    Thanks much for your review and useful comments. We have posted a new revision -12 at https://tools.ietf.org/html/draft-ietf-mpls-base-yang-12 that addresses those. Let us know if you have further comments.
    Also, see inline for responses on closure.
    
    On 1/21/20, 7:38 AM, "tom petch" <ietfc@btconnect.com> wrote:
    
    Some more technical thoughts on this I-D
    	
    	Abstract
    	
    	LSP is not in the RFC Editor list of 'so well known ...'
    [TS]: it is listed at https://www.rfc-editor.org/materials/abbrev.expansion.txt   

 
[ACEE] It is listed but since there is no asterisk by it so It must be expanded on first use.
Thanks,
Acee
    
    	s.2.1
    	   The other MPLS route(s) that are non-IP prefix routes are modelled by
    	   introducing a new "mpls" address-family RIB as per recommendation .
    	Where is that?
    [TS]: Please refer to identity below defined in the model which has rt:address-family as base.
      identity mpls {
    	base rt:address-family;
    	description
    	  "This identity represents the MPLS address family.";
      }    
    	s.2.2
    	   interfaces-mpls:
    		  A YANG grouping that describes the list of MPLS enabled interfaces
    		  on a device.
    	
    	   label-blocks:
    		  A YANG grouping that describes the list of MPLS enabled interfaces
    		  on a device.
    	
    	um?
    [TS]: we corrected the description. See below:
    NEW:
    A YANG grouping that describes the list of assigned MPLS label blocks and its properties.
    
    	
    	YANG Module
    		 Copyright (c) 2018 IETF Trust
    	
    		leaf loadshare {
    	I  would  value a reference for this.
    [TS]: rfc3031 section 3.11 and  3.12.
    
    	  grouping interface-mpls-properties {
    	...
    		  type boolean;
    		  description
    		   "'true' if mpls encapsulation is enabled on the interface.
    		   'false' if mpls encapsulation is enabled  on the interface.";
    	
    		leaf mtu {  type uint32; description
    			"MPLS Maximum Transmission Unit (MTU) in bytes";
    	
    	um what is included in MTU here  c.f.draft-ietf-netmod-intf-ext-yang-07
    	which  includes L2 header but not FCS in Layer 2 MTU;
    	a reference might help
    [TS]: includes L2 MTU + maximum MPLS label stack size. rfc3032 section 3.2.
    	
    	  grouping interfaces-mpls {    description "List of MPLS interfaces";
    		list interface {   key "name";  description "List of MPLS
    	interfaces";
    		  leaf name {   type if:interface-ref;
    			description   "The name of a configured MPLS interface";
    	
    	no conditional so every RIP or dial up X.25 e.g.is going to get this:-( probably ok
    	
    	  augment "/rt:routing" {
    	ditto, although probably less significant
    [TS]: added feature mpls, and added if-feature check under the augmentations.
    	
    	  augment "/rt:routing/rt:ribs/rt:rib/rt:routes/rt:route/"
    			+ "rt:next-hop/rt:next-hop-options/rt:simple-next-hop" {
    		description
    		  "Augment 'simple-next-hop' case in IP unicast routes.";
    	
    	other I-D augment control plane/protocols/static-routes
    [TS]: the MPLS Static model is a separate model that is described in draft-ietf-mpls-static-yang.
    
    Regards,
    Tarek
    	
    	Tom Petch    
    
    _______________________________________________
    mpls mailing list
    mpls@ietf.org
    https://www.ietf.org/mailman/listinfo/mpls