Re: [mpls] MPLS-RT review of draft-hegde-mpls-spring-epe-oam

"Bocci, Matthew (Nokia - GB)" <matthew.bocci@nokia.com> Mon, 02 March 2020 10:18 UTC

Return-Path: <matthew.bocci@nokia.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 395EC3A0496; Mon, 2 Mar 2020 02:18:04 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.89
X-Spam-Level:
X-Spam-Status: No, score=-1.89 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, T_SPF_TEMPERROR=0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=nokia.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id b7uQZUvGLS8G; Mon, 2 Mar 2020 02:17:56 -0800 (PST)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80094.outbound.protection.outlook.com [40.107.8.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 35AA33A047F; Mon, 2 Mar 2020 02:17:50 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; =?utf-8?q?b=3DS3PZUBOso5OZytYdHSBN0/bPlmBPuIvrSudiAnO7GOZpl/JRGKj7YBB2jSvDc?= =?utf-8?q?M9wI5hf46PfMUnRL39zXEBtR7jmGoS8RnoXc8WlqNCQUGAYh3LtvV7QPRc/xXU64o?= =?utf-8?q?X35KeBzYSfrHOKJULiQYFwu06ciJ09oI6mVxwXsF0OMxnt25hGNiDidHGus8lOLxp?= =?utf-8?q?ecWMCdh3l7KRLGNSDpB1o1qghAbUCaiKb0D+BvuuToI4tUb9M8XvC1hhNlOGqI/ia?= =?utf-8?q?PL2y5vk+s+TBqiScaS03NeLgRs0QJUefj7oShfQmZHLvy5az0V/QNWRGc1JgGLKwG?= =?utf-8?q?XotcA8qbxBTNvFcuNPx9g=3D=3D?=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; =?utf-8?q?h=3DFrom=3ADate=3ASubject=3AMessage-ID=3ACont?= =?utf-8?q?ent-Type=3AMIME-Version=3AX-MS-Exchange-SenderADCheck=3B?= =?utf-8?q?bh=3D61DYUYBX0vFGIb6AhLNBQJu4o9KIjvsrdxT101U8PtM=3D=3B_b=3DAkjklG?= =?utf-8?q?b0YuKkVVZ1Zvr0njEgWNgngK6cn/wY2P69gnrXieDZp8ETDE0V2oqwzBt5pYHxyJZ?= =?utf-8?q?jZYtLJ0GSk7AYJfi8UGlsAdW4qFVELd5fOx+X65LhZcw/b86Ai50QwxPWGLwBigSC?= =?utf-8?q?Iy9shXf86DeNwB9UaVhJn9IeBVuooMVk5jB1GRiYqvBju/TDj57kUO2nCVNY7HB8g?= =?utf-8?q?W2Coi/ev0S+s2/sa25NMOhs/vyswr2vTcnh8RI6WL8kojUhhDJzjX34ODrksoVNSD?= =?utf-8?q?2GWx+Kvn+E8X/2XqcRbI89IsrrZDnAdb54VOtl5BbBi+eBy4VCbtpiDR7cz6Wmf7X?= =?utf-8?q?pQ30kmRJPUg=3D=3D?=
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nokia.com; dmarc=pass action=none header.from=nokia.com; dkim=pass header.d=nokia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nokia.onmicrosoft.com; s=selector1-nokia-onmicrosoft-com; =?utf-8?q?h=3DFrom=3ADate=3ASubject=3AM?= =?utf-8?q?essage-ID=3AContent-Type=3AMIME-Version=3AX-MS-Exchange-SenderADC?= =?utf-8?q?heck=3B_bh=3D61DYUYBX0vFGIb6AhLNBQJu4o9KIjvsrdxT101U8PtM=3D=3B_b?= =?utf-8?q?=3DUvwWU8WyzDPjIZmdZggHxHXYbuPDi0wXeOvn5w03sH3wEISgxbqFxFgWitsYlb?= =?utf-8?q?8ZcbRPeMs8TfMdChUDS2uVoC32hqOlU7YfQPbsuwjU6/GSqkRMKnqwuysBjn65IBu?= =?utf-8?q?ZoWk7mziUgcdroQrRrwsNSy0xpwPxicJpq7HDy4juZiw=3D?=
Received: from DB7PR07MB4106.eurprd07.prod.outlook.com (52.134.103.159) by DB7PR07MB4697.eurprd07.prod.outlook.com (52.135.134.153) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2793.9; Mon, 2 Mar 2020 10:17:46 +0000
Received: from DB7PR07MB4106.eurprd07.prod.outlook.com ([fe80::d1d:70e6:1bc8:7437]) by DB7PR07MB4106.eurprd07.prod.outlook.com ([fe80::d1d:70e6:1bc8:7437%7]) with mapi id 15.20.2793.011; Mon, 2 Mar 2020 10:17:46 +0000
From: "Bocci, Matthew (Nokia - GB)" <matthew.bocci@nokia.com>
To: "draft-hegde-mpls-spring-epe-oam@ietf.org" <draft-hegde-mpls-spring-epe-oam@ietf.org>, "mpls-chairs@ietf.org" <mpls-chairs@ietf.org>
CC: "mpls@ietf.org" <mpls@ietf.org>
Thread-Topic: MPLS-RT review of draft-hegde-mpls-spring-epe-oam
Thread-Index: AQHV4vKeUWPhHQxU802Q8qJSjuS136g1MbyA
Date: Mon, 2 Mar 2020 10:17:46 +0000
Message-ID: <6D84F768-8EA8-406B-993F-A9E56C823728@nokia.com>
References: <2141e262-752f-0c7e-fdcb-03aea45e9aa1@pi.nu>
In-Reply-To: <2141e262-752f-0c7e-fdcb-03aea45e9aa1@pi.nu>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/10.22.0.200209
authentication-results: spf=none (sender IP is ) smtp.mailfrom=matthew.bocci@nokia.com;
x-originating-ip: [81.108.178.133]
x-ms-publictraffictype: Email
x-ms-office365-filtering-ht: Tenant
x-ms-office365-filtering-correlation-id: 5f8e0e58-b282-41b3-5712-08d7be92f40f
x-ms-traffictypediagnostic: DB7PR07MB4697:
x-microsoft-antispam-prvs: =?utf-8?q?=3CDB7PR07MB4697688D66E31B2CA8C7AB36EBE?= =?utf-8?q?70=40DB7PR07MB4697=2Eeurprd07=2Eprod=2Eoutlook=2Ecom=3E?=
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-forefront-prvs: 033054F29A
x-forefront-antispam-report: SFV:NSPM; =?utf-8?q?SFS=3A=2810019020=29=284636?= =?utf-8?b?MDA5KSgzNzYwMDIpKDM2NjAwNCkoMzQ2MDAyKSgzOTg2MDQwMDAwMikoMTM2?= =?utf-8?b?MDAzKSgzOTYwMDMpKDE5OTAwNCkoMTg5MDAzKSgyNjAwNSkoNjUxMjAwNykoNDUw?= =?utf-8?b?MTAwMDAyKSg4NjM2MjAwMSkoMTg2MDAzKSg3NjExNjAwNikoMjYxNjAwNSko?= =?utf-8?q?478600001=29=2864756008=29=2866446008=29=2866556008=29=2866946007?= =?utf-8?b?KSg0MzI2MDA4KSg2NjQ3NjAwNykoOTE5NTYwMTcpKDM2NzU2MDAzKSg1NTIz?= =?utf-8?b?NjAwNCkoNzEyMDA0MDAwMDEpKDMxNjAwMikoMjkwNjAwMikoNjQ4NjAwMiko?= =?utf-8?q?6506007=29=2881156014=29=2881166006=29=288676002=29=285660300002?= =?utf-8?q?=29=2833656002=29=28110136005=29=288936002=29=3B?= DIR:OUT; SFP:1102; SCL:1; SRVR:DB7PR07MB4697; H:DB7PR07MB4106.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1;
received-spf: None (protection.outlook.com: nokia.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: =?utf-8?q?rD4VkAPXDtmXaklPlhyFpsqfDfm/LIK?= =?utf-8?q?h/bojJZ81wClhrFAab+ZsL65gYqxNltSIiezyGDiqDUCC7dbRYYxeYh2460J2vE2i?= =?utf-8?q?9cndwylcnLi0t41QJVh2sH1WVmRNRhUmHzn4jnqwNUYRPfb8TJFCRdLdfXs88VkFs?= =?utf-8?q?Ft5w/taz8UhQAEZbAKh41I1OdFpD1zHRHXQA6wr9EuF+Ob/ebQEK+higK4vi84q0Y?= =?utf-8?q?ROmFote9c4hKXxWU3y3pQPCYtII1qvz/ERFsRZZtePjcym0SCOx/KFKhpoYQ7TPjk?= =?utf-8?q?qHESOkYXXL5z0M3rn/gkmYK2XFtOQ8tzhHOsBdI6vwNLeKHLUdVoDunU8+q2UJ9in?= =?utf-8?q?Oh0o7dJeRyuaTlTHkQbb2wUOP9AqP94a00d9tf86CmBKau7v2laaR1Oh63/vrprYj?= =?utf-8?q?LYScK3dupfez5C8pLieh66Eqb9S?=
x-ms-exchange-antispam-messagedata: =?utf-8?q?1x91w8bAbQE8xP7ZL5pz2C9/jzD751?= =?utf-8?q?BO8ijx1K8IWi1GUk42c2f4I4stUjvveMySo6Orp4kPXXNWNjLS0XtMIutK1JEiSx2?= =?utf-8?q?p9rORudTDJFgftnlzwEj6DGGlIthLNtD/8+8zWaTId86jzqlDaProNQ=3D=3D?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-ID: <BF2C2B1624400F4398B6364CDCAF5E2D@eurprd07.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: nokia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5f8e0e58-b282-41b3-5712-08d7be92f40f
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Mar 2020 10:17:46.3844 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5d471751-9675-428d-917b-70f44f9630b0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: =?utf-8?q?Wkd7asd/Yu23Q7SflTyrx?= =?utf-8?q?2OTxCPwKP2QnEYYr82SKWtiuwu1BiaLYh5WsI3FciFkZt4NlqdMjTN2T7yzMpppZA?= =?utf-8?q?=3D=3D?=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR07MB4697
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/ztYR3LfZdCmNve7O31b6lD66vBk>
Subject: Re: [mpls] MPLS-RT review of draft-hegde-mpls-spring-epe-oam
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Mar 2020 10:18:05 -0000

Hello

I have been selected as an MPLS Review Team reviewer for this draft.

I found the document to be clear, well-written and coherent. It does address a problem that needs to be solved.

One technical comment that I have is that the document relies on the ingress LER launching the LSP Ping/Trace knowing the type of every SID along the path of the LSP in order to use the correct TLV in the target FEC stack. This presents a challenge for SR Policy because the path is just a list of SID labels with no type explicitly provided in the definition of the policy. 

This is slightly less of a problem in the case of RFC8287 because the head end node at least knows the details of the top SID.  In the case of EPE SIDs, a controller may learn these downstream SIDs though BGP-LS, but they are not learned directly by the head end node. The controller may or may not provide SID types to the node, but it is not clear what mechanism is available to do this. The draft rather side steps this issue and only provides the following guidance in section 2: "The node initiating the data plane monitoring may acquire the details of EPE-SIDs through BGP-LS advertisements...".  This statement should contain more detail about how this works (given that it is the controller that learns though BGP-LS), and what alternatives exist if the controller does not provide the SID types to the initiating node e.g. use of a NIL FEC type. An alternative would be to be more explicit that this is a gap which is out of scope of this draft and explicitly state that the mechanism that the initiating node learns the details of the EPE SIDs is out of scope. 

Best regards

Matthew


 
draft-hegde-mpls-spring-epe-oam@ietf.org <draft-hegde-mpls-spring-epe-oam@ietf.org>

On 14/02/2020, 04:52, "Loa Andersson" <loa@pi.nu> wrote:

    Mathew, Sam, Sasha and Italo,
    
    You have be selected as MPLS-RT reviewers for
    draft-hegde-mpls-spring-epe-oam.
    
    Note to authors: You have been CC'd on this email so that you can know
    that this review is going on. However, please do not review your own
    document.
    
    Reviews should comment on whether the document is coherent, is it
    useful (ie, is it likely to be actually useful in operational
    networks), and is the document technically sound?  We are interested
    in knowing whether the document is ready to be considered for WG
    adoption (ie, it doesn't have to be perfect at this point, but should be
    a good start).
    
    Reviews should be sent to the document authors, WG co-chairs and
    WG secretary, and CC'd to the MPLS WG email list. If necessary, comments
    may be sent privately to only the WG chairs.
    
    If you have technical comments you should try to be explicit about what
    *really* need to be resolved before adopting it as a working group
    document, and what can wait until the document is a working group
    document and the working group has the revision control.
    
    Are you able to review this draft by Feb 28, 2020? Please respond in a
    timely fashion.
    
    
    Thanks, Loa
    (as MPLS WG chair)
    -- 
    -- 
    
    
    Loa Andersson                        email: loa@pi.nu
    Senior MPLS Expert
    Bronze Dragon Consulting             phone: +46 739 81 21 64