[multipathtcp] AD review detailed comments [was: Re: AD review is coming]

Mirja Kuehlewind <ietf@kuehlewind.net> Tue, 16 April 2019 15:42 UTC

Return-Path: <ietf@kuehlewind.net>
X-Original-To: multipathtcp@ietfa.amsl.com
Delivered-To: multipathtcp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6D0171209F5; Tue, 16 Apr 2019 08:42:48 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.899
X-Spam-Level:
X-Spam-Status: No, score=-1.899 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5bhj60nirb6z; Tue, 16 Apr 2019 08:42:43 -0700 (PDT)
Received: from wp513.webpack.hosteurope.de (wp513.webpack.hosteurope.de [IPv6:2a01:488:42:1000:50ed:8223::]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D7CAC120A82; Tue, 16 Apr 2019 07:08:23 -0700 (PDT)
Received: from [129.192.10.3] (helo=[10.149.1.158]); authenticated by wp513.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) id 1hGOl3-0002dL-4E; Tue, 16 Apr 2019 16:08:21 +0200
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\))
From: Mirja Kuehlewind <ietf@kuehlewind.net>
In-Reply-To: <11187BAE-5E91-410D-9BDA-33F8A60D2458@kuehlewind.net>
Date: Tue, 16 Apr 2019 16:08:20 +0200
Cc: multipathtcp@ietf.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <E9C7AF5D-BFFB-4D09-9F83-5FFC1FB03E84@kuehlewind.net>
References: <11187BAE-5E91-410D-9BDA-33F8A60D2458@kuehlewind.net>
To: draft-ietf-mptcp-rfc6824bis.all@ietf.org
X-Mailer: Apple Mail (2.3445.104.8)
X-bounce-key: webpack.hosteurope.de;ietf@kuehlewind.net;1555423703;42c9214d;
X-HE-SMSGID: 1hGOl3-0002dL-4E
Archived-At: <https://mailarchive.ietf.org/arch/msg/multipathtcp/VK9o5rFrl9Sgt07WfpC3MOdJsPw>
Subject: [multipathtcp] AD review detailed comments [was: Re: AD review is coming]
X-BeenThere: multipathtcp@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Multi-path extensions for TCP <multipathtcp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/multipathtcp>, <mailto:multipathtcp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/multipathtcp/>
List-Post: <mailto:multipathtcp@ietf.org>
List-Help: <mailto:multipathtcp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/multipathtcp>, <mailto:multipathtcp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Apr 2019 15:42:55 -0000

Hi again,

Here are the more detailed comment of my review as promised. Most of these comments are editorial, however, there are a few comments on use of normative language as well as clarifications and also one point about specifying the registration policy for the new registry (comment 13 below) which really must be address in the next version.

Thanks!
Mirja

----------------------------

1) Sec 3.1: “If a responder does not support (or does not want to support)
   any of the initiator's proposals, it can respond without an
   MP_CAPABLE option, thus forcing a fallback to regular TCP.”
   I wonder if this should be normative: “…it MUST respond without an MP_CAPABLE option…”..?

2) Sec 3.3.1: “… and any later data for that sequence space should be ignored.”
   Maybe SHOULD?

3) Sec 3.3.2: “If the DSN received is
   32 bits, it is valid for the implementation to choose whether to send
   a 32-bit or 64-bit Data ACK.”
  Maybe “… the implementation MAY choose whether to send…”

4) Sec 3.3.3: I guess if there is only one subflow it is probably safe to send the TCP FIN together with a DATA_FIN (as an optimisation), or would there be a reason to not do that? Should that be mentioned in the text?

5) Sec 3.3.8: Is the reference to ECN really needed? I feel that this idea is hard to understand without further context.

6) Sec 3.6: Maybe I missed it that but it seems that the error codes “Unacceptable performance” is not further used in the document while I would think further guidance might be needed. 

7) Sec 3.7: Minor editorial point I noticed here but there might be other cases:
“If lost options on data packets occur on any other subflow apart from the initial subflow…”
Not sure if “initial” is correct here because if you move you may not have the initial subflow anymore… I guess it would be something like “all expect one” here…

8) Sec 3.9.2: I wondering about this text, given this is a bis doc and we have an deployment experience report:
“We expect that experience gathered from deployments will provide further guidance on this, and will be affected by particular application characteristics (which are likely to change over time).  […] Results from experimental deployments are needed in order to verify the correctness of this proposal.”
Maybe just rephrase it say something like “We got some experience but more is needed/there is no generics solution.”.. or just remove…

9) Maybe section 3.9.2 should also say again that receiving a second ADD_ADDRESS (with the same ID) is a request from the other end to open a subflow immediately?

10) Sec 3.9.3: Should learned information really be cached “forever”, or should the text maybe says also something about retrying after some time…?

11) Sec 8.1: “This document defines one additional subtype
   (ADD_ADDR) and updates the references to this document for all sub-
   types except ADD_ADDR, which is deprecated.”
   What?

12) Also sec 8.1: RFC6824 also has this half-sentence:
“future assignments are to be defined by Standards Action as defined by [25].”
which got lost in this document. However, given this document obsoletes RFC6824 it should probably also mention the assignment policy for this registry.

13) Sec 8.3. doesn’t specify an assignment policy.

14) Given RFC6824 will be obsoleted by this spec, it does not to be listed in the reference section.

Nits:
- Sec 3.3.6: s/if it so desired for reliability reasons./if it is desired for reliability reasons./
- Sec 3.3.&: s/Multiple retransmissions are triggers that/Multiple retransmissions are triggered that/ or actually
                         s/Multiple retransmissions are triggers that/If multiple retransmissions are triggered that/
- Sec 3.7: s/Middlebox interferance/Middlebox interference/
- Sec 3.9.2: s/If the the same ports are used on all subflows/If the same ports are used on all subflows/



> On 12. Apr 2019, at 18:40, Mirja Kuehlewind <ietf@kuehlewind.net>; wrote:
> 
> Hi authors, hi shepherd/Phil,
> 
> Just wanted to quickly let you know that I’ve started the IETF last call just now in order to hopefully get this document on the telechat in 3 weeks. 
> 
> I’ve not finished my AD review completely but I am nearly done and convinced that this doc is ready to start IETF last call. So far I have only some editorial or smallish comments and nits which I will send in detail beginning of next week and can be address during or after IETF last call.
> 
> Only one request for now (mostly with an eye on the IESG evaluation): The draft says that changes are made which are not backward compatible (see sec 3.1). That’s fine, however, it would be good to also explain a little bit in the draft as well as in the shepherd write up (!) why this is okay. My understanding is that in case of a v0 server the connection will “just" fall-back to non-MPTCP capable and that this is acceptable in current deployment situation. Please confirm and at least update the write-up accordingly as soon as possible!
> 
> Thanks!
> Mirja
> 
> 
>