Re: [multipathtcp] [Gen-art] Genart last call review of draft-ietf-mptcp-rfc6824bis-13

Alissa Cooper <alissa@cooperw.in> Mon, 13 May 2019 20:23 UTC

Return-Path: <alissa@cooperw.in>
X-Original-To: multipathtcp@ietfa.amsl.com
Delivered-To: multipathtcp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 393911200B9; Mon, 13 May 2019 13:23:59 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.701
X-Spam-Level:
X-Spam-Status: No, score=-2.701 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=cooperw.in header.b=cXTjo07c; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=V2CiVxp9
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1etQ8SLn0Yda; Mon, 13 May 2019 13:23:57 -0700 (PDT)
Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0B24212008C; Mon, 13 May 2019 13:23:57 -0700 (PDT)
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 246945CB; Mon, 13 May 2019 16:23:56 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Mon, 13 May 2019 16:23:56 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cooperw.in; h= content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; s=fm3; bh=8 m/1KkZzagfJVErV8qa3tQeI45ea/2F0oX26psn6HPA=; b=cXTjo07cFZin8+9C5 zaLAlC8GKcXizaq7dD49Xyj5CyGYd0MjC45Kj6rqweZEpb/sJg273LwG174c/bh7 MFZDDx9sDQm8BAA3oILmrMIuDDR1bBB/nzj9/WLE5QGjx6wOo0ReTb0R7xyx2xZm Pjj9Ix68lZNLzxDDewBPRDsIOfqIpYSKP9weelHLICdBT0vGH33ScV7/0xOZbJ7I LhoRKVw+rd/LxCCvyRVGWlFr1e98k8MxXha4SBh6WqKxbNHrGPY0tNaqbaMC/230 1jkF5VX3JxHkYA3zJMrEVnbPVO95l2Qw3aLXiYRwSL+O87uOy58zqLNwNjGOXd2N jl4jQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=8m/1KkZzagfJVErV8qa3tQeI45ea/2F0oX26psn6H PA=; b=V2CiVxp97ewWYQuS47BhxVM9AwxAzIWb3F2K/SdhrEaFux/5pnmIqIGmr VgXWifPDG0FOMRpYHCvnFx7fxIxuBNuvesfQAFXazOZAfAWuaLpLn+jR7ETotPZe RbuUfvKZUn5HJx399TchxJvtciSKc8fVN2En18/vRPy5HSmZm9NaKnsibsfzHWoW rYSt7U/UkWyBH2VFo/jbtk2gF/aIR8Voj0dRIzS5dgUAjOzDwZjq5iA4l+rZXvhn jcQTJELDV8qCVo5s0peoiZQFm3SB5rpdoVEedTcMFm8pAl8gsdIWCzGSKqxQA+qy IT7beYSLIBzuL10c1UUE5imgCbKXA==
X-ME-Sender: <xms:W9LZXEDv4ref_U7xZJu_67sWbrrz47UvxTQAbaEH9Hp4KWBSu50x7g>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrleeggddugeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurheptggguffhjgffgffkfhfvofesthhqmhdthhdtvdenucfhrhhomheptehlihhs shgrucevohhophgvrhcuoegrlhhishhsrgestghoohhpvghrfidrihhnqeenucffohhmrg hinhepihgvthhfrdhorhhgnecukfhppedujeefrdefkedruddujedrkeejnecurfgrrhgr mhepmhgrihhlfhhrohhmpegrlhhishhsrgestghoohhpvghrfidrihhnnecuvehluhhsth gvrhfuihiivgeptd
X-ME-Proxy: <xmx:W9LZXG_0MYOOuNbvLmSpGV63GDflguvAgC58i-r_CJplzT5CYhSnXA> <xmx:W9LZXOcPBzFiTEHDmwUpWUxLScqcv1kH9rMS53m69ES7ss4qyRpnrg> <xmx:W9LZXBC_Uoq9eqTnhnaTIma7gKASzubixF7xb0ndEvmWI4iAU0y_8Q> <xmx:W9LZXHRH4MCvJZbtqJni0dLoZw3HbKWh2D3ZZ8gHOGzxkL5qX7sOag>
Received: from rtp-alcoop-nitro5.cisco.com (unknown [173.38.117.87]) by mail.messagingengine.com (Postfix) with ESMTPA id B854A10378; Mon, 13 May 2019 16:23:54 -0400 (EDT)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
From: Alissa Cooper <alissa@cooperw.in>
In-Reply-To: <155627231588.6796.18228205076376708862@ietfa.amsl.com>
Date: Mon, 13 May 2019 16:23:52 -0400
Cc: IETF Gen-ART <gen-art@ietf.org>, multipathtcp@ietf.org, draft-ietf-mptcp-rfc6824bis.all@ietf.org, ietf@ietf.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <4F45DD51-9B01-4261-B402-D024CF27B95B@cooperw.in>
References: <155627231588.6796.18228205076376708862@ietfa.amsl.com>
To: Ines Robles <mariainesrobles@googlemail.com>
X-Mailer: Apple Mail (2.3445.9.1)
Archived-At: <https://mailarchive.ietf.org/arch/msg/multipathtcp/jnWcMzQMtbj3Z_QtJw5VicvVjrQ>
Subject: Re: [multipathtcp] [Gen-art] Genart last call review of draft-ietf-mptcp-rfc6824bis-13
X-BeenThere: multipathtcp@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Multi-path extensions for TCP <multipathtcp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/multipathtcp>, <mailto:multipathtcp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/multipathtcp/>
List-Post: <mailto:multipathtcp@ietf.org>
List-Help: <mailto:multipathtcp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/multipathtcp>, <mailto:multipathtcp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 13 May 2019 20:23:59 -0000

Ines, thanks for your review. I see that your suggestions have been incorporated into the -15, so thanks to the authors for that. I have entered a DISCUSS ballot to chat about the interaction between the B-flag and version negotiation.

Alissa


> On Apr 26, 2019, at 5:51 AM, Ines Robles via Datatracker <noreply@ietf.org>; wrote:
> 
> Reviewer: Ines Robles
> Review result: Ready
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>;.
> 
> Document: draft-ietf-mptcp-rfc6824bis-13
> Reviewer: Ines Robles
> Review Date: 2019-04-26
> IETF LC End Date: 2019-04-26
> IESG Telechat date: Not scheduled for a telechat
> 
> Summary:
> 
> I believe the draft is technically good. This document is well written and
> clear to understand. I found the document quite complete.
> 
> The document specifies v1 of Multipath TCP, obsoleting v0 as specified in
> RFC6824, through clarifications and modifications primarily driven by
> deployment experience.
> 
> I have some minor questions for the authors.
> 
> Major issues: Not found
> 
> Minor issues: Not found
> 
> Nits/editorial comments:
> 
>    Section 1.1 " the working group imposed..." --> " mptcp working group
>    imposed..."
> 
> Some Comments/Questions:
> 
>  - Section 1.4: "...A1<->B2 and A2<->B2.  Although this additional session is
>  shown as being initiated from A2, it could equally have been initiated from
>  B1." --> would it be "initiated from B2"? or you mean B1 following the
>  example showed in Figure 2?
> 
>  - For Figure 5 (Pag.24), Figure 6(Pag.26) and Figure 11(Pag.40): would it be
>  correct to add "(rsv)" in the empty field (between "Subtype" and "B" fields)
>  as showed in Figure 12 (Pag. 44).?
> 
>  - Section 8.1:
>  "This document defines one additional subtype (ADD_ADDR) and updates the
>  references to this document for all subtypes except ADD_ADDR, which is
>  deprecated.":
> 
>  - It seems that the additional subtype is MP_TCPRST and not ADD_ADDR,
>  comparing table 2 between this draft and RFC6824.
> 
>  - Would it be correct state instead of "ADD_ADDR deprecated" to "ADD_ADDR
>  modified"? In Appendix E states; "The ADD_ADDR option (Section 3.4.1), which
>  is used to inform the other host about another potential address, is
>  different in several ways.  It now includes an HMAC of the added address, for
>  enhanced security.  In addition, reliability for the ADD_ADDR option has been
>  added: the IPVer field is replaced with a flag field, and one flag is
>  assigned (E) which is used as an 'Echo' so a host can indicate that it has
>  received the option."
> 
>  Thanks for this document,
> 
>  Ines.
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art