Re: [netconf] [netmod] Problems with lint validation

"Reshad Rahman (rrahman)" <rrahman@cisco.com> Tue, 13 August 2019 17:24 UTC

IronPort-PHdr: 9a23:/85hjBcinSyOUQiA0N7RhYOZlGMj4e+mNxMJ6pchl7NFe7ii+JKnJkHE+PFxlwGRD57D5adCjOzb++D7VGoM7IzJkUhKcYcEFnpnwd4TgxRmBceEDUPhK/u/dTYzHMFLUndu/mqwNg5eH8OtL1A=
From: "Reshad Rahman (rrahman)" <rrahman@cisco.com>
To: Balázs Lengyel <balazs.lengyel@ericsson.com>, "netconf@ietf.org" <netconf@ietf.org>, "'netmod@ietf.org'" <netmod@ietf.org>
Thread-Topic: [netmod] Problems with lint validation
Thread-Index: AQHVUfvoskOeY98d+0aVvNALs4BcMw==
Date: Tue, 13 Aug 2019 17:24:05 +0000
Message-ID: <15D146FD-FD7A-451C-8655-C6BC1987CC22@cisco.com>
Accept-Language: en-US
Content-Language: en-US
user-agent: Microsoft-MacOutlook/10.1a.0.190609
received-spf: None (protection.outlook.com: cisco.com does not designate permitted sender hosts)
Content-Type: multipart/mixed; boundary="_004_15D146FDFD7A451C8655C6BC1987CC22ciscocom_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 17b65882-c2ed-4c6b-fadf-08d720130b4c
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Aug 2019 17:24:05.9877 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: xMKqJenwKJQQrmD9jorBtN8vNRcFRs+74HTLfXVcMUIydQNQYCBEIvp5AWTlRhxUjHOD1YtgH5RmY1HwTi8Gaw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4301
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.36.7.26, xch-aln-016.cisco.com
X-Outbound-Node: rcdn-core-4.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/netconf/2crOWwzwl50JFe-n1OHlcwIfNWo>
Subject: Re: [netconf] [netmod] Problems with lint validation
X-BeenThere: netconf@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NETCONF WG list <netconf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netconf>, <mailto:netconf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netconf/>
List-Post: <mailto:netconf@ietf.org>
List-Help: <mailto:netconf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netconf>, <mailto:netconf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 13 Aug 2019 17:24:13 -0000

Balazs, we ran into the same issue last year. If you look at the ticket in the attached email, yanglint has a fix for the non-config leaf issue but OpenSUSE doesn’t have a version of libyang with the fix.

Regards,
Reshad.

From: netmod <netmod-bounces@ietf.org> on behalf of Balázs Lengyel <balazs.lengyel@ericsson.com>
Date: Tuesday, August 13, 2019 at 11:33 AM
To: "netconf@ietf.org" <netconf@ietf.org>, "'netmod@ietf.org'" <netmod@ietf.org>
Subject: [netmod] Problems with lint validation

Hello,
I validated my model ietf-notification-capabilities@2019-08-13.yang<mailto:ietf-notification-capabilities@2019-08-13.yang> with yangvalidator.com. My model seems fine, but I got a lot of errors from lint:

yanglint Validation
err : The leafref leaf is config but refers to a non-config leaf. (/ietf-subscribed-notifications:subscriptions/subscription/target/stream/stream)
err : The leafref leaf is config but refers to a non-config leaf. (/ietf-subscribed-notifications:subscriptions/subscription/target/stream/stream)
err : Invalid value "subscription-policy" of "uses". (/ietf-subscribed-notifications:subscriptions/subscription/subscription-policy)
err : Copying data from grouping failed. (/ietf-subscribed-notifications:subscriptions/subscription/subscription-policy)
err : Module "ietf-subscribed-notifications" parsing failed.
err : Importing "ietf-subscribed-notifications" module into "ietf-yang-push" failed.
err : Module "ietf-yang-push" parsing failed.
err : Importing "ietf-yang-push" module into "ietf-notification-capabilities" failed.
err : Module "ietf-notification-capabilities" parsing failed.

At least some of these are not really errors. (pyang, confdc accepts them)
E.g.  the first error is not true because the leafref has require-instance false.

It would be nice if this could be corrected. I got the same messages from the draft submission tool too.

Regards Balazs

--- Begin Message ---

#2667: Newer version of yanglint needed for YANG validation

 So datatracker still has yanglint showing these errors for
 https://datatracker.ietf.org/doc/draft-ietf-netconf-subscribed-
 notifications:
 yanglint 0.14.80: yanglint --verbose -p {rfclib} -p {draftlib} -p {tmplib}
 {model} -i:
 err : The leafref leaf is config but refers to a non-config leaf. (/ietf-
 subscribed-notifications:subscriptions/subscription/target/stream/stream)

 This is due to issue below which was fixed in yanglint in 0.16.59
 https://github.com/CESNET/libyang/issues/644

 So we need datatracker to use a more recent version of yanglint.

 Regards,
 Reshad.

-- 
-------------------------------+--------------------
 Reporter:  rrahman@cisco.com  |      Owner:
     Type:  enhancement        |     Status:  new
 Priority:  major              |  Milestone:  (None)
Component:  Datatracker: Yang  |    Version:
 Keywords:  sprint             |
-------------------------------+--------------------

Ticket URL: <https://tools.ietf.org/tools/ietfdb/ticket/2667>
ietfdb <https://tools.ietf.org/tools/ietfdb/>

--- End Message ---

[netconf] Problems with lint validation Balázs Lengyel
Re: [netconf] [netmod] Problems with lint validat… Reshad Rahman (rrahman)