[netconf] Yangdoctors last call review of draft-ietf-netconf-http-client-server-06

Ladislav Lhotka via Datatracker <noreply@ietf.org> Mon, 12 April 2021 08:19 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: netconf@ietf.org
Delivered-To: netconf@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 886F83A11A9; Mon, 12 Apr 2021 01:19:23 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Ladislav Lhotka via Datatracker <noreply@ietf.org>
To: <yang-doctors@ietf.org>
Cc: draft-ietf-netconf-http-client-server.all@ietf.org, last-call@ietf.org, netconf@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 7.27.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <161821556350.10432.14910369341748800490@ietfa.amsl.com>
Reply-To: Ladislav Lhotka <ladislav.lhotka@nic.cz>
Date: Mon, 12 Apr 2021 01:19:23 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/netconf/2slX5Z2W5JfZVJa2XhbJOEfZLhg>
Subject: [netconf] Yangdoctors last call review of draft-ietf-netconf-http-client-server-06
X-BeenThere: netconf@ietf.org
X-Mailman-Version: 2.1.29
List-Id: NETCONF WG list <netconf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netconf>, <mailto:netconf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netconf/>
List-Post: <mailto:netconf@ietf.org>
List-Help: <mailto:netconf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netconf>, <mailto:netconf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 12 Apr 2021 08:19:24 -0000

Reviewer: Ladislav Lhotka
Review result: Ready with Nits

The document defines two YANG modules - ietf-http-client and ietf-http-server -
that belong to a relatively complex set of modules. The modules are well
designed and nicely documented, both in the descriptions and document text.

**** Comments

- Sections 2.1.3 and 3.1.3: the sentence 'The "..." module does not contain any
protocol-accessible nodes.' is misleading in that the modules do define data
nodes that are intended to be protocol accessible after the corresponding
grouping is used. I know this is a part of the NETCONF/YANG lingo, but another
formulation that clearly says what's going on might be preferable.

- Sections 2.2 and 3.2: the XML snippets use document elements "http-client"
and "http-server", but these containers are not defined in the corresponding
modules. This is confusing, my suggestion is to rewrite the examples in the
JSON representation where no such top-level node is necessary.

- Placeholders BBBB, CCCC and EEEE are defined in Editorial Note but never used

**** Nits

- RFC 7950 is cited repeatedly (4 times) in a general context, e.g. whenever
YANG 1.1 is mentioned. It should suffice to use the citation at the first