Re: [Netconf] WGLC on netconf-event-notifications-13

["Eric Voit (evoit)" <[e-mail]>]

Thanks very much Martin.   Changes made as described in-line.

> From: Martin Bjorklund, October 10, 2018 5:15 AM
> 
> Hi,
> 
> I think this document is ready for publication.  Some minor comments below.
> And note a bug in SN as well.
> 
> 
> o  section 4
> 
>   OLD:
> 
>    The "encode-xml" feature of
>    [I-D.draft-ietf-netconf-subscribed-notifications] is mandatory to
>    support.
> 
>   NEW:
> 
>    The "encode-xml" feature of
>    [I-D.draft-ietf-netconf-subscribed-notifications] MUST be
>    supported.

Updated

> o  section 7
> 
>   Also, it seems this text starts a itemized list, but it probably
>   should not be a list:
> 
>    o  In case of error responses to an "establish-subscription" or

Updated

> o  section A.2.2
> 
>   Bad xmlns:
> 
>   OLD:
> 
>        <error-info
>           xmlns="urn:ietf:params:xml:ns:yang:ietf-yang-push">
>           <modify-subscription-datastore-error-info>
>             <period-hint>
>                 3000
>             </period-hint>
>           </modify-subscription-datastore-error-info>
>        </error-info>
> 
>   NEW:
>         <error-info>
>           <modify-subscription-datastore-error-info
>             xmlns="urn:ietf:params:xml:ns:yang:ietf-yang-push">
>             <period-hint>
>                 3000
>             </period-hint>
>           </modify-subscription-datastore-error-info>
>        </error-info>

Updated

> o  A.3.1
> 
>   The example has:
> 
>     <transport xmlns:nsn=
>     "urn:ietf:params:xml:ns:yang:ietf-netconf-subscribed-notifications">
>       nsn:netconf
>     <transport>
> 
>  There is no transport "netconf" defined in SN, so this is broken.

Updated.
 
>  But this illustrates a problem with SN; the "transport" leaf is  mandatory if the
> feature "configured" is supported.  The problem is  that just b/c a server
> supports the "configured" feature, it doesn't  mean that there is an identity
> defined for all transports; e.g.,  there is no identity defined for NETCONF.  So
> the leaf "transport"
>  should probably not be mandatory.

Made optional within the SN grouping "subscription-policy", and tweaked the definition as follows:

    leaf transport {
      if-feature "configured";
      type transport;
      description
        "For a configured subscription, this leaf specifies the 
        transport used to deliver messages destined to all receivers 
        of that subscription.";
    }

Also in SN, refined the definition of:

  +--rw subscriptions
     +--rw subscription* [id]
        +--rw transport             

To:

        refine "transport" {
          description
            "For a configured subscription, this leaf specifies the 
            transport used to deliver messages destined to all  
            receivers of that subscription.  This object is mandatory
            for subscriptions in the configuration datastore."
        }

> o  A.4
> 
>   Namespace and XPath errors:
> 
>   OLD:
> 
>     <stream-xpath-filter xmlns="urn:ietf:params:xml:ns:yang:ietf-vrrp">
>       /vrrp-protocol-error-event[protocol-error-reason="checksum-error"]
>     </stream-xpath-filter>
> 
>   NEW:
> 
>     <stream-xpath-filter vrrp:xmlns="urn:ietf:params:xml:ns:yang:ietf-vrrp">
>       /vrrp:vrrp-protocol-error-event[
>          vrrp:protocol-error-reason="vrrp:checksum-error"]
>     </stream-xpath-filter>

Update made

> o  Spelling of XPath
> 
>   s/xpath filter/XPath filter/  (a couple of places)

Found one.  Fixed.
 
>   OLD:
> 
>    This section provides examples which illustrate both xpath and
> 
>   NEW:
> 
>    This section provides examples which illustrate both XPath and

fixed

>   OLD:
> 
>    Establishing a subscription error reason via XPATH
> 
>   NEW:
> 
>    Establishing a subscription error reason via XPath

Fixed.

Eric 

> 
> /martin
> 
> _______________________________________________
> Netconf mailing list
> [e-mail]
> https://www.ietf.org/mailman/listinfo/netconf