Re: [Netconf] WGLC on netconf-event-notifications-13

"Eric Voit (evoit)" <evoit@cisco.com> Thu, 11 October 2018 13:54 UTC

Return-Path: <evoit@cisco.com>
X-Original-To: netconf@ietfa.amsl.com
Delivered-To: netconf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0F79D130E74 for <netconf@ietfa.amsl.com>; Thu, 11 Oct 2018 06:54:53 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.956
X-Spam-Level:
X-Spam-Status: No, score=-14.956 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.456, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id duo4V0-PCwBb for <netconf@ietfa.amsl.com>; Thu, 11 Oct 2018 06:54:50 -0700 (PDT)
Received: from alln-iport-8.cisco.com (alln-iport-8.cisco.com [173.37.142.95]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6EF0A130DD6 for <netconf@ietf.org>; Thu, 11 Oct 2018 06:54:50 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=2549; q=dns/txt; s=iport; t=1539266090; x=1540475690; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=gt9LNsfAk8V2b9+VBzOW2R39ZxNFHWk8OsGJyagfh8k=; b=VlhyY612bceCjxTbu5IkcyuP6RqZ1BDUrEEiBKyjuJ25Kaa8y1kcef4Q jLNyHZZcjwFZImJuukaDrvn6ZN45+uNy8qmZvWIsZ8IHHvfJvkfiM0k1e VL6y6BCSrW1xOWGJDk0ttqV8NqH/1+mmPltSaZrnQ5hOasrMpT3AaTO28 M=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0AHAAB8Vb9b/40NJK1ZCRkBAQEBAQEBAQEBAQEHAQEBAQEBgVMCAQEBAQELAYFZKoFlKAqaRJcAFIFmCwEBhGwChFUhNgsNAQMBAQIBAQJtKIU5AQEBAQIBOj0CBQsCAQgOBwMNERAyJQIEDgUIgk1LgXoIp0qJWYtFF4FBP4ESgxKESwEICgEJhW4ClCaJagkCkEofkBGVawIRFIElJAsmZHFwFYMnkFVviiOBH4EfAQE
X-IronPort-AV: E=Sophos;i="5.54,368,1534809600"; d="scan'208";a="184073490"
Received: from alln-core-8.cisco.com ([173.36.13.141]) by alln-iport-8.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Oct 2018 13:54:49 +0000
Received: from XCH-RTP-015.cisco.com (xch-rtp-015.cisco.com [64.101.220.155]) by alln-core-8.cisco.com (8.15.2/8.15.2) with ESMTPS id w9BDsnRf019906 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Thu, 11 Oct 2018 13:54:49 GMT
Received: from xch-rtp-013.cisco.com (64.101.220.153) by XCH-RTP-015.cisco.com (64.101.220.155) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 11 Oct 2018 09:54:48 -0400
Received: from xch-rtp-013.cisco.com ([64.101.220.153]) by XCH-RTP-013.cisco.com ([64.101.220.153]) with mapi id 15.00.1395.000; Thu, 11 Oct 2018 09:54:48 -0400
From: "Eric Voit (evoit)" <evoit@cisco.com>
To: Martin Bjorklund <mbj@tail-f.com>
CC: "netconf@ietf.org" <netconf@ietf.org>
Thread-Topic: [Netconf] WGLC on netconf-event-notifications-13
Thread-Index: AQHUYHm1PmFXMfKNSkqeZJpjJKWPMKUYhW+wgAFj44CAABUqwA==
Date: Thu, 11 Oct 2018 13:54:48 +0000
Message-ID: <02b883052761429dac02eb99a36c426b@XCH-RTP-013.cisco.com>
References: <C25DFAF6-04FC-44B4-B714-D6CE4E4EFF8C@juniper.net> <20181010.111455.977252154629241283.mbj@tail-f.com> <c8115971cd7c42909dba9946ef56ebcf@XCH-RTP-013.cisco.com> <20181011.092539.1869235859078328014.mbj@tail-f.com>
In-Reply-To: <20181011.092539.1869235859078328014.mbj@tail-f.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.118.56.234]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Outbound-SMTP-Client: 64.101.220.155, xch-rtp-015.cisco.com
X-Outbound-Node: alln-core-8.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/netconf/7kUCu4_fhb8YpXvve3mrP9Q2rIY>
Subject: Re: [Netconf] WGLC on netconf-event-notifications-13
X-BeenThere: netconf@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Network Configuration WG mailing list <netconf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netconf>, <mailto:netconf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netconf/>
List-Post: <mailto:netconf@ietf.org>
List-Help: <mailto:netconf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netconf>, <mailto:netconf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Oct 2018 13:54:54 -0000

Hi Martin,

> From: Martin Bjorklund, October 11, 2018 3:26 AM
> 
> Hi,
> 
> Thanks for fixing these issues.  Two comments, trimming:
> 
> 
> "Eric Voit (evoit)" <evoit@cisco.com> wrote:
> > Thanks very much Martin.   Changes made as described in-line.
> >
> > > From: Martin Bjorklund, October 10, 2018 5:15 AM
> 
> [...]
> 
> > > But this illustrates a problem with SN; the "transport" leaf is
> > > mandatory if the feature "configured" is supported.  The problem is
> > > that just b/c a server supports the "configured" feature, it doesn't
> > > mean that there is an identity defined for all transports; e.g.,
> > > there is no identity defined for NETCONF.  So the leaf "transport"
> > > should probably not be mandatory.
> >
> > Made optional within the SN grouping "subscription-policy", and
> > tweaked the definition as follows:
> >
> >     leaf transport {
> >       if-feature "configured";
> >       type transport;
> >       description
> >         "For a configured subscription, this leaf specifies the
> >         transport used to deliver messages destined to all receivers
> >         of that subscription.";
> >     }
> 
> Is the intention that this leaf is not present in the operational state for dynamic
> subscriptions?  If so, I think this should be explicitly stated.

That was the intent with the subsequent part of the earlier email.   To improve things, I have added the sentence: 
  "The object should not be present for dynamic subscriptions"
to the text.   Now the leaf:

  +--rw subscriptions
     +--rw subscription* [id]
        +--rw transport             

Is defined as:

        refine "transport" {
          description
            "For a configured subscription, this leaf specifies the 
            transport used to deliver messages destined to all  
            receivers of that subscription.  This object is mandatory
            for subscriptions in the configuration datastore.  The 
            object should not be present for dynamic subscriptions."
        }


> [...]
> 
> > > o  Spelling of XPath
> > >
> > >   s/xpath filter/XPath filter/  (a couple of places)
> >
> > Found one.  Fixed.
> 
> In A.2.2:
> 
>    seen, the modifications being attempted are the application of a new
>    xpath filter as well as the setting of a new periodic time interval.
> 
> In A.4:
> 
>    For more examples of xpath filters, see [XPATH].

Fixed this one too.

Eric  

> 
> /martin