Re: [netconf] get-data origin filters
Andy Bierman <andy@yumaworks.com> Mon, 07 October 2019 14:11 UTC
Return-Path: <andy@yumaworks.com>
X-Original-To: netconf@ietfa.amsl.com
Delivered-To: netconf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 01016120020 for <netconf@ietfa.amsl.com>; Mon, 7 Oct 2019 07:11:53 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.889
X-Spam-Level:
X-Spam-Status: No, score=-1.889 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_FILL_THIS_FORM_SHORT=0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=yumaworks-com.20150623.gappssmtp.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vQfDEDl8hc5s for <netconf@ietfa.amsl.com>; Mon, 7 Oct 2019 07:11:51 -0700 (PDT)
Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6A908120013 for <netconf@ietf.org>; Mon, 7 Oct 2019 07:11:50 -0700 (PDT)
Received: by mail-lj1-x22a.google.com with SMTP id m13so13793122ljj.11 for <netconf@ietf.org>; Mon, 07 Oct 2019 07:11:50 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yumaworks-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0xyh5trcVYnO3wupgUkMlQ227DY/VYnhYJzXEAA3AdA=; b=dNTbVQrEe1963WCjZTryY49qU4UN75rXESCa5Ttsc0P+qU73LA3oSe9RaKFeBdL5JA ZFKPjI687ymGwDeDYmf74ZyPGoUxNqEQs+E3CyGgRbb6mgiNtPnbTxxrNukpDLbOAaX4 bNvcn5ACH9MI3E++bvVl5ltwSFPhm30xfs2wPAJQgzOag1KwX3dkJFO57cgbwlqA9K/6 otrI2ki8RQE/g/ywfH3Z7SgKU/yrjOHr8f2DMwLQW+G7lol3oXpS7Fd4/bSTLt9q1ef6 H1cQvoTpSSA21lrkhrCi5RDz8JlvsySFIsDG1Ib9P9Ed2uug6VfNF54Tt4FMKNRnJo2n tJFQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0xyh5trcVYnO3wupgUkMlQ227DY/VYnhYJzXEAA3AdA=; b=X1c+Gf2JtolqoXPGXJDro1qmm39DGaAbhP4wuZSeC89WUc3kStVN4DLyVPWg0Paq65 Tyj8wsqslXc6svtzbqxLROhIxpQVZXM2OviNldz8sgsIWxKnFV50J20zk0xAI/wQ074R yXvO6q1+kUBK+Veg1sofPBSZvfpDdQuS9gn9bKdddeOoa54Z8oA+iskl2CJkmiUsA5iv sZa3Pht0gWWMepnlN1YJ/G7X8yDRLDQZ9a1Is1AAOXt5nJ9wAIZHVaM+nl2ixW8/NQYK uc2Qnme23PqlNzW2vGZD6xkDNAvnQ2XBHbcKmNFlz27BxGhijEidgqLN9hWLfIAW5gmP 9bCg==
X-Gm-Message-State: APjAAAXkHEW+XGHjpmbliYxryAIB0pjtDiXgj68XYVZ4i1nw1SwCIYfD j0ZHznRCfaOW2wVqHJl7Evu/aGeQLzdiHvw5TO/E1WLu
X-Google-Smtp-Source: APXvYqyveSgOm0gYjXPAophvVy0Y5YnWoTtmIaJh0J3v2gW9+mOiR2awPj28D32AUB4A3eeVb2VGbKHLFbJ7LHFUzjs=
X-Received: by 2002:a2e:9d50:: with SMTP id y16mr9468564ljj.70.1570457508444; Mon, 07 Oct 2019 07:11:48 -0700 (PDT)
MIME-Version: 1.0
References: <CABCOCHSM0XO2tRDw44=jp3eaBxnhJciWOVvp8QJ+SgACjRZkEg@mail.gmail.com> <20191006.173256.1788347482117819951.mbj@tail-f.com> <CABCOCHRQDfprmHoMBBWK36DZH6-QQS1SkPu+V805XN3dBHW_FQ@mail.gmail.com> <20191007.094327.1923088106819713441.mbj@tail-f.com>
In-Reply-To: <20191007.094327.1923088106819713441.mbj@tail-f.com>
From: Andy Bierman <andy@yumaworks.com>
Date: Mon, 07 Oct 2019 07:11:37 -0700
Message-ID: <CABCOCHSMRrL4VR7eR8sQCtMnmg5=EE0d8g37Vr956vkUtVTBQA@mail.gmail.com>
To: Martin Bjorklund <mbj@tail-f.com>
Cc: Netconf <netconf@ietf.org>
Content-Type: multipart/alternative; boundary="000000000000ed0f1f059452a10e"
Archived-At: <https://mailarchive.ietf.org/arch/msg/netconf/8WQWpzV-L5qCQTG9bMxa0Jll77A>
Subject: Re: [netconf] get-data origin filters
X-BeenThere: netconf@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NETCONF WG list <netconf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netconf>, <mailto:netconf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netconf/>
List-Post: <mailto:netconf@ietf.org>
List-Help: <mailto:netconf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netconf>, <mailto:netconf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Oct 2019 14:11:53 -0000
On Mon, Oct 7, 2019 at 12:43 AM Martin Bjorklund <mbj@tail-f.com> wrote: > Andy Bierman <andy@yumaworks.com> wrote: > > On Sun, Oct 6, 2019 at 8:32 AM Martin Bjorklund <mbj@tail-f.com> wrote: > > > > > Hi, > > > > > > Andy Bierman <andy@yumaworks.com> wrote: > > > > Hi, > > > > > > > > I am trying to figure out how to use the origin-filter and > > > > negated-origin-filter > > > > in the <get-data> operation in RFC 8526. > > > > > > > > > > > > leaf-list origin-filter { > > > > type or:origin-ref; > > > > description > > > > "Filter based on the 'origin' annotation. A > > > > configuration node matches the filter if its 'origin' > > > > annotation is derived from or equal to any of the > given > > > > filter values."; > > > > } > > > > > > > > > > > > These filters seem kind of worthless if implemented according to the > > > text. > > > > Consider a simple example where there is 1 learned leaf within a > list: > > > > > > > > module: address > > > > +--rw addresses > > > > +--rw address* [last-name first-name] > > > > +--rw last-name string > > > > +--rw first-name string > > > > +--rw street? string > > > > +--rw city? string > > > > +--rw zipcode? string > > > > +--rw phone* [phone-type] > > > > +--rw phone-type enumeration > > > > +--rw phone-number string > > > > > > > > Let's say the "zipcode" field is learned in <operational> > > > > (e.g. ZIP code lookup expands missing or 5 digit zipcode to full 9 > digit > > > > zipcode). > > > > So /addresses and /addresses/address have origin "intended". > > > > Only the /addresses/address/zipcode leaf has origin "learned". > > > > > > > > So how does origin-filter=learned find all the learned leafs? > > > > > > Perhaps I don't understand your question; IMO you give the answer to > > > this question below: > > > > > > > What filters are required to return only the learned entries + > ancestors > > > + > > > > ancestor-or-self keys? Seems like this filter mechanism has to be > used > > > > to retrieve the exact leaf that might be learned, and the client > > > > needs to know in advance all the possible nodes that might be > learned. > > > > > > > > Want to be able to retrieve an ancestor that is intended and still > find > > > the > > > > learned entries > > > > > > > > get-data xpath-filter=/addresses/address origin-filtter=learned > > > > > > ... here. So this request will return: > > > > > > <addresses or:origin="or:intended"> > > > <address> > > > <last-name>...</last-name> > > > <first-name>...</first-name> > > > <zipcode or:origin="or:learned">...</zipcode> > > > </address> > > > ... > > > </addresses> > > > > > > > > I do not interpret the text the same way as you. > > Does this mean that you think that the reply is different from what I > show above? If so, what would it be, and why? > > > Explain how the list address node has origin "learned". The filter is for /addresses/address and only origin=learned. How does the list node have origin=learned? It can only have 1 value. It has child nodes with both intended and learned as origin. I do no understand how the origin=learned matched this node. > > > > The content returned > > > > by get-data must satisfy all filters, i.e., the filter > > criteria are logically ANDed. > > > > > > leaf-list origin-filter { > > type or:origin-ref; > > description > > "Filter based on the 'origin' annotation. A > > configuration node matches the filter if its 'origin' > > annotation is derived from or equal to any of the given > > filter values."; > > } > > > > > > Configuration nodes that do not have an > > 'origin' annotation are treated as if they have the > > 'origin' annotation 'or:unknown'. > > > > > > > > > The draft shows an example where both "intended" and "system" are given > > > > as filters. This will work but will include all the "intended" > leafs as > > > > well. > > > > What if a "learned" node is within a "system" node within an > "intended" > > > > node? > > > > > > This works as well. Note that the get-data description says: > > > > > > Any ancestor nodes (including list keys) of nodes selected by > > > the filters are included in the response. > > > > > > > > > > > > > The issue is how the /iaddresses and /addresses/address nodes match the > > origin "learned". > > They don't, but they are included b/c of the quoted text above (i.e.: > Any ancestor nodes (including list keys) of nodes selected by > the filters are included in the response.) > > No. If the filter was for /addresses/address/zipcode then maybe that text applies. It is still unclear that the XPath is fully processed and then the origin-filter is processed. The RFC just says they are ANDed together. > > > The leafs in list "address" are a mixture of "intended" and "learned" > > origin. > > The text clearly says that a node has a single origin property, coupled > to > > the annotation. > > > > Issue 1: mixed origin descendant nodes > > So how does a search on /addresses/address match origin-filter=learned? > > I cannot find any text that says what the origin of a list or P-container > > is if it > > contains nodes of mixed origin. > > See above. > No text above explains how the list origin is tagged if it has multiple types of child nodes. > > > Issue 2: NP-containers > > > > Also from RFC 8342: > > > > The origin applies to all configuration nodes except non-presence > > containers. > > > > > > What if the top-level node is an NP-container in this case. > > I thought the top-level node MUST have an origin attribute. > > > > The text is not clear how NP-containers are handled. > > Do they have an origin attribute? If not then RFC 8526 says they have > > origin "unknown". > > Is the intent that NP-containers always pass the origin-filter tests > (test > > skipped)? > > No, since they don't have an origin value they will not be selected by > the filter. But an NP-container will be included in the reply if it > is the ancestor of a node that is selected by the filter. > > The RFC text does not really say that. Since it is very difficult to know if a data node 5 layers deep is going to match, implementing these filters according to this vague interpretation is unlikely. > > /martin > > Andy > > > > > > > > > > /martin > > > > > > > > Andy > > > > > > > > > > > Seems like the client needs to know a lot about the server > implementation > > > > details > > > > in order to use the origin filters. > > > > > > > > > > > > Andy > > > >
- [netconf] get-data origin filters Andy Bierman
- Re: [netconf] get-data origin filters Martin Bjorklund
- Re: [netconf] get-data origin filters Andy Bierman
- Re: [netconf] get-data origin filters Martin Bjorklund
- Re: [netconf] get-data origin filters Andy Bierman
- Re: [netconf] get-data origin filters Rob Wilton (rwilton)
- Re: [netconf] get-data origin filters Andy Bierman
- Re: [netconf] get-data origin filters Rob Wilton (rwilton)
- Re: [netconf] get-data origin filters Andy Bierman
- Re: [netconf] get-data origin filters Martin Bjorklund
- Re: [netconf] get-data origin filters Andy Bierman
- Re: [netconf] get-data origin filters Martin Bjorklund