[netconf] Yangdoctors last call review of draft-ietf-netconf-https-notif-06

Acee Lindem via Datatracker <noreply@ietf.org> Wed, 27 January 2021 17:01 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: netconf@ietf.org
Delivered-To: netconf@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 84A6F3A0C8A; Wed, 27 Jan 2021 09:01:50 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Acee Lindem via Datatracker <noreply@ietf.org>
To: <yang-doctors@ietf.org>
Cc: draft-ietf-netconf-https-notif.all@ietf.org, last-call@ietf.org, netconf@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 7.24.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <161176691048.5494.2373231790931856179@ietfa.amsl.com>
Reply-To: Acee Lindem <acee@cisco.com>
Date: Wed, 27 Jan 2021 09:01:50 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/netconf/9dpwQHFIwhpPQxdKNLfLKOSNerE>
Subject: [netconf] Yangdoctors last call review of draft-ietf-netconf-https-notif-06
X-BeenThere: netconf@ietf.org
X-Mailman-Version: 2.1.29
List-Id: NETCONF WG list <netconf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netconf>, <mailto:netconf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netconf/>
List-Post: <mailto:netconf@ietf.org>
List-Help: <mailto:netconf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netconf>, <mailto:netconf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 27 Jan 2021 17:01:51 -0000

Reviewer: Acee Lindem
Review result: Almost Ready

The document is almost ready for WG Last Call. I have the following comments:

Model ietf-sub-notif-recv-list:

    Seems odd to have a model that adds a choice statement without any
    valid options. I realize you expect other transports in the future but
    having a separate module the one defined in the same draft seems like a
    profligate design choice.

Model ietf-sub-notif-recv-list:
    1. The prefix "hn" seems inconsistent to lose the context. I'd use
        "snrlhn".  This wouldn't be an issue if you combined the modules.
    2. This comment is incomprehensible:

               // create the logical impossibility of enabling "tcp"
               // transport

In the IANA section, the security considerations for the media types
point to this draft's security considerations. However, they don't
include the referenced information. It seems these IANA references
should point to other RFCs.

It should be noted that ietf-subscribed-notifications has a number of YANG
errors and warnings.

I also have the following editorial comments:
Acee-Lindems-iMac-2:Desktop acee$ diff -c
draft-ietf-netconf-https-notif-06.txt.orig
draft-ietf-netconf-https-notif-06.txt ***
draft-ietf-netconf-https-notif-06.txt.orig  2021-01-27 10:06:29.000000000 -0500
--- draft-ietf-netconf-https-notif-06.txt       2021-01-27 11:57:13.000000000
-0500
***************
*** 17,23 ****
     This document defines a YANG data module for configuring HTTPS based
     configured subscription, as defined in RFC 8639.  The use of HTTPS
     maximizes transport-level interoperability, while allowing for
!    encoding selection from text, e.g.  XML or JSON, to binary.

  Status of This Memo

--- 17,23 ----
     This document defines a YANG data module for configuring HTTPS based
     configured subscription, as defined in RFC 8639.  The use of HTTPS
     maximizes transport-level interoperability, while allowing for
!    encoding selection from text, e.g.,  XML or JSON, to binary.

  Status of This Memo

***************
*** 103,109 ****
     documents.  This document defines two YANG 1.1 [RFC7950] data
     modules, one for augmenting the Subscription to YANG Notifications
     [RFC8639] to add a transport type, and another for configuring and
!    managing HTTPS based receivers for the notifications.

--- 103,109 ----
     documents.  This document defines two YANG 1.1 [RFC7950] data
     modules, one for augmenting the Subscription to YANG Notifications
     [RFC8639] to add a transport type, and another for configuring and
!    managing HTTPS-based receivers for the notifications.

***************
*** 118,124 ****
     the same receiver instance.  The second module describes how to
     enable the transmission of YANG modeled notifications, in the
     configured encoding (i.e., XML, JSON) over HTTPS.  Notifications are
!    delivered in the form of a HTTPS POST.  The use of HTTPS maximizes
     transport-level interoperability, while the encoding selection pivots
     between implementation simplicity (XML, JSON) and throughput (text
     versus binary).
--- 118,124 ----
     the same receiver instance.  The second module describes how to
     enable the transmission of YANG modeled notifications, in the
     configured encoding (i.e., XML, JSON) over HTTPS.  Notifications are
!    delivered in the form of an HTTPS POST.  The use of HTTPS maximizes
     transport-level interoperability, while the encoding selection pivots
     between implementation simplicity (XML, JSON) and throughput (text
     versus binary).
***************
*** 196,202 ****

     In the case of "pipelining", the flow of messages would look
     something like this.  This example shows the flow assuming that
!    Subscribed Notifications is used and therefore a <subscription-
     started> notification is sent before sending the first notification.
     The example would be the same for when Subscribed Notification is not
     used by removing the first POST message for <susbscription-started>.
--- 196,202 ----

     In the case of "pipelining", the flow of messages would look
     something like this.  This example shows the flow assuming that
!    Subscribed Notification is used and therefore a <subscription-
     started> notification is sent before sending the first notification.
     The example would be the same for when Subscribed Notification is not
     used by removing the first POST message for <susbscription-started>.
***************
*** 342,350 ****

  2.1.  Introduction

!    To learn the capabilities of the receiver, the publisher can issue a
     HTTPS GET request with Accept-Type set to application/ietf-https-
!    notif-cap+xml or application/ietf-https-notif-cap+json, with latter
     as the mandatory to implement, and the default in case the type is
     not specified.  If the receiver supports capabilities such as binary
     encoding of data, it can return that as a capability in a response.
--- 342,350 ----

  2.1.  Introduction

!    To learn the capabilities of the receiver, the publisher can issue an
     HTTPS GET request with Accept-Type set to application/ietf-https-
!    notif-cap+xml or application/ietf-https-notif-cap+json, with the latter
     as the mandatory to implement, and the default in case the type is
     not specified.  If the receiver supports capabilities such as binary
     encoding of data, it can return that as a capability in a response.
***************
*** 450,456 ****
  Internet-Draft        HTTPS Configured Subscription        November 2020

!      Copyright (c) 2018 IETF Trust and the persons identified as
       the document authors.  All rights reserved.
       Redistribution and use in source and binary forms, with or
       without modification, is permitted pursuant to, and subject
--- 450,456 ----
  Internet-Draft        HTTPS Configured Subscription        November 2020

!      Copyright (c) 2021 IETF Trust and the persons identified as
       the document authors.  All rights reserved.
       Redistribution and use in source and binary forms, with or
       without modification, is permitted pursuant to, and subject
***************
*** 536,545 ****

     This YANG module is a definition of a set of receivers that are
     interested in the notifications published by the publisher.  The
!    module contains the TCP, TLS and HTTPS parameters that are needed to
     communicate with the receiver.  The module augments the ietf-sub-
     notif-recv-list module to define a transport specific receiver.  As
!    mentioned earlier, it uses POST method to deliver the notification.
     The attribute 'path' defines the path for the resource on the
     receiver, as defined by 'path-absolute' in URI Generic Syntax
     [RFC3986].  The user-id used by Network Configuration Access Control
--- 536,545 ----

     This YANG module is a definition of a set of receivers that are
     interested in the notifications published by the publisher.  The
!    module contains the TCP, TLS, and HTTPS parameters that are needed to
     communicate with the receiver.  The module augments the ietf-sub-
     notif-recv-list module to define a transport specific receiver.  As
!    mentioned earlier, it uses the POST method to deliver the notification.
     The attribute 'path' defines the path for the resource on the
     receiver, as defined by 'path-absolute' in URI Generic Syntax
     [RFC3986].  The user-id used by Network Configuration Access Control
***************
*** 639,645 ****
       description
         "YANG module for configuring HTTPS base configuration.

!         Copyright (c) 2018 IETF Trust and the persons identified as
          the document authors.  All rights reserved.
          Redistribution and use in source and binary forms, with or
          without modification, is permitted pursuant to, and subject
--- 639,645 ----
       description
         "YANG module for configuring HTTPS base configuration.

!         Copyright (c) 2021 IETF Trust and the persons identified as
          the document authors.  All rights reserved.
          Redistribution and use in source and binary forms, with or
          without modification, is permitted pursuant to, and subject
***************
*** 704,710 ****

             container receiver-identity {
               description
!                "Specifies mechanism for identifying the receiver.
                  The publisher MUST NOT include any content in a
                  notification that the user is not authorized to view.";

--- 704,710 ----

             container receiver-identity {
               description
!                "Specifies the mechanism for identifying the receiver.
                  The publisher MUST NOT include any content in a
                  notification that the user is not authorized to view.";

***************
*** 791,801 ****

  6.  Receiving Event Notifications

!    Encoding notifications for the HTTPS notifications is the same as the
     encoding notifications as defined in RESTCONF [RFC8040] Section 6.4,
     with the following changes.  Instead of saying that for JSON-encoding
     purposes, the module name for "notification" element will be "ietf-
!    restconf, it will say that for JSON-encoding purposes, the module
     name for "notification" element will be "ietf-https-notif".

     With those changes, the SSE event notification encoded JSON example
--- 791,801 ----

  6.  Receiving Event Notifications

!    Encoding notifications for the HTTPS notifications is the same as for
     encoding notifications as defined in RESTCONF [RFC8040] Section 6.4,
     with the following changes.  Instead of saying that for JSON-encoding
     purposes, the module name for "notification" element will be "ietf-
!    restconf", it will say that for JSON-encoding purposes, the module
     name for "notification" element will be "ietf-https-notif".

     With those changes, the SSE event notification encoded JSON example
***************
*** 815,826 ****

  7.  IANA Considerations

!    This document registers two URI, two YANG module and two Media Types.

  7.1.  URI Registration

     in the IETF XML registry [RFC3688].  Following the format in RFC
!    3688, the following registration is requested to be made:

     URI: urn:ietf:params:xml:ns:yang:ietf-http-notif
     URI: urn:ietf:params:xml:ns:yang:ietf-sub-notif-recv-list
--- 815,826 ----

  7.  IANA Considerations

!    This document registers two URIs, two YANG modules, and two Media Types.

  7.1.  URI Registration

     in the IETF XML registry [RFC3688].  Following the format in RFC
!    3688, the following registrations are requested to be made:

     URI: urn:ietf:params:xml:ns:yang:ietf-http-notif
     URI: urn:ietf:params:xml:ns:yang:ietf-sub-notif-recv-list
***************
*** 854,860 ****

  7.3.  Media Types

! 7.3.1.  Media Type "application/ietf-https-notif-cap+xml

  Type name: application

--- 854,860 ----

  7.3.  Media Types

! 7.3.1.  Media Type "application/ietf-https-notif-cap+xml"

  Type name: application

***************
*** 917,923 ****

  Provisional registration? (standards tree only): no

! 7.3.2.  Media Type "application/ietf-https-notif-cap+json

  Type name: application

--- 917,923 ----

  Provisional registration? (standards tree only): no

! 7.3.2.  Media Type "application/ietf-https-notif-cap+json"

  Type name: application

***************
*** 1106,1112 ****
  </config>

! 8.2.  Non Subscribed Notification based Configuration

     In the case that it is desired to use HTTPS notif outside of
     Subscribed Notifications, there would have to be a module to define
--- 1106,1112 ----
  </config>

! 8.2.  Non-Subscribed Notification based Configuration

     In the case that it is desired to use HTTPS notif outside of
     Subscribed Notifications, there would have to be a module to define

Thanks,
Acee