Re: [netconf] Benjamin Kaduk's No Objection on draft-ietf-netconf-netconf-event-notifications-20: (with COMMENT)

Randy Presuhn <randy_presuhn@alumni.stanford.edu> Thu, 16 May 2019 02:10 UTC

Return-Path: <randy_presuhn@alumni.stanford.edu>
X-Original-To: netconf@ietfa.amsl.com
Delivered-To: netconf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 839881200F4 for <netconf@ietfa.amsl.com>; Wed, 15 May 2019 19:10:04 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.901
X-Spam-Level:
X-Spam-Status: No, score=-1.901 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=unavailable autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ttX9z96V5RLM for <netconf@ietfa.amsl.com>; Wed, 15 May 2019 19:10:01 -0700 (PDT)
Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8E9D412010E for <netconf@ietf.org>; Wed, 15 May 2019 19:10:01 -0700 (PDT)
Received: by mail-pl1-f176.google.com with SMTP id f12so775883plt.8 for <netconf@ietf.org>; Wed, 15 May 2019 19:10:01 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ETolUwGDX9BkppTFXX+43CUMGe0zXp/eGnfbsdhc36c=; b=RnXXwDyoTqzpC2EOksnqst8HG/PyJ4BxMdb4QJ4E9Qtx+2cqjT4iwopBaWWO5K8Ih/ qdJvUQxbf07PHnv3cw975toMtTaqB7tRocgTOfay1bl9VMUShISxKomiyDbyKGe7KL/l K14ELy8mXpTQDDA4ejE8K3qUXnpnwxozd90S1068uZf+ZEcA4Imb/H69NFpzyIk0CHjJ t2f43da4Rt5LREklZlYwdpQVhgrX/m8HV1XecmmADYYV31SD0w/qjtw1Hb1P5r/Vqf7p 3wvq5I8gEvlNrNa/ddmpUZNvRWG+0sYmwZzKXfIDSRbb3xN2HtX7my1n+74fQWLaXW0M AY9A==
X-Gm-Message-State: APjAAAUdD7zmLhCR/vXinUe5cwgaMQcD6rxETNu40YuMotOQJaXL3J5/ j+N5x8YrmulNyHWdlys6afJFJw==
X-Google-Smtp-Source: APXvYqzea4f+S8WuMrhesGMx5AtFQNbQEuimo7msNdMk8YAi4A2QGQUosWvUVtK4+6099Q6i044A5Q==
X-Received: by 2002:a17:902:4a:: with SMTP id 68mr48186153pla.235.1557972600383; Wed, 15 May 2019 19:10:00 -0700 (PDT)
Received: from [192.168.1.102] (c-69-181-241-121.hsd1.ca.comcast.net. [69.181.241.121]) by smtp.gmail.com with ESMTPSA id x16sm4127317pff.30.2019.05.15.19.09.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 May 2019 19:09:59 -0700 (PDT)
To: "Eric Voit (evoit)" <evoit@cisco.com>, Benjamin Kaduk <kaduk@mit.edu>, The IESG <iesg@ietf.org>
Cc: "netconf@ietf.org" <netconf@ietf.org>, "draft-ietf-netconf-netconf-event-notifications@ietf.org" <draft-ietf-netconf-netconf-event-notifications@ietf.org>, "netconf-chairs@ietf.org" <netconf-chairs@ietf.org>
References: <155794345628.30726.16513916652364715189.idtracker@ietfa.amsl.com> <17b8294694a446679f786fee28e4e206@XCH-RTP-013.cisco.com>
From: Randy Presuhn <randy_presuhn@alumni.stanford.edu>
Message-ID: <8a904fce-ff70-2e62-9fde-850cce607ffc@alumni.stanford.edu>
Date: Wed, 15 May 2019 19:09:58 -0700
User-Agent: Mozilla/5.0 (Windows NT 6.0; rv:52.0) Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <17b8294694a446679f786fee28e4e206@XCH-RTP-013.cisco.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/netconf/9uvaGNY5u7aEop8NIxdgc7pTUiU>
Subject: Re: [netconf] Benjamin Kaduk's No Objection on draft-ietf-netconf-netconf-event-notifications-20: (with COMMENT)
X-BeenThere: netconf@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NETCONF WG list <netconf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netconf>, <mailto:netconf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netconf/>
List-Post: <mailto:netconf@ietf.org>
List-Help: <mailto:netconf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netconf>, <mailto:netconf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 16 May 2019 02:10:05 -0000

Hi -

On 5/15/2019 12:01 PM, Eric Voit (evoit) wrote:
...
>> From: Benjamin Kaduk, May 15, 2019 2:04 PM
...
>> Section 6
>>
>>     Notification messages transported over the NETCONF protocol MUST be
>>     encoded in a <notification> message as defined within [RFC5277],
>>     Section 4.  And per [RFC5277]'s "eventTime" object definition, the
>>     "eventTime" populated with the event occurrence time.
>>
>> nit: I think the last sentence is actually a sentence fragment.
> 
> This reads fine with me.  Several on-line grammar checks give it a pass, but I am not sure how much I trust those tools.  So I will leave as is.

No, it really is a fragment.  Not only does it begin with a conjunction,
but it lacks a verb. If it were joined to the previous sentence, one
might infer a "MUST be" before "populated", but as a separate sentence
it no longer supports that interpretation.  If "MUST be populated" isn't
the intended interpretation here, then it's even more important to
turn that fragment into a real sentence.

Randy