Re: [Netconf] Editorial change-2 for draft-ietf-netconf-nmda-netconf
Robert Wilton <rwilton@cisco.com> Mon, 04 June 2018 11:01 UTC
Return-Path: <rwilton@cisco.com>
X-Original-To: netconf@ietfa.amsl.com
Delivered-To: netconf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C0B65126CD6; Mon, 4 Jun 2018 04:01:55 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.511
X-Spam-Level:
X-Spam-Status: No, score=-14.511 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aTZkF_vCB_rZ; Mon, 4 Jun 2018 04:01:53 -0700 (PDT)
Received: from aer-iport-3.cisco.com (aer-iport-3.cisco.com [173.38.203.53]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9172C126C89; Mon, 4 Jun 2018 04:01:52 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=7410; q=dns/txt; s=iport; t=1528110112; x=1529319712; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=zVLraX2caGb+DiCuh8NBM5L5AaxvuIKoGn+ICn5zR4g=; b=kqYXV4C0L4nlakGKDW2/QtAtb4vkDCcjOFFkzQbEY1O2w//hjinCglbE mrBw3yI6l/nseUyJUJHpSpmrmz9/Pl4Q4UUjIGzYL+k8hWU4fsnbbrhEI IrBkQEW1SItqFRftlc/RQLCBqQ/kVonR+TwxQEJoTovOf2pwkuJT/gxUY U=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0B7AQD1GhVb/xbLJq1cGQEBAQEBAQEBAQEBAQcBAQEBAYQlbRIog3iIY41fCCGUS4F4CxgLhANGAoIwNhYBAgEBAQEBAQJsHAyFKQEBBAEBIQ8BBTYGBRAJAg4KAgImAgInMAYNBgIBAYMeAoF/D4pDm0eCHIRYg2eBaIELiQs/gQ8kDIJdgxEBAYE6EIMWglQChyaFCIxACYVsiHEGgTyGOCOFA4trhTSBSAongVIzGggbFTuCQwmCFxeIWYU/PjCMVIJGAQE
X-IronPort-AV: E=Sophos;i="5.49,476,1520899200"; d="scan'208";a="4250201"
Received: from aer-iport-nat.cisco.com (HELO aer-core-1.cisco.com) ([173.38.203.22]) by aer-iport-3.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Jun 2018 11:01:50 +0000
Received: from [10.63.23.83] (dhcp-ensft1-uk-vla370-10-63-23-83.cisco.com [10.63.23.83]) by aer-core-1.cisco.com (8.14.5/8.14.5) with ESMTP id w54B1oxb027572; Mon, 4 Jun 2018 11:01:50 GMT
To: Martin Bjorklund <mbj@tail-f.com>
Cc: rohitrranade@huawei.com, netconf@ietf.org, draft-ietf-netconf-nmda-netconf@ietf.org
References: <991B70D8B4112A4699D5C00DDBBF878A6BBB4569@dggeml510-mbx.china.huawei.com> <a497b165-1f78-2d2f-9563-01fbb39619df@cisco.com> <20180604.121748.1873023460220711310.mbj@tail-f.com>
From: Robert Wilton <rwilton@cisco.com>
Message-ID: <224028b2-59c5-6859-0e2a-331ed48121ec@cisco.com>
Date: Mon, 04 Jun 2018 12:01:50 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <20180604.121748.1873023460220711310.mbj@tail-f.com>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Archived-At: <https://mailarchive.ietf.org/arch/msg/netconf/EIkXbFI27ujnU-JQXZFaCOx_l9E>
Subject: Re: [Netconf] Editorial change-2 for draft-ietf-netconf-nmda-netconf
X-BeenThere: netconf@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Network Configuration WG mailing list <netconf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netconf>, <mailto:netconf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netconf/>
List-Post: <mailto:netconf@ietf.org>
List-Help: <mailto:netconf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netconf>, <mailto:netconf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Jun 2018 11:01:56 -0000
On 04/06/2018 11:17, Martin Bjorklund wrote: > Hi > > Two comments inline. > > Robert Wilton <rwilton@cisco.com> wrote: >> Hi Rohit, authors, >> >> I think that these are valid clarifications. I've reworded them >> slightly, and moved the ancestor node text to the YANG module >> instead. I also think that the ancestor node text generically covers >> the config filter clarification that you raised previously. >> >> Hence, I propose the following diff to the NETCONF NMDA draft: >> >> rwilton@rwilton-lnx:~/netconf-wg/netconf-nmda$ git diff --staged >> diff --git a/ietf-netconf-nmda.yang b/ietf-netconf-nmda.yang >> index f2929b9..72a674a 100644 >> --- a/ietf-netconf-nmda.yang >> +++ b/ietf-netconf-nmda.yang >> @@ -105,6 +105,9 @@ module ietf-netconf-nmda { >> by get-data must satisfy all filters, i.e., the filter >> criteria are logically ANDed. >> >> + Any ancestor nodes (including list keys) of nodes matched by >> + the filter are included in the response. >> + >> The 'with-origin' parameter is only valid for an operational >> datastore. If 'with-origin' is used with an invalid datastore, >> then the server MUST return an <rpc-error> element with an >> @@ -193,7 +196,7 @@ module ietf-netconf-nmda { >> description >> "Filter based on the 'origin' annotation. A node matches >> the filter if its 'origin' annotation is not derived >> - from and not equal to all of the given filter values."; >> + from and not equal to any of the given filter values."; >> } >> } >> >> diff --git a/nmda-netconf.org b/nmda-netconf.org >> index e44e2c7..100e173 100644 >> --- a/nmda-netconf.org >> +++ b/nmda-netconf.org >> @@ -129,14 +129,17 @@ The "config-filter" parameter can be used to >> retrieve only "config >> true" or "config false" nodes. >> >> The "origin-filter" parameter, which can be present multiple times, >> -selects nodes matching any of the given values. The >> -"negated-origin-filter", which can be present multiple times, selects >> -nodes that do not match all given values. The "origin-filter" >> -and "negated-origin-filter" parameters cannot be used together. >> +selects nodes with origins matching, or derived from, any of the >> given > I would prefer: > > selects nodes with origins equal to, or derived from, any of the > given > > > IMO, the term "match" in the original text means "equal to or > derived-from", as explained in the data model. > > The term "match" is problematic unless it is explained, b/c some > people will think it means "equal to". (Noone will think that > "matches the regular expression" means "equal to the regular > expression" though...) > > Conclusion: always avoid the term "match". OK. > >> +values. The "negated-origin-filter", which can be present multiple >> +times, selects nodes with origins that do not match, and are not >> +derived from, any of the given values. The "origin-filter" and >> +"negated-origin-filter" parameters cannot be used together. >> >> The "max-depth" parameter can be used by the client to limit the >> number of sub-tree levels that are returned in the reply. >> >> Note to the authors, for the negative-origin-filter, I've also changed >> "all" to "any" (which changes the semantics, but I think it was wrong >> before). > Agree that "any" is correct. > > But does it really change the semantics? "all" sounds quite odd, but > isn't the end result the same? I think that it is confusing, and probably depends on how you read it. But, if you are OK with "any" then I think that reads better and is more intuitive. Thanks, Rob > > > /martin > > >> Similar updates will need to also be done to RESTCONF, but let's agree >> the NETCONF text first. >> >> Thanks, >> Rob >> >> >> On 01/06/2018 10:10, Rohit R Ranade wrote: >>> Hi All, >>> >>> Section 3.1.1 >>> >>> OLD: >>> >>> The "origin-filter" parameter, which can be present multiple times, >>> >>> selects nodes matching any of the given values. The >>> >>> "negated-origin-filter", which can be present multiple times, selects >>> >>> nodes that do not match all given values. >>> >>> NEW: >>> >>> The "origin-filter" parameter, which can be present multiple times, >>> >>> selects nodes which are derived from or matching any of the given >>> values. The >>> >>> "negated-origin-filter", which can be present multiple times, selects >>> >>> nodes which are not derived from and do not match all given values. >>> >>> When a data-node matching the filter is selected, the configuration >>> ancestors >>> >>> (if any) and list key leafs (if any), even if they do not match the >>> filter, are also returned. >>> >>> Consider two origins such as “learned” and “derived-from-learned”. >>> >>> “derived-from-learned” is derived from learned origin. >>> >>> Using the origin filters it is not possible to get nodes belonging to >>> “learned” >>> >>> only as the nodes of derived origin are automatically selected. >>> >>> Notes: >>> >>> The text in 3.1.1 did not include the “derived-from” logic for >>> selection , while in the data-model definition it was present. >>> >>> We can also add clarification about the ancestor and key being >>> output, even if though they do match the filter, since the leaf >>> >>> matches the filter. >>> >>> Example : We can use the RFC 8342 Appendix C.2 BGP Example >>> >>> <rpc message-id="101" >>> >>> xmlns="urn:ietf:params:xml:ns:netconf:base:1.0"> >>> >>> <get-data xmlns="urn:ietf:params:xml:ns:yang:ietf-netconf-nmda" >>> >>> xmlns:ds="urn:ietf:params:xml:ns:yang:ietf-datastores"> >>> >>> <datastore>ds:running</datastore> >>> >>> <subtree-filter> >>> >>> <bgp xmlns="urn:ietf:params:xml:ns:yang:ietf-netconf-nmda"/> >>> >>> </subtree-filter> >>> >>> <negated-origin-filter>intended</negated-origin-filter> >>> >>> <with-origin>true</with-origin> >>> >>> </get-data> >>> >>> </rpc> >>> >>> <rpc-reply message-id="101" >>> >>> xmlns="urn:ietf:params:xml:ns:netconf:base:1.0"> >>> >>> <data xmlns="urn:ietf:params:xml:ns:yang:ietf-netconf-nmda"> >>> >>> <bgp xmlns:or="urn:ietf:params:xml:ns:yang:ietf-origin" >>> >>> or:origin="or:intended"> >>> >>> <peer> >>> >>> <name>2001:db8::2:3</name> >>> >>> <local-as or:origin="or:default">64501</local-as> >>> >>> <peer-as or:origin="or:default">64502</peer-as> >>> >>> <local-port or:origin="or:system">60794</local-port> >>> >>> <remote-port or:origin="or:default">179</remote-port> >>> >>> <state>established</state> >>> >>> </peer> >>> >>> </bgp> >>> >>> </data> >>> >>> </rpc-reply> >>> >>> With Regards, >>> >>> Rohit R Ranade >>> >>> >>> >>> _______________________________________________ >>> Netconf mailing list >>> Netconf@ietf.org >>> https://www.ietf.org/mailman/listinfo/netconf
- Re: [Netconf] Editorial change-2 for draft-ietf-n… Mahesh Jethanandani
- Re: [Netconf] Editorial change-2 for draft-ietf-n… Juergen Schoenwaelder
- Re: [Netconf] Editorial change-2 for draft-ietf-n… Rohit R Ranade
- Re: [Netconf] Editorial change-2 for draft-ietf-n… Rohit R Ranade
- Re: [Netconf] Editorial change-2 for draft-ietf-n… Juergen Schoenwaelder
- Re: [Netconf] Editorial change-2 for draft-ietf-n… Kent Watsen
- Re: [Netconf] Editorial change-2 for draft-ietf-n… Mahesh Jethanandani
- Re: [Netconf] Editorial change-2 for draft-ietf-n… Juergen Schoenwaelder
- [Netconf] Editorial change-2 for draft-ietf-netco… Rohit R Ranade
- Re: [Netconf] Editorial change-2 for draft-ietf-n… Robert Wilton
- Re: [Netconf] Editorial change-2 for draft-ietf-n… Rohit R Ranade
- Re: [Netconf] Editorial change-2 for draft-ietf-n… Martin Bjorklund
- Re: [Netconf] Editorial change-2 for draft-ietf-n… Robert Wilton
- Re: [Netconf] Editorial change-2 for draft-ietf-n… Rohit R Ranade
- Re: [Netconf] Editorial change-2 for draft-ietf-n… Mahesh Jethanandani
- Re: [Netconf] Editorial change-2 for draft-ietf-n… Martin Bjorklund