Re: [netconf] RtgDir review: draft-ietf-netconf-netconf-event-notifications-17

"Eric Voit (evoit)" <evoit@cisco.com> Tue, 30 April 2019 17:44 UTC

Return-Path: <evoit@cisco.com>
X-Original-To: netconf@ietfa.amsl.com
Delivered-To: netconf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1671F120314; Tue, 30 Apr 2019 10:44:26 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.501
X-Spam-Level:
X-Spam-Status: No, score=-14.501 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id j3jZIMPVWcXz; Tue, 30 Apr 2019 10:44:22 -0700 (PDT)
Received: from rcdn-iport-9.cisco.com (rcdn-iport-9.cisco.com [173.37.86.80]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 415A81202F6; Tue, 30 Apr 2019 10:44:22 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=9398; q=dns/txt; s=iport; t=1556646262; x=1557855862; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=qNh+k1P0aFA46WUYnMovzj6H1R69v1ISdRMkRuJCYH0=; b=ewGhd2+TfZHWFVzcr0cXs+xfhOMloshK3VW4OdKF+T5TbNSdkv0d/aUJ LYQuOEiAPuIlvVZeR0XqAbF7pnhzakdM+PFrDYw20D48WIl6KvKfM3DLB lsFbjUoJUP6HZw8Zbq6AfGsYT/zQWgKp9gfc6IxKMK6ZBKZv6jQbQ2m2q 8=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0AcAADbiMhc/5pdJa1mGwEBAQEDAQE?= =?us-ascii?q?BBwMBAQGBUwQBAQELAYFmKmlUMCgKhAaVMJhQFIFnDgEBI4RKAheGGiM2Bw4?= =?us-ascii?q?BAwEBBAEBAgECbRwMhUoBAQEDASMRQwIFCwIBCBQBBQIJHQICAjAVEAIEAQ0?= =?us-ascii?q?Ngk9LAYF7Dw+vCoEvijSBCycBhGGGaBeBQD+BEYIUfj6CVgsCgUkvgnOCWAS?= =?us-ascii?q?KdhKCCyyMPo0HCQKCCYYVjB0jgg1fhVgFjGaDFoh4gR6FJYgQhX4CERWBMCY?= =?us-ascii?q?BMIFWcBWDJwmLCYU/QTEBAZMUgSEBAQ?=
X-IronPort-AV: E=Sophos;i="5.60,414,1549929600"; d="scan'208";a="467468326"
Received: from rcdn-core-3.cisco.com ([173.37.93.154]) by rcdn-iport-9.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 30 Apr 2019 17:44:20 +0000
Received: from XCH-RTP-013.cisco.com (xch-rtp-013.cisco.com [64.101.220.153]) by rcdn-core-3.cisco.com (8.15.2/8.15.2) with ESMTPS id x3UHiJQa013614 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Tue, 30 Apr 2019 17:44:20 GMT
Received: from xch-rtp-013.cisco.com (64.101.220.153) by XCH-RTP-013.cisco.com (64.101.220.153) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 30 Apr 2019 13:44:19 -0400
Received: from xch-rtp-013.cisco.com ([64.101.220.153]) by XCH-RTP-013.cisco.com ([64.101.220.153]) with mapi id 15.00.1473.003; Tue, 30 Apr 2019 13:44:19 -0400
From: "Eric Voit (evoit)" <evoit@cisco.com>
To: Dhruv Dhody <dhruv.ietf@gmail.com>, "kent+ietf@watsen.net" <kent+ietf@watsen.net>
CC: "rtg-dir@ietf.org" <rtg-dir@ietf.org>, "draft-ietf-netconf-netconf-event-notifications.all@ietf.org" <draft-ietf-netconf-netconf-event-notifications.all@ietf.org>, "netconf@ietf.org" <netconf@ietf.org>, Dhruv Dhody <dhruv.dhody@huawei.com>, "<rtg-ads@ietf.org>" <rtg-ads@ietf.org>
Thread-Topic: RtgDir review: draft-ietf-netconf-netconf-event-notifications-17
Thread-Index: AQHU/xC8WbWTXSPvekeZmlnK7/xOtqZU7OSw
Date: Tue, 30 Apr 2019 17:44:19 +0000
Message-ID: <7395d7e5db4b48e1ba582c9c48c29913@XCH-RTP-013.cisco.com>
References: <CAB75xn4HiqYqeWu2tiOsfDwU4ePc+-6ym+4EpowqZ-YMgkRRMA@mail.gmail.com>
In-Reply-To: <CAB75xn4HiqYqeWu2tiOsfDwU4ePc+-6ym+4EpowqZ-YMgkRRMA@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.118.56.233]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-Outbound-SMTP-Client: 64.101.220.153, xch-rtp-013.cisco.com
X-Outbound-Node: rcdn-core-3.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/netconf/EngBqI3tiQwrKaCmO-vNf5_z7IU>
Subject: Re: [netconf] RtgDir review: draft-ietf-netconf-netconf-event-notifications-17
X-BeenThere: netconf@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NETCONF WG list <netconf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netconf>, <mailto:netconf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netconf/>
List-Post: <mailto:netconf@ietf.org>
List-Help: <mailto:netconf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netconf>, <mailto:netconf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Apr 2019 17:44:34 -0000

Hi Dhruv,
Hi Kent,

Thanks very much for the comments Dhruv.  Thoughts in-line, with one question to Kent...

> From: Dhruv Dhody, April 30, 2019 12:53 AM
>
> Hello,
> 
> I have been selected as the Routing Directorate reviewer for this draft. The
> Routing Directorate seeks to review all routing or routing-related drafts as they
> pass through IETF last call and IESG review, and sometimes on special request.
> The purpose of the review is to provide assistance to the Routing ADs. For more
> information about the Routing Directorate, please see
> http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir
> 
> Although these comments are primarily for the use of the Routing ADs, it would
> be helpful if you could consider them along with any other IETF Last Call
> comments that you receive, and strive to resolve them through discussion or by
> updating the draft.
> 
> Document: draft-ietf-netconf-netconf-event-notifications-17
> Reviewer: Dhruv Dhody
> Review Date: 2019-04-29
> IETF LC End Date: 2019-04-12
> Intended Status: Standards Track
> 
> Summary:
> --------
> I have some minor concerns about this document that I think should be resolved
> before publication.
> 
> Comments:
> ---------
> This document provides a binding for events streamed over the NETCONF for
> dynamic subscriptions. This is a companion document to draft-ietf-netconf-
> subscribed-notifications and this capability for RESTCONF is defined in draft-ietf-
> netconf-restconf-notif.
> 
> The document is overall well written, it makes an assumption that the reader is
> well versed in this area and thus sparse in providing details in the Introduction
> section. The appendix provides good examples.
> 
> I don't see any Routing Yang model specific issue.
> 
> Major Issues:
> -------------
> Note - An IETF process issue, but worth handling right away.
> 
> Section 11 says -
> 
> 11.  Notes to the RFC Editor
> 
>    This section can be removed by the RFC editor after the requests have
>    been performed.
> 
> It further says -
> 
>    RFC 6241 needs to be updated based on the needs of this draft.
>    RFC-6241 section 1.2 bullet "(2)" targets RFC-5277 (actually it
>    identifies RFC 5717, but that was an error fixed after RFC
>    publication).  Anyway the current phrasing in RFC-5277 says that a
>    notification message can only be sent after a successful "create-
>    subscription".  Therefore the reference text must be modified to also
>    allow notification messages be sent after a successful "establish-
>    subscription".  Proposed text for bullet (2) of RFC-6241 would be:
> 
>      (2)  The Messages layer provides a simple, transport-independent
>           framing mechanism for encoding RPCs and notifications.
>           Section 4 documents the RPC messages, [RFC5277] documents
>           Notifications sent as a result of a <create-subscription> RPC,
>           and [RFC xxxx] documents Notifications sent as a result of
>           an <establish-subscription> RPC.
> 
>       (where xxxx is replaced with this RFC number)
> 
> I am not sure if this is correct. I don't think RFC editor can do the action you are
> asking them to do on their own. They would need an errata (which is not correct
> here) or another document that updates RFC 6241. In my view this document
> should just update RFC 6241 (and mark that in this document's
> header) and do necessary text changes to reflect that.

I am happy to follow whatever process is cleanest.   

Kent, are you comfortable with this document directly revising  wording of RFC-6241 section 1.2 bullet "(2)" above?    If yes, it would be great to have your thoughts on what needs to go into this document.   Especially as RFC-6241 section 1.2 bullet "(2)" already had a fix applied against it. 

> Minor Issues:
> -------------
> (1) Abstract & Introduction, It is not clear what does the 'binding' mean and who
> are the parties to this binding? If this is the document that mentions 'binding'
> first, so please add some more clarifying text.
> 
> (2) Section 3, since you use MUST in the error handling, isn't it better to use
> normative in below sentence as well -
> OLD:
>                                                        However a single
>    NETCONF transport session cannot support both this specification and
>    a subscription established by [RFC5277]'s "create-subscription" RPC.
> NEW:
>                                                        However a single
>    NETCONF transport session MUST NOT support both this specification and
>    a subscription established by [RFC5277]'s "create-subscription" RPC.

Makes sense.  I have made the change, and will post the update when the "Major issue" from above is resolved.

> (3) Section 6, You have -
> 
>    And per [RFC5277]'s "eventTime" object definition, the
>    "eventTime" MUST be populated with the event occurrence time.
> 
> Is this a new requirement, or just re-stating RFC5277? RFC5277 says -
> 
>       eventTime
> 
>          The time the event was generated by the event source.  This
>          parameter is of type dateTime and compliant to [RFC3339].
>          Implementations must support time zones.
> 
>       Also contains notification-specific tagged content, if any.  With
>       the exception of <eventTime>, the content of the notification is
>       beyond the scope of this document.
> 
> Maybe remove MUST? If you are trying to refine the text from RFC5277, then
> please re-word.

You are correct.  The MUST is redundant with RFC-5277's XSD definition.   Therefore I have removed "MUST be".

> Nits:
> -----
> (1) Abstract
> 
>    RFC Editor note: please replace the four references to pre-RFC
>    normative drafts with the actual assigned RFC numbers.
> 
> I see two drafts in the reference section. Why four?

You are correct.  I removed the word "four".  

> Also, since those two are normative references, these would be published as a
> cluster as a part of normal RFC editor processing right?

Yes.
 
> (2) Regarding NETCONF, the RFC editor says [1] -
> 
> NETCONF    - Network Configuration Protocol (NETCONF)
>                [Not typically expanded in titles, but expand in abstract]
> 
> Please expand.

Done.

> (3) s/[I-D.draft-ietf-netconf-subscribed-notifications]
>      /[I-D.ietf-netconf-subscribed-notifications]

Actually I changed the [I-D.ietf-netconf-yang-push]  to  [I-D.draft-ietf-netconf-yang-push]

This makes it consistent across all four drafts.

Thanks again!
Eric

> Just so that you have the same style of draft reference in the document. I get
> that it would be replaced with a RFC number anyways :)
> 
> [1] https://www.rfc-editor.org/materials/abbrev.expansion.txt
> 
> Thanks!
> Dhruv