Re: [Netconf] [yang-doctors] Yangdoctors last call review of draft-ietf-netconf-netconf-event-notifications-16

"Eric Voit (evoit)" <evoit@cisco.com> Fri, 11 January 2019 21:06 UTC

Return-Path: <evoit@cisco.com>
X-Original-To: netconf@ietfa.amsl.com
Delivered-To: netconf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D03D6128CE4; Fri, 11 Jan 2019 13:06:16 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.643
X-Spam-Level:
X-Spam-Status: No, score=-14.643 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_MED=-0.142, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rce35JfEz5eK; Fri, 11 Jan 2019 13:06:15 -0800 (PST)
Received: from rcdn-iport-2.cisco.com (rcdn-iport-2.cisco.com [173.37.86.73]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id CC325128B14; Fri, 11 Jan 2019 13:06:14 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=6258; q=dns/txt; s=iport; t=1547240774; x=1548450374; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=j4uHJzywoOL4M8bLsmM49jRvGvEhLiOFSkKfERJfBOo=; b=N943ugVl1z1LjDKeiyzfZdq6dxl4Gof0dRuqYZJ43ayyJ5lniMzWc6RU D4BN1DmgIZkYds2Wx683bb6xzSOP2E3J8vdpIEFPiou5KG3peOmiKHZBS SATwj2cqsms4UBUy4My9hM/a8WSz8l3aBF8nh+tw+FEf5eqPEm68qxSRI Q=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0AFAACbBDlc/4sNJK1jGQEBAQEBAQE?= =?us-ascii?q?BAQEBAQcBAQEBAQGBUgMBAQEBAQsBgVopZoECJwqDd5YXg0aUNBSBZwsBARg?= =?us-ascii?q?LhEkCF4ISIjUIDQEDAQECAQECbRwMhUoBAQEDAQEBIRE6CQIFCwIBCBUDAgI?= =?us-ascii?q?JFgcCAgIlCxUQAgQBDQUIgk9LAYF5CA+va4EvhEJAhSkFgQuLNBeBQD+DbjW?= =?us-ascii?q?DHgEBAgEBgSoBEgESJIJygjUiAqEhWgkChxiDT4cSIIFkiFqHP4lwgQiEBos?= =?us-ascii?q?+AhEUgSchAzNlcXAVO4JsglGITIU/QTGIDA0XB4EBgR8BAQ?=
X-IronPort-AV: E=Sophos;i="5.56,466,1539648000"; d="scan'208";a="507818880"
Received: from alln-core-6.cisco.com ([173.36.13.139]) by rcdn-iport-2.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jan 2019 21:06:13 +0000
Received: from XCH-RTP-004.cisco.com (xch-rtp-004.cisco.com [64.101.220.144]) by alln-core-6.cisco.com (8.15.2/8.15.2) with ESMTPS id x0BL6Dax027430 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Fri, 11 Jan 2019 21:06:13 GMT
Received: from xch-rtp-013.cisco.com (64.101.220.153) by XCH-RTP-004.cisco.com (64.101.220.144) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 11 Jan 2019 16:06:12 -0500
Received: from xch-rtp-013.cisco.com ([64.101.220.153]) by XCH-RTP-013.cisco.com ([64.101.220.153]) with mapi id 15.00.1395.000; Fri, 11 Jan 2019 16:06:12 -0500
From: "Eric Voit (evoit)" <evoit@cisco.com>
To: "Reshad Rahman (rrahman)" <rrahman@cisco.com>, "yang-doctors@ietf.org" <yang-doctors@ietf.org>, Alexander Clemm <alexander.clemm@huawei.com>
CC: "draft-ietf-netconf-netconf-event-notifications.all@ietf.org" <draft-ietf-netconf-netconf-event-notifications.all@ietf.org>, "netconf@ietf.org" <netconf@ietf.org>
Thread-Topic: [yang-doctors] Yangdoctors last call review of draft-ietf-netconf-netconf-event-notifications-16
Thread-Index: AQHUqDk0MEtk4/aZ2E+MAjzaT3aN2aWnWDMAgAMikDA=
Date: Fri, 11 Jan 2019 21:06:12 +0000
Message-ID: <4507042659b84a01b5738f368edc95e4@XCH-RTP-013.cisco.com>
References: <154705166883.4820.16710277209489694478@ietfa.amsl.com> <B9679402-7DF0-445C-8455-E7FB90A3E9DB@cisco.com>
In-Reply-To: <B9679402-7DF0-445C-8455-E7FB90A3E9DB@cisco.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.118.56.229]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-Outbound-SMTP-Client: 64.101.220.144, xch-rtp-004.cisco.com
X-Outbound-Node: alln-core-6.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/netconf/FFB5VGVpxMdI78oKOis2cOzJhHI>
Subject: Re: [Netconf] [yang-doctors] Yangdoctors last call review of draft-ietf-netconf-netconf-event-notifications-16
X-BeenThere: netconf@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Network Configuration WG mailing list <netconf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netconf>, <mailto:netconf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netconf/>
List-Post: <mailto:netconf@ietf.org>
List-Help: <mailto:netconf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netconf>, <mailto:netconf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Jan 2019 21:06:17 -0000

Hi Reshad,

Thanks for the review.   Some thoughts in-line...

> From: Reshad Rahman, January 9, 2019 1:49 PM
> 
> Don't know why newlines aren't showing up in the email, if you want a nicer
> view (also a slight revision):
> https://datatracker.ietf.org/doc/review-ietf-netconf-netconf-event-
> notifications-16-yangdoctors-lc-rahman-2019-01-09/
> 
> ´╗┐On 2019-01-09, 11:34 AM, "yang-doctors on behalf of Reshad Rahman" <yang-
> doctors-bounces@ietf.org on behalf of rrahman@cisco.com>; wrote:
> 
>     Reviewer: Reshad Rahman
>     Review result: Ready with Issues
> 
>     YANG Doctor review of draft-ietf-netconf-netconf-event-notifications-16 (by
>     Reshad Rahman)
> 
>     No YANG module in this draft but there are numerous examples based on
> the YANG
>     modules in draft-ietf-netconf-subscribed-notifications and
>     draft-ietf-netconf-yang-push. Validation of the examples was done with
> yanglint
>     0.16.59.
> 
>     The major issues are related to the examples, although in 2) below  the
>     root-cause might be with the YANG module in
>     draft-ietf-netconf-subscribed-notifications  and in 3) there is an issue which
>     has already been reported on draft-ietf-netconf-yang-push: 
>     1) The  establish-subscription request in Figure 3 fails yanglint validation, the
>     "stream" element has to be moved after the "stream-xpath-filter" element,
>      that  fixed the following issue: err : Invalid order of elements
>     "stream-xpath-filter" and "stream".
>     (/ietf-subscribed-notifications:establish-subscription/stream-xpath-filter) 
Done.

>    2) The establish-subscription error response in Figure 5 fails yanglint
>     validation, the "id" element is missing. This is because
>     draft-ietf-netconf-subscribed-notifications has leaf id as mandatory in
>     establish-subscription output, either we remove the mandatory or we
>     reserve a
>     value as invalid id or we add err : Missing required element "id" in
>     "establish-subscription".
>     (/ietf-subscribed-notifications:establish-subscription)
The id is mandatory for the <establish-subscription> RPC response of that RPC.  It is not needed as part of the general <rpc-error> response.   So I believe we are good here.  (Note: Yanglint would need to be upgraded to do fairly complex RPC correlation to be able to automatically cover such issue types.)

>     3) The  modify-subscription request in Figure 7 fails yanglint validation 
>     because of missing "datastore" element. err : When condition
>     "../ietf-subscribed-notifications:target/ietf-yang-push:datastore" not
>     satisfied.
>     (/ietf-subscribed-notifications:modify-subscription/ietf-yang-push:periodic)
>     There are 2 causes here: missing "datastore" element and incorrect when
>     statements in draft-ietf-netconf-yang-push (as reported by Andy Bierman).
>     Fixing ietf-yang-push.yang and adding the following before element
>     "datastore-xpath-filter " fixed the example.
>         <yp:datastore
>         xmlns:ds="urn:ietf:params:xml:ns:yang:ietf-
>      datastores">ds:running</yp:datastore>
Alex is going to be making the change to the YANG push datastore drafts shortly (I just talked with him).  I am happy to modify the example (if necessary) based on  the "when" statement incorporated under update-policy-modifiable.  

>     Minor comments and nits:
>     - Abstract s/YANG Push/YANG-Push/ since YANG-Push is the term introduced
> in
>     draft-ietf-netconf-yang-push 
Done

>    Introduction. Last sentence doesn't read well,
>     "...a RESTCONF client via a dynamic subscription..." may need tweaking -
That text has been touched so many times, I am afraid of touching it again.

>     Section 5 s/terminates/terminates,/ 
Done

>     Section 7 3rd bullet. s/this MAY but does
>     not have to be included/this MAY be included/? 
Done

>     Section 7
>     s/kill-subscription-error/delete-subscription-error/ (thanks Rob) 
Done

>     Figure 3,
>     stream-xpath-filter uses prefix "ds" for example-datastore.yang. Since "ds" is
>     used by ietf-datastores.yang, might be better to choose another prefix such
>     as  "ex"
Done.

I will post after a couple days, or after the "when" question closes (whatever comes first).

Eric

>     Regards,
>     Reshad.
> 
> 
>     _______________________________________________
>     yang-doctors mailing list
>     yang-doctors@ietf.org
>     https://www.ietf.org/mailman/listinfo/yang-doctors
>