Re: [Netconf] [yang-doctors] Yangdoctors last call review of draft-ietf-netconf-netconf-event-notifications-16

"Reshad Rahman (rrahman)" <rrahman@cisco.com> Fri, 11 January 2019 21:59 UTC

Return-Path: <rrahman@cisco.com>
X-Original-To: netconf@ietfa.amsl.com
Delivered-To: netconf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 78B1712896A; Fri, 11 Jan 2019 13:59:55 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -19.054
X-Spam-Level:
X-Spam-Status: No, score=-19.054 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Y39-7iq64nGk; Fri, 11 Jan 2019 13:59:52 -0800 (PST)
Received: from rcdn-iport-7.cisco.com (rcdn-iport-7.cisco.com [173.37.86.78]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 80B431200D7; Fri, 11 Jan 2019 13:59:52 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=7234; q=dns/txt; s=iport; t=1547243992; x=1548453592; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=aZatFE1rAEyViX0F6aeUSy6wh/yIEqcbtnOnxczFryU=; b=SIKl+Cr1xixtGoyE91XK3UstFYImJT/BMRbChE63UiPeQnKzTXQ6kZqG d/cIpeQR9plymTumZH0FC8TxQl1SK0fh+bN75ZA96udEr//2N7g5Ts2zV Ls/7NfwKYoXlEX6rw50Xelin+e3NIpcbb4Q3oY5WG13WAO7zAYvn3UQvY o=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0AFAACZEDlc/4cNJK1jGQEBAQEBAQE?= =?us-ascii?q?BAQEBAQcBAQEBAQGBUgMBAQEBAQsBgVopZoECJwqDd5VxJZd6FIFnCwEBGAu?= =?us-ascii?q?EA0YCF4ISIjUIDQEDAQECAQECbRwMhUoBAQEDAQEBIRE6CQIQAgEIFQMCAgk?= =?us-ascii?q?WBwICAiULFRACBAENBYJXSwGBeQgPrzyBL4QuARNAhSkFgQuLNBeBQD+BOAw?= =?us-ascii?q?Tghc1gx4BAQIBAYEqARIBEg0XgnIxggQiAolVl0xaCQKHGINPhxoYgWSIWoc?= =?us-ascii?q?/iXCBCIQGiz4CERSBJyECNGVxcBU7KgGCQYJRgziFFIU/QTGIDA0XB4EBgR8?= =?us-ascii?q?BAQ?=
X-IronPort-AV: E=Sophos;i="5.56,466,1539648000"; d="scan'208";a="501407291"
Received: from alln-core-2.cisco.com ([173.36.13.135]) by rcdn-iport-7.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jan 2019 21:59:51 +0000
Received: from XCH-RCD-013.cisco.com (xch-rcd-013.cisco.com [173.37.102.23]) by alln-core-2.cisco.com (8.15.2/8.15.2) with ESMTPS id x0BLxoWj029348 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Fri, 11 Jan 2019 21:59:50 GMT
Received: from xch-rcd-005.cisco.com (173.37.102.15) by XCH-RCD-013.cisco.com (173.37.102.23) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 11 Jan 2019 15:59:50 -0600
Received: from xch-rcd-005.cisco.com ([173.37.102.15]) by XCH-RCD-005.cisco.com ([173.37.102.15]) with mapi id 15.00.1395.000; Fri, 11 Jan 2019 15:59:50 -0600
From: "Reshad Rahman (rrahman)" <rrahman@cisco.com>
To: "Eric Voit (evoit)" <evoit@cisco.com>, "yang-doctors@ietf.org" <yang-doctors@ietf.org>, Alexander Clemm <alexander.clemm@huawei.com>
CC: "draft-ietf-netconf-netconf-event-notifications.all@ietf.org" <draft-ietf-netconf-netconf-event-notifications.all@ietf.org>, "netconf@ietf.org" <netconf@ietf.org>
Thread-Topic: [yang-doctors] Yangdoctors last call review of draft-ietf-netconf-netconf-event-notifications-16
Thread-Index: AQHUqDk0MEtk4/aZ2E+MAjzaT3aN2aWnWDMAgAMikDCAADd9gA==
Date: Fri, 11 Jan 2019 21:59:50 +0000
Message-ID: <5EBE9EF0-C7AD-4318-B54C-292D99157717@cisco.com>
References: <154705166883.4820.16710277209489694478@ietfa.amsl.com> <B9679402-7DF0-445C-8455-E7FB90A3E9DB@cisco.com> <4507042659b84a01b5738f368edc95e4@XCH-RTP-013.cisco.com>
In-Reply-To: <4507042659b84a01b5738f368edc95e4@XCH-RTP-013.cisco.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/10.10.5.181209
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.82.229.86]
Content-Type: text/plain; charset="utf-8"
Content-ID: <367A4E1B6AF1744598B4D98C5A34F680@emea.cisco.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-Outbound-SMTP-Client: 173.37.102.23, xch-rcd-013.cisco.com
X-Outbound-Node: alln-core-2.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/netconf/FarEICMheoBD7ic22WNHB6C8_sQ>
Subject: Re: [Netconf] [yang-doctors] Yangdoctors last call review of draft-ietf-netconf-netconf-event-notifications-16
X-BeenThere: netconf@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Network Configuration WG mailing list <netconf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netconf>, <mailto:netconf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netconf/>
List-Post: <mailto:netconf@ietf.org>
List-Help: <mailto:netconf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netconf>, <mailto:netconf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Jan 2019 21:59:56 -0000

Hi Eric,

All good. For issue #2 below, Michal confirmed that yanglint doesn't handle rpc-error, so there's no issue in the draft as you mentioned.
https://github.com/CESNET/libyang/issues/696

Regards,
Reshad.


´╗┐On 2019-01-11, 4:06 PM, "Eric Voit (evoit)" <evoit@cisco.com>; wrote:

    Hi Reshad,
    
    Thanks for the review.   Some thoughts in-line...
    
    > From: Reshad Rahman, January 9, 2019 1:49 PM
    > 
    > Don't know why newlines aren't showing up in the email, if you want a nicer
    > view (also a slight revision):
    > https://datatracker.ietf.org/doc/review-ietf-netconf-netconf-event-
    > notifications-16-yangdoctors-lc-rahman-2019-01-09/
    > 
    > On 2019-01-09, 11:34 AM, "yang-doctors on behalf of Reshad Rahman" <yang-
    > doctors-bounces@ietf.org on behalf of rrahman@cisco.com>; wrote:
    > 
    >     Reviewer: Reshad Rahman
    >     Review result: Ready with Issues
    > 
    >     YANG Doctor review of draft-ietf-netconf-netconf-event-notifications-16 (by
    >     Reshad Rahman)
    > 
    >     No YANG module in this draft but there are numerous examples based on
    > the YANG
    >     modules in draft-ietf-netconf-subscribed-notifications and
    >     draft-ietf-netconf-yang-push. Validation of the examples was done with
    > yanglint
    >     0.16.59.
    > 
    >     The major issues are related to the examples, although in 2) below  the
    >     root-cause might be with the YANG module in
    >     draft-ietf-netconf-subscribed-notifications  and in 3) there is an issue which
    >     has already been reported on draft-ietf-netconf-yang-push: 
    >     1) The  establish-subscription request in Figure 3 fails yanglint validation, the
    >     "stream" element has to be moved after the "stream-xpath-filter" element,
    >      that  fixed the following issue: err : Invalid order of elements
    >     "stream-xpath-filter" and "stream".
    >     (/ietf-subscribed-notifications:establish-subscription/stream-xpath-filter) 
    Done.
    
    >    2) The establish-subscription error response in Figure 5 fails yanglint
    >     validation, the "id" element is missing. This is because
    >     draft-ietf-netconf-subscribed-notifications has leaf id as mandatory in
    >     establish-subscription output, either we remove the mandatory or we
    >     reserve a
    >     value as invalid id or we add err : Missing required element "id" in
    >     "establish-subscription".
    >     (/ietf-subscribed-notifications:establish-subscription)
    The id is mandatory for the <establish-subscription> RPC response of that RPC.  It is not needed as part of the general <rpc-error> response.   So I believe we are good here.  (Note: Yanglint would need to be upgraded to do fairly complex RPC correlation to be able to automatically cover such issue types.)
    
    >     3) The  modify-subscription request in Figure 7 fails yanglint validation 
    >     because of missing "datastore" element. err : When condition
    >     "../ietf-subscribed-notifications:target/ietf-yang-push:datastore" not
    >     satisfied.
    >     (/ietf-subscribed-notifications:modify-subscription/ietf-yang-push:periodic)
    >     There are 2 causes here: missing "datastore" element and incorrect when
    >     statements in draft-ietf-netconf-yang-push (as reported by Andy Bierman).
    >     Fixing ietf-yang-push.yang and adding the following before element
    >     "datastore-xpath-filter " fixed the example.
    >         <yp:datastore
    >         xmlns:ds="urn:ietf:params:xml:ns:yang:ietf-
    >      datastores">ds:running</yp:datastore>
    Alex is going to be making the change to the YANG push datastore drafts shortly (I just talked with him).  I am happy to modify the example (if necessary) based on  the "when" statement incorporated under update-policy-modifiable.  
    
    >     Minor comments and nits:
    >     - Abstract s/YANG Push/YANG-Push/ since YANG-Push is the term introduced
    > in
    >     draft-ietf-netconf-yang-push 
    Done
    
    >    Introduction. Last sentence doesn't read well,
    >     "...a RESTCONF client via a dynamic subscription..." may need tweaking -
    That text has been touched so many times, I am afraid of touching it again.
    
    >     Section 5 s/terminates/terminates,/ 
    Done
    
    >     Section 7 3rd bullet. s/this MAY but does
    >     not have to be included/this MAY be included/? 
    Done
    
    >     Section 7
    >     s/kill-subscription-error/delete-subscription-error/ (thanks Rob) 
    Done
    
    >     Figure 3,
    >     stream-xpath-filter uses prefix "ds" for example-datastore.yang. Since "ds" is
    >     used by ietf-datastores.yang, might be better to choose another prefix such
    >     as  "ex"
    Done.
    
    I will post after a couple days, or after the "when" question closes (whatever comes first).
    
    Eric
    
    >     Regards,
    >     Reshad.
    > 
    > 
    >     _______________________________________________
    >     yang-doctors mailing list
    >     yang-doctors@ietf.org
    >     https://www.ietf.org/mailman/listinfo/yang-doctors
    >