Re: [Netconf] I-D Action: draft-ietf-netconf-subscribed-notifications-19.txt

Thanks Carl. What is interesting is that pyang shows no errors, while confdc and yanglint do.

Regards,
Reshad.

On 2018-12-19, 7:13 PM, "Carl Moberg" <calle@tail-f.com> wrote:

     Actually, and to put a finer point on the below. I do extract YANG modules from drafts, but only store those that pass extraction and validation. And it turns out that validation of the module extracted from https://www.ietf.org/id/draft-ietf-netmod-schema-mount-12.txt fails because the file name in the CODE BEGINS marker is missing the “.yang” suffix which violates https://tools.ietf.org/html/rfc6087#section-3.1.

    > On Dec 20, 2018, at 12:57 AM, Carl Moberg <calle@tail-f.com> wrote:
    > 
    > Reshad,
    > 
    > Yes, so the YANG modules in the draft tries to import the 'ietf-yang-schema-mount’ and 'ietf-network-instance' YANG modules which are not available in the repo in the validator. The reason why we don’t keep them in the repo is that the specification that defines those modules (draft-ietf-netmod-schema-mount, and draft-ietf-rtgwg-ni-model respectively) are not published yet and we only keep published YANG modules.
    > 
    > The easiest way forward is probably to extract the YANG modules from your draft (perhaps using the https://github.com/xym-tool/xym tool), zip up your module with the imported modules and validate them using the “Upload multiple YANG files or a zip archive” option.
    > 
    > I am considering storing draft-level YANG files (they are many and broken :-) in the validator repo as well. Maybe time to revisit that.
    > 
    >> On Dec 20, 2018, at 12:46 AM, Reshad Rahman (rrahman) <rrahman@cisco.com> wrote:
    >> 
    >> Hi Carl,
    >> 
    >> Yangvalidator.org has the following errors for -20, pyang is fine though.
    >> 
    >> Regards,
    >> Reshad.
    >> 
    >> Confdc Output
    >> ietf-network-instance@2018-03-20.yang:18: error: module 'ietf-yang-schema-mount' not found
    >> yanglint Validation
    >> err : Data model "ietf-yang-schema-mount" not found.
    >> err : Importing "ietf-yang-schema-mount" module into "ietf-network-instance" failed.
    >> err : Module "ietf-network-instance" parsing failed.
    >> err : Importing "ietf-network-instance" module into "ietf-subscribed-notifications" failed.
    >> err : Module "ietf-subscribed-notifications" parsing failed.
    >> 
    >> 
    >> On 2018-12-19, 6:37 PM, "Netconf on behalf of Carl Moberg" <netconf-bounces@ietf.org on behalf of calle@tail-f.com> wrote:
    >> 
    >> 
    >> 
    >>> On Dec 19, 2018, at 8:40 PM, Martin Bjorklund <mbj@tail-f.com> wrote:
    >>> 
    >>> "Eric Voit (evoit)" <evoit@cisco.com> wrote:
    >>>> Thanks Martin,
    >>>> 
    >>>> 
    >>>> 
    >>>> I have the version addressing the double quotes here:
    >>>> 
    >>>> https://github.com/netconf-wg/rfc5277bis/blob/master/draft-ietf-netconf-subscribed-notifications-20.xml
    >>>> 
    >>>> 
    >>>> 
    >>>> Before I upload this -20, I want to see if you have concerns with the Pyang Validation issue shown below.   Reshad mentioned that other users have seen it.  Is this something which should stop me from posting?
    >>>> 
    >>> 
    >>> You get this error b/c you are running an old version of pyang that
    >>> isn't compatible with the (newer) version of pip on your system.  I
    >>> suggest you upgrade pyang.
    >>> 
    >> 
    >>    Yup, thanks. Upgraded and yangvalidator.org now works (better).
    >> 
    >>   _______________________________________________
    >>   Netconf mailing list
    >>   Netconf@ietf.org
    >>   https://www.ietf.org/mailman/listinfo/netconf
    >> 
    >> 
    > 
    > _______________________________________________
    > Netconf mailing list
    > Netconf@ietf.org
    > https://www.ietf.org/mailman/listinfo/netconf