Re: [Netconf] LC on subscribed-notifications-10

[Kent Watsen <[e-mail]>]

Hi Eric,

Now <Kent6>

Kent


On 5/9/18, 5:39 PM, "Eric Voit (evoit)" <[e-mail]<mailto:[e-mail]>> wrote:

Hi Kent,

See <Eric6>.  Current version can be seen at:
https://github.com/netconf-wg/rfc5277bis/blob/master/draft-ietf-netconf-subscribed-notifications-13.txt<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_netconf-2Dwg_rfc5277bis_blob_master_draft-2Dietf-2Dnetconf-2Dsubscribed-2Dnotifications-2D13.txt&d=DwMGaQ&c=HAkYuh63rsuhr6Scbfh0UjBXeMK-ndb3voDTXcWzoCI&r=9zkP0xnJUvZGJ9EPoOH7Yhqn2gsBYaGTvjISlaJdcZo&m=RZ_qNzuDRX0D4rDeJJ8fe76NaiVfDiQLNf2edHaFvnI&s=cjTkob7LnjltmMqskx_dCrJN1h-qlRRBc2KUblzNNGg&e=>



[further trimming]


<Eric3>  Added the descriptive paragraph requested in the middle of the three paragraphs below...

It is possible to place a start time on a configured subscription.  This enables streaming of logged information immediately after restart.

Replay of events records created since restart can be quite useful.  This allows event records generated before transport connectivity was supportable by a publisher to be passed to a receiver.  In addition, event records logged before restart are not sent.  This avoids the potential for accidental event record duplication.  Such duplication might otherwise be likely as a configured subscription’s identifier before and after the reboot is the same, and there may be not be evidence to a receiver that a restart has occurred.  By establishing restart as the earliest potential time for event records to be included in notification messages, a well-understood timeframe for replay is defined.

Therefore, when configured replay subscription receivers first become ACTIVE, buffered event records (if any) will be sent immediately after the "subscription-started" notification.  And the leading event record sent will be the first event record subsequent to the latest of four different times: the "replay-log-creation-time", "replay-log-aged-time", "replay-start-time", or the most recent publisher boot time.

<Kent3> Hmmm, I'm having a negative reaction to the "event records logged before restart are not sent" bit.  I know what you are trying to do, but I worry that this behavior might drop important logs, perhaps to the advantage of an adversary.  Note that some devices implement an <edit-config> with a restart.  Maybe the solution should require publishers to maintain a per configured-subscription awareness of (roughly) which log was sent last?   - and notify the receiver when a restart has occurred, or when the replaying of events occurs, so that they can be aware that there might be some duplicates?

<Eric4>  The current solution guarantees no duplicates, and also informs the receiver of each new “start-time”.  This allows the receiver to attempt to reconstruct any gaps from the last event previously pushed, should the choose to attempt such reconstruction.   As a dynamic subscription has no such boundary constraints on replay and boot time, all a subsequent dynamic subscription needs to do is to request the events between the last received event previously received from that configured subscription and the new replay-start-time.

<Kent4> So, the receiver is informed of each new "start-time" via the "subscription-started" control message, and then MUST do a short-lived dynamic subscription to scoop-up any possibly-missed logs, for which there may be none?   If we choose to keep this behavior, the draft should say this more clearly, perhaps in the Security Considerations section…

<Eric5> Added the following text as the last paragraph in the Implementation Considerations Section...

For configured replay subscriptions, the receiver is protected from duplicated events being pushed after a publisher is rebooted.  However it is possible that a receiver might want to acquire event records which failed to be delivered just prior to the reboot. Delivering these event records be accomplished by leveraging the “eventTime” from the last event record received prior to the receipt of a “subscription-started” state change notification.  With this “eventTime” and  the “replay-start-time” from the “subscription-started” notification, an independent dynamic subscription can be established which retrieves any event records which may have been generated but not sent to the receiver.

 <KENT5> Is this really limited to reboots, or any restarting of a configured subscription?

<Eric6> The protection from event replication is just for reboots – this is because the configured replay start time might duplicate events already sent from a previous boot.

<Kent6> So, in the case of a suspend/resume, the device picks up where it left off?   Or is it also just starting with "current"?  (strangely, I'm having trouble finding this answer in -13).  If it picks up where it left off, does this mean that the device has index of some sort and, if so, why can't that state be persisted in the case of a graceful shutdown/restart?

But the mechanism to retrieve lost events is common between reboots and restarts.  I.e., using this solution, a receiver never needs to know a reboot occurred.  It just knows that a subscription restart occurred, and there might be a gap in events which should be retrieved via a dynamic subscription.

By having the receiver follow the same process for both reboots and restarted subscriptions, it simplifies recovery procedures.

<Kent6> I'm unsure about the "same process" (mentioned in my previous comment).

Next, I view this as a Security Consideration, since nefarious things can happen when a device reboots and note that a DoS could extend the gap to hours or days.  I think that this draft (the text above) is watering down the issue.  In my view, this is a huge consideration, along the lines of a receiver really MUST always try to use a dynamic subscription to fill in any gaps.

<Eric6> I agree this is a best practice, but a MUST would require telemetry receivers to have to support dynamic subscriptions.  I can see IoT receiver implementations where this wouldn’t be likely.

<Kent6> Good point, but I don't see in the YANG module establish-subscription being optional to implement.  Is that an oversight?


To cover your desire to highlight this in security, I have added the following requirement to the Security Considerations Section:

When a configured receiver gets a new “subscription-started” message for a known subscription where it is already consuming events, the receiver SHOULD retrieve any event records generated since the last event record was received.  This can be accomplish by establishing a separate dynamic replay subscription with the same filtering criteria with the publisher.

<Kent6> that's helpful.  Perhaps tack onto the end of the last sentence something like ", assuming the publisher supports the ['dynamic' and] 'replay' feature[s]"?

It almost begs the question for why configured subscriptions are supported at all.

<Eric6> Because there have been lots of industry requests.  And lots of implementations with non-IETF solutions.  Personally I prefer dynamic subscriptions.

<Kent6> I can see the appeal of configured subscriptions, but if each receiver of a configured subscription SHOULD always do a dynamic subscription on every publisher reboot, it is already being coded to support dynamic subscriptions, at which point it seems that maybe it should've just been implemented to support dynamic subscriptions from the start (on top of the publisher-initiated call-home transport, of course).   Can you say some more about these industry requests and, in particular, if the requests are still strong even when made aware of the need to also do dynamic subscriptions?



<snip/>



<Kent4> this I agree with, but I really don't like the fact that receiver MUST do a short-lived dynamic subscription to scoop-up any possibly-missed logs, for which there may be none.  Perhaps we could add more values into the "subscription-started" notification message that would enable to receiver to make a local determination if such a dynamic subscription would be  helpful?



<Eric5> I recommend against providing extra objects/reasons in the “subscription-started” at this time.  Publishers might not want to advertise a reboot, and they might not want to advertise why there was loss in event continuity.   All that should matter to a receiver is that such a discontinuity existed, and they have a way to try to fill event the gap should they care.  If the need for more data and the cause of the discontinuity turns out to be required, we can always augment here with future objects.



<KENT5> first, I'm still not 100% sure if this is just a reboot problem, or any time the subscription is restarted/resumed.



<Eric6> Per above: retrieving missing event records is not a reboot specific problem.  But unintentionally replicating event records is reboot specific.  (Otherwise the configured replay-start-time would drive a repeat of everything on each and every reboot.)



<Kent6> okay, I think I got it this time.  Having a *configurable* replay-start-time is so confusing.  Is it really worth having?





Next, can you explain what info could be provided that might allow a client to make a local decision as to whether a dynamic subscription is needed of not, and does the "replay-start-time" node provide it?



<Eric6> The local decision is easy.   As a configured receiver, I have just received a new subscription-started state change notification for a subscription I am tracking.  If I *need* to know about any events which occurred since the last event record I received for that subscription-id, then create a separate replay to cover that time gap.



<Kent6> it's not "if I need to know" so much as "I *know* that I'm missing some events because X and Y and, therefore I will create a dynamic subscription otherwise, since I know that I didn't miss any events, I will not create a dynamic subscription."   I'm trying to figure out what X and Y might be…







<Kent3> Going back to my original comment, the new paragraph helps, it certainly caught my attention regarding reboots wiping out the replay log buffer.



<Eric4>  There is no requirement that the reboot wipe outs out the buffer (the solution is agnostic to that).   The only requirement is that a configured subscription replay start no earlier than the last reboot time.



<Kent4> I'm glad to hear that the logs before restart aren't lost, just rather that there is no attempt to send them by default.   This wasn't all that obvious to me from what you wrote before.



<Eric4>  Tweaked a Section 2.4.2.1 sentence to say:



This document puts no restrictions on the size or form of the log, where it resides within the publisher, or when event record entries in the log are purged.



I suggest adding text that clarifies this, and details the need for a short-lived dynamic-subscription.



<Eric4> The tweak above, with the suggested text in the Implementation Considerations section above hopefully covers this.



<KENT5> the "purged" part helps, but whyis this information buried inside a section titled "Requesting a replay of event records"?



<Eric6>   This is the second paragraph of the first section which discussed replay.  It is the sentence after the optional feature of replay is introduced.



<Kent6> I understand how it fits into this section, but it seems like it should be in a section called something like "replay log", since it's equally applicable for configured subscriptions (and s2.4 is about dynamic subscriptions).  Of course, if we remove replay from configured subscriptions, then leaving it here makes sense…





<snip/>



<Kent3> unsure.  For example, RFC 6241has Section 2 (Transport Protocol Requirements) that the SSH and TLS binding drafts refer to.  It seems that this draft should have a similar section that highlights what MUST or MUST NOT be supported.  It could even include some additional text indicating that bindings MAY introduce additional requirements.



<Eric4> I re-read RFC6241 Section 2 a couple times.  There are a comparisons can be made from that document to a subset of requirements currently in this document’s security section.  But I don’t see anything missing on the MUST and MUST NOT side of things.   FYI: the specific requirements I am thinking of are:



   For both configured and dynamic subscriptions the publisher MUST

   authenticate and authorize a receiver via some transport level

   mechanism before sending any updates.



   A secure transport is highly recommended and the publisher MUST

   ensure that the receiver has sufficient authorization to perform the

   function they are requesting against the specific subset of content

   involved.



   With configured subscriptions, one or more publishers could be used

   to overwhelm a receiver.  Notification messages SHOULD NOT be sent to

   any receiver which does not support this specification.  Receivers

   that do not want notification messages need only terminate or refuse

   any transport sessions from the publisher.



That is about it for common stuff.  Considering the wide variety of potential transports, and ubiquity for the need of stream transports, I am simply not aware of any more common requirements.  If you need me to,  I can extract these three requirements, and put this under a separate transport requirements section.   But this seems excessive, especially as we have transport specific documents with eyes on them from the WG.  But if really do want this, I will place these into a new, separate section; and I will add your text: “bindings MAY introduce additional requirements.”



<Kent4> yes, this is what I'm thinking is needed, even if just for these 3 requirements + a statement that each transport MAY impose additional limitations (not so much a "requirement" as a "fact of life using said transport" I think)



<Eric5>  Move to a new section just before Security Considerations.   Added the last sentence:



Additional transport requirements will be dictated by the choice of transport used with a subscription. For an example of such requirements with NETCONF transport, see [I-D.draft-ietf-netconf-netconf-event-notifications].



<KENT5> This new section "Transport Considerations" seems to be a mashup of requirements, security considerations, and recommendations and, as such, is a bit confusing.  I recommend ensuring the right info is in the right sections.



<Eric6> Look at <Kent4>.  My attempt was to do exactly what you requested.



Per the above, there simply are not many common transport requirements.    If you want me to split them up, that is fine.   If you want me to house them in “transport considerations” that is fine too.   I think that collapsing everything back to Security Considerations is the cleanest approach.    But a consistent target would be help us close this questions.   If you have cycles to propose a specific distribution, that would be great.



<Kent6> sorry, I wasn't clear before.  Requirements are having MUST and MAY.  Security Considerations are more SHOULD and RECOMMENDED.  I'm seeing a mix in this section.  I think that all the SHOULD and RECOMMENDED statements should be moved to the Security Considerations section (assuming they are indeed Security related).







<Kent5?>It only mentions the need for one-way authentication, is that correct?



<Eric6>: One way authentication is needed before pushing events from the perspective of the publisher.   The receiver certainly might want to verify the publisher.  Mechanisms to accomplish that can be transport dependent.  If you want to add a simple statement “A receiver MUST authenticate a publisher”, that can be done as generic guidance.



<Kent6> Yes, exactly, if it is true.   Perhaps have the two statements and then say something about "mutual authentication" so that it is crystal clear.



<Kent5?> The first paragraph's use of the word "authorize" confuses me, especially in context of the 2nd paragraph, what would the "transport" authorize?



<Eric6>  Tweaked the wording to:



For both configured and dynamic subscriptions the publisher MUST authenticate a receiver via some transport level mechanism before sending any event records for which they are authorized to see.



<Kent6> better, thx.





BTW, maybe this section needs to more clearly specify that it only regards the transport for dedicated notification channels (not the transport for NC or RC).



<Eric6>  Added the sentence at the beginning of the section:



This section provides requirements which must be supportable via any transport technology supporting this solution.



<Kent6> perhaps s/this solution/the solution presented in this document/???