IETF Logo Mail Archive

Re: [netconf] Benjamin Kaduk's No Objection on draft-ietf-netconf-netconf-event-notifications-20: (with COMMENT)

"Eric Voit (evoit)" <evoit@cisco.com> Thu, 16 May 2019 12:47 UTC

Return-Path: <evoit@cisco.com>
X-Original-To: netconf@ietfa.amsl.com
Delivered-To: netconf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5413E1200F3; Thu, 16 May 2019 05:47:09 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.511
X-Spam-Level:
X-Spam-Status: No, score=-14.511 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nmP_B9jJ6L16; Thu, 16 May 2019 05:47:08 -0700 (PDT)
Received: from rcdn-iport-6.cisco.com (rcdn-iport-6.cisco.com [173.37.86.77]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DEDDC120090; Thu, 16 May 2019 05:47:07 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1872; q=dns/txt; s=iport; t=1558010827; x=1559220427; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=9gOfVc5Cz5Q4Y7jFeGb5ju9QyyY8HqJaRnAZ9NBxhzc=; b=F2c/LTTUWnQCCr6o+bMxDwza6E8rZe4crcZeNzIVAnR41CZpiJk0ah+k bUtRhOIWlERoAoEhIwSsKB28wm9M7oUR7lTxhUfE13igglH2QSG+mK7mq XzSFh/xSJV9qRfc1ZpsOMZfOSKlP3LbYuH/EtcONjG/0L1xLf5uBbo2ko I=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0AHAABCW91c/5tdJa1kDgwBAQEBAQIBAQEBBwIBAQEBgVIEAQEBAQsBgWYqgT0wMoQHlRWYU4F7CQEBAQwBAS8BAYRAAheCFyM1CA4BAwEBBAEBAgEEbSiFSgEBAQMBIxFDAgULAgEIFQMCAh8HAgICMBUQAgQBDQ2CT0uBfA+rVoEvijGBCygBi04XgUA/gRGDEj6EW4JzglgEjVyZfQkCggmSViOVboMgiRSVCgIRFYEwIAE2gVdwFYMogkWNUDtBj3+BIQEB
X-IronPort-AV: E=Sophos;i="5.60,476,1549929600"; d="scan'208";a="560467562"
Received: from rcdn-core-4.cisco.com ([173.37.93.155]) by rcdn-iport-6.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 16 May 2019 12:47:04 +0000
Received: from XCH-RTP-011.cisco.com (xch-rtp-011.cisco.com [64.101.220.151]) by rcdn-core-4.cisco.com (8.15.2/8.15.2) with ESMTPS id x4GCl30B011664 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Thu, 16 May 2019 12:47:04 GMT
Received: from xch-rtp-013.cisco.com (64.101.220.153) by XCH-RTP-011.cisco.com (64.101.220.151) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 16 May 2019 08:47:03 -0400
Received: from xch-rtp-013.cisco.com ([64.101.220.153]) by XCH-RTP-013.cisco.com ([64.101.220.153]) with mapi id 15.00.1473.003; Thu, 16 May 2019 08:47:03 -0400
From: "Eric Voit (evoit)" <evoit@cisco.com>
To: Randy Presuhn <randy_presuhn@alumni.stanford.edu>, Benjamin Kaduk <kaduk@mit.edu>, The IESG <iesg@ietf.org>
CC: "netconf@ietf.org" <netconf@ietf.org>, "draft-ietf-netconf-netconf-event-notifications@ietf.org" <draft-ietf-netconf-netconf-event-notifications@ietf.org>, "netconf-chairs@ietf.org" <netconf-chairs@ietf.org>
Thread-Topic: [netconf] Benjamin Kaduk's No Objection on draft-ietf-netconf-netconf-event-notifications-20: (with COMMENT)
Thread-Index: AQHVC0issmRKZA7PmESHWaRaGNgVg6ZsgKHQgADExwCAAG4z8A==
Date: Thu, 16 May 2019 12:47:03 +0000
Message-ID: <9f931951fb104c19b7e786bdd1871ae1@XCH-RTP-013.cisco.com>
References: <155794345628.30726.16513916652364715189.idtracker@ietfa.amsl.com> <17b8294694a446679f786fee28e4e206@XCH-RTP-013.cisco.com> <8a904fce-ff70-2e62-9fde-850cce607ffc@alumni.stanford.edu>
In-Reply-To: <8a904fce-ff70-2e62-9fde-850cce607ffc@alumni.stanford.edu>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.118.56.226]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-Outbound-SMTP-Client: 64.101.220.151, xch-rtp-011.cisco.com
X-Outbound-Node: rcdn-core-4.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/netconf/Ir0fkRI37wYnA1joIVaSAOy5aiY>
Subject: Re: [netconf] Benjamin Kaduk's No Objection on draft-ietf-netconf-netconf-event-notifications-20: (with COMMENT)
X-BeenThere: netconf@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NETCONF WG list <netconf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netconf>, <mailto:netconf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netconf/>
List-Post: <mailto:netconf@ietf.org>
List-Help: <mailto:netconf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netconf>, <mailto:netconf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 16 May 2019 12:47:09 -0000

> From: Randy Presuhn, May 15, 2019 10:10 PM
> 
> Hi -
> 
> On 5/15/2019 12:01 PM, Eric Voit (evoit) wrote:
> ...
> >> From: Benjamin Kaduk, May 15, 2019 2:04 PM
> ...
> >> Section 6
> >>
> >>     Notification messages transported over the NETCONF protocol MUST be
> >>     encoded in a <notification> message as defined within [RFC5277],
> >>     Section 4.  And per [RFC5277]'s "eventTime" object definition, the
> >>     "eventTime" populated with the event occurrence time.
> >>
> >> nit: I think the last sentence is actually a sentence fragment.
> >
> > This reads fine with me.  Several on-line grammar checks give it a pass, but I
> am not sure how much I trust those tools.  So I will leave as is.
> 
> No, it really is a fragment.  Not only does it begin with a conjunction, but it lacks
> a verb. If it were joined to the previous sentence, one might infer a "MUST be"
> before "populated", but as a separate sentence it no longer supports that
> interpretation.  If "MUST be populated" isn't the intended interpretation here,
> then it's even more important to turn that fragment into a real sentence.

Made it:  "And per [RFC5277]'s "eventTime" object definition, the "eventTime" is populated with the event occurrence time."

MUST is not required as previous references already enforce that requirement.

Eric
 
> Randy

v2.23.0 | Report a Bug | By Email