Re: [netconf] Benjamin Kaduk's No Objection on draft-ietf-netconf-netconf-event-notifications-20: (with COMMENT)

Randy Presuhn <randy_presuhn@alumni.stanford.edu> Thu, 16 May 2019 23:20 UTC

Return-Path: <randy_presuhn@alumni.stanford.edu>
X-Original-To: netconf@ietfa.amsl.com
Delivered-To: netconf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B90F412030B for <netconf@ietfa.amsl.com>; Thu, 16 May 2019 16:20:02 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.921
X-Spam-Level:
X-Spam-Status: No, score=-1.921 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=unavailable autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Sa10i8EIaQPr for <netconf@ietfa.amsl.com>; Thu, 16 May 2019 16:20:00 -0700 (PDT)
Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B2EB7120345 for <netconf@ietf.org>; Thu, 16 May 2019 16:20:00 -0700 (PDT)
Received: by mail-pl1-f169.google.com with SMTP id c5so2345820pll.11 for <netconf@ietf.org>; Thu, 16 May 2019 16:20:00 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=x3DrFkKCG8uFl6PSW1KLisTQKChHwlP+a9Dc4hGlwRE=; b=cuX5410LP+EY4+MI4oRUc3LMEjuc6uj+2X+U1O3O6JaE7RDuIv3jrHi4Y8YbAE8jYB vDENmMRuWvTxMvRoQzhoCfr0sGKfnHwYsL+Gubdurao/exzHXLu3GlmpOmKDHZfmOn3G lGhphgmAOHmakX/dur5FpzLlsmS6L490tOyMF0gmNeD4+/cRvx9Z2Gx4byBTRm+b9ZdZ tjXZgXkSeYtBo/cetzzt7zoajaA8XS65ttq7wWpxbhQavDShg/vgNtHJB6zlZq0I0ThZ ALyv2cOBFrnZJK+HMNRMF7HjK2PBLZ894WrCan8p0FtWSi/zp5H3msTp2c/Zc5C6L4fi g4fA==
X-Gm-Message-State: APjAAAXdEwI41yVdYOuOFkQGpm6++r7lEWK4erWkiwV5H8or1Z3sIKnn OirrkykH7IivFSOUrHed1gGScg==
X-Google-Smtp-Source: APXvYqyxRKOhpCFeVp349bA31RskQB8jf2OwKf0lUqM6s1PDAtx9N9vVx/X5jDoIYEgYkD0TfMcFrQ==
X-Received: by 2002:a17:902:b602:: with SMTP id b2mr53673783pls.293.1558048800046; Thu, 16 May 2019 16:20:00 -0700 (PDT)
Received: from [192.168.1.102] (c-69-181-241-121.hsd1.ca.comcast.net. [69.181.241.121]) by smtp.gmail.com with ESMTPSA id x23sm6175094pfn.160.2019.05.16.16.19.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 May 2019 16:19:59 -0700 (PDT)
To: "Eric Voit (evoit)" <evoit@cisco.com>, Benjamin Kaduk <kaduk@mit.edu>, The IESG <iesg@ietf.org>
Cc: "netconf@ietf.org" <netconf@ietf.org>, "draft-ietf-netconf-netconf-event-notifications@ietf.org" <draft-ietf-netconf-netconf-event-notifications@ietf.org>, "netconf-chairs@ietf.org" <netconf-chairs@ietf.org>
References: <155794345628.30726.16513916652364715189.idtracker@ietfa.amsl.com> <17b8294694a446679f786fee28e4e206@XCH-RTP-013.cisco.com> <8a904fce-ff70-2e62-9fde-850cce607ffc@alumni.stanford.edu> <9f931951fb104c19b7e786bdd1871ae1@XCH-RTP-013.cisco.com>
From: Randy Presuhn <randy_presuhn@alumni.stanford.edu>
Message-ID: <25abe8f0-600d-649e-b33a-aad675ca8e45@alumni.stanford.edu>
Date: Thu, 16 May 2019 16:19:59 -0700
User-Agent: Mozilla/5.0 (Windows NT 6.0; rv:52.0) Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <9f931951fb104c19b7e786bdd1871ae1@XCH-RTP-013.cisco.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/netconf/L2_KMuNFjuCZETn7N-v3WrLS7FQ>
Subject: Re: [netconf] Benjamin Kaduk's No Objection on draft-ietf-netconf-netconf-event-notifications-20: (with COMMENT)
X-BeenThere: netconf@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NETCONF WG list <netconf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netconf>, <mailto:netconf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netconf/>
List-Post: <mailto:netconf@ietf.org>
List-Help: <mailto:netconf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netconf>, <mailto:netconf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 16 May 2019 23:20:07 -0000

Hi -

On 5/16/2019 5:47 AM, Eric Voit (evoit) wrote:
>> From: Randy Presuhn, May 15, 2019 10:10 PM
>>
>> Hi -
>>
>> On 5/15/2019 12:01 PM, Eric Voit (evoit) wrote:
>> ...
>>>> From: Benjamin Kaduk, May 15, 2019 2:04 PM
>> ...
>>>> Section 6
>>>>
>>>>      Notification messages transported over the NETCONF protocol MUST be
>>>>      encoded in a <notification> message as defined within [RFC5277],
>>>>      Section 4.  And per [RFC5277]'s "eventTime" object definition, the
>>>>      "eventTime" populated with the event occurrence time.
>>>>
>>>> nit: I think the last sentence is actually a sentence fragment.
>>>
>>> This reads fine with me.  Several on-line grammar checks give it a pass, but I
>> am not sure how much I trust those tools.  So I will leave as is.
>>
>> No, it really is a fragment.  Not only does it begin with a conjunction, but it lacks
>> a verb. If it were joined to the previous sentence, one might infer a "MUST be"
>> before "populated", but as a separate sentence it no longer supports that
>> interpretation.  If "MUST be populated" isn't the intended interpretation here,
>> then it's even more important to turn that fragment into a real sentence.
> 
> Made it:  "And per [RFC5277]'s "eventTime" object definition, the "eventTime" is populated with the event occurrence time."

Better, although I see no earthly reason for beginning this
sentence with "And".

Randy