Re: [netconf] FIXMEs in ietf-crypto-types and client/server models

Kent Watsen <kent+ietf@watsen.net> Wed, 20 November 2019 00:04 UTC

Return-Path: <0100016e861feb64-15823aa8-a77c-40ed-9e4c-2393f71e7465-000000@amazonses.watsen.net>
X-Original-To: netconf@ietfa.amsl.com
Delivered-To: netconf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E5BD112008C for <netconf@ietfa.amsl.com>; Tue, 19 Nov 2019 16:04:34 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.897
X-Spam-Level:
X-Spam-Status: No, score=-1.897 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=amazonses.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9rj-UqFmmD-M for <netconf@ietfa.amsl.com>; Tue, 19 Nov 2019 16:04:32 -0800 (PST)
Received: from a8-88.smtp-out.amazonses.com (a8-88.smtp-out.amazonses.com [54.240.8.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 48D2D12018B for <netconf@ietf.org>; Tue, 19 Nov 2019 16:04:30 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=6gbrjpgwjskckoa6a5zn6fwqkn67xbtw; d=amazonses.com; t=1574208269; h=From:Message-Id:Content-Type:Mime-Version:Subject:Date:In-Reply-To:Cc:To:References:Feedback-ID; bh=dwN6WwLSyLk9zbmr7UG4euVj/bDpfUZYQWH/Lz62peE=; b=Xa6qxwW6YpdFL97ou06MjuzqZFURNaTFLP7IOtXhl4Aw/djB0+ajcd3mf7KCexzA di/y3quS34W9lbkIyIk61rHJYtz08i4c/16thnjBXKF5HKkNCiUlNltqmkpL6RiuyiP fj1yjL4Kd1OM7ydXUNkmC3su4tHrKW74XJ5c8GGA=
From: Kent Watsen <kent+ietf@watsen.net>
Message-ID: <0100016e861feb64-15823aa8-a77c-40ed-9e4c-2393f71e7465-000000@email.amazonses.com>
Content-Type: multipart/alternative; boundary="Apple-Mail=_ED47AEFD-10A1-4547-B9E7-0A166289A4B2"
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\))
Date: Wed, 20 Nov 2019 00:04:29 +0000
In-Reply-To: <AM0PR07MB518797EFBA3FBF42F9B1C1D6834C0@AM0PR07MB5187.eurprd07.prod.outlook.com>
Cc: Balázs Kovács <balazs.kovacs=40ericsson.com@dmarc.ietf.org>, "netconf@ietf.org" <netconf@ietf.org>
To: Balázs Kovács <balazs.kovacs@ericsson.com>
References: <AM0PR07MB5187A1438941A29D28CE3486837E0@AM0PR07MB5187.eurprd07.prod.outlook.com> <0100016e3ed10fbb-8a5a44a9-6df6-4ac1-9b56-8dbf61ec64cc-000000@email.amazonses.com> <AM0PR07MB5187296C56CCE38DADE9EA1483790@AM0PR07MB5187.eurprd07.prod.outlook.com> <0100016e586dbe79-24514978-922b-479b-a523-3d2bbcdc56c4-000000@email.amazonses.com> <AM0PR07MB51870B440CA86FD39E0926C883770@AM0PR07MB5187.eurprd07.prod.outlook.com> <AM0PR07MB518797EFBA3FBF42F9B1C1D6834C0@AM0PR07MB5187.eurprd07.prod.outlook.com>
X-Mailer: Apple Mail (2.3445.104.11)
X-SES-Outgoing: 2019.11.20-54.240.8.88
Feedback-ID: 1.us-east-1.DKmIRZFhhsBhtmFMNikgwZUWVrODEw9qVcPhqJEI2DA=:AmazonSES
Archived-At: <https://mailarchive.ietf.org/arch/msg/netconf/MrDWw_XcP9hjKybmsk0T-UCBhj4>
Subject: Re: [netconf] FIXMEs in ietf-crypto-types and client/server models
X-BeenThere: netconf@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NETCONF WG list <netconf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netconf>, <mailto:netconf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netconf/>
List-Post: <mailto:netconf@ietf.org>
List-Help: <mailto:netconf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netconf>, <mailto:netconf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 20 Nov 2019 00:04:35 -0000

Hi Balazs,

> I had a look at your changes related to our discussion. In general it looks good!

Excellent.


> <snip>
> Do we need the if-feature in case of this empty case? Is the empty case ok in general?

Yes, I added a feature statement to my local copy.


> <snip> 
> Was the marked line left over as a mistake after a copy from local-or-truststore-certs-grouping?

Yes, that was a mistake.  Thanks for catching it!



Kent // contributor