Re: [Netconf] Yangdoctors last call review of draft-ietf-netconf-restconf-notif-11

"Reshad Rahman (rrahman)" <rrahman@cisco.com> Tue, 08 January 2019 23:18 UTC

Return-Path: <rrahman@cisco.com>
X-Original-To: netconf@ietfa.amsl.com
Delivered-To: netconf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 19CD412E04D; Tue, 8 Jan 2019 15:18:59 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.501
X-Spam-Level:
X-Spam-Status: No, score=-14.501 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wWAJKhD4uUHT; Tue, 8 Jan 2019 15:18:57 -0800 (PST)
Received: from rcdn-iport-7.cisco.com (rcdn-iport-7.cisco.com [173.37.86.78]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3516C12D4F0; Tue, 8 Jan 2019 15:18:57 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=7888; q=dns/txt; s=iport; t=1546989537; x=1548199137; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=Ve8bn4pxwlfZ2Npg2LBE8KO1pCOMs6At0yYoEaMp0RY=; b=TjJoqtAQfu/fdaPk0rM2hj+0DpVWuuYh6usm9XCvxrFNfzXC//oTdpu+ Fp5OXfTK2LBCgmykQ9oGM0Idv5R4iRP2W073r8UiWRKK1Gt0nkTM9jS/W pFvrKiLOEgf7YSXHETBLpWU9eRWsN+j+JJ9vfhl6SPubP/AePGrSyUrmq Y=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0AFAACvLzVc/49dJa1aCRkBAQEBAQE?= =?us-ascii?q?BAQEBAQEHAQEBAQEBgVIDAQEBAQELAYFaKWaBAicKg3auAoF7CwEBLIRAAhe?= =?us-ascii?q?BeyI1CA0BAwEBAgEBAm0ohUsGIwQNRRACAQgaAgkdAgICMBUQAgQBDQWDIgG?= =?us-ascii?q?CAaoVfDOKL4ELizQXgUA/gREnH4JMhFcqFyOCTzGCBCICoWcJApF2GIFjhSS?= =?us-ascii?q?Ha4MDiWqQPQIRFIEnIQE1gVZwFWUBgkGCIgUXgQABB40WcoEoiFMBgR4BAQ?=
X-IronPort-AV: E=Sophos;i="5.56,455,1539648000"; d="scan'208";a="500214261"
Received: from rcdn-core-7.cisco.com ([173.37.93.143]) by rcdn-iport-7.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Jan 2019 23:18:49 +0000
Received: from XCH-ALN-006.cisco.com (xch-aln-006.cisco.com [173.36.7.16]) by rcdn-core-7.cisco.com (8.15.2/8.15.2) with ESMTPS id x08NImXd003283 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Tue, 8 Jan 2019 23:18:49 GMT
Received: from xch-rcd-005.cisco.com (173.37.102.15) by XCH-ALN-006.cisco.com (173.36.7.16) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 8 Jan 2019 17:18:48 -0600
Received: from xch-rcd-005.cisco.com ([173.37.102.15]) by XCH-RCD-005.cisco.com ([173.37.102.15]) with mapi id 15.00.1395.000; Tue, 8 Jan 2019 17:18:48 -0600
From: "Reshad Rahman (rrahman)" <rrahman@cisco.com>
To: "Robert Wilton -X (rwilton - ENSOFT LIMITED at Cisco)" <rwilton@cisco.com>, "yang-doctors@ietf.org" <yang-doctors@ietf.org>
CC: "netconf@ietf.org" <netconf@ietf.org>, "draft-ietf-netconf-restconf-notif.all@ietf.org" <draft-ietf-netconf-restconf-notif.all@ietf.org>
Thread-Topic: Yangdoctors last call review of draft-ietf-netconf-restconf-notif-11
Thread-Index: AQHUprCFOch/e2rpE06mX+DnhAHT46WmFGWA
Date: Tue, 8 Jan 2019 23:18:48 +0000
Message-ID: <D7FCDD18-260A-40E6-8EF1-0485083FE21B@cisco.com>
References: <154688301471.23184.11003837983933531435@ietfa.amsl.com>
In-Reply-To: <154688301471.23184.11003837983933531435@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/10.10.5.181209
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [161.44.212.36]
Content-Type: text/plain; charset="utf-8"
Content-ID: <5699ED8E4563C841B3D9E820E78F63FF@emea.cisco.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-Outbound-SMTP-Client: 173.36.7.16, xch-aln-006.cisco.com
X-Outbound-Node: rcdn-core-7.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/netconf/P6s-_yy4wJAnbiqpVjZWNnMNnU8>
Subject: Re: [Netconf] Yangdoctors last call review of draft-ietf-netconf-restconf-notif-11
X-BeenThere: netconf@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Network Configuration WG mailing list <netconf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netconf>, <mailto:netconf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netconf/>
List-Post: <mailto:netconf@ietf.org>
List-Help: <mailto:netconf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netconf>, <mailto:netconf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Jan 2019 23:18:59 -0000

Hi Rob,

Thanks again for the review, inline.

On 2019-01-07, 12:43 PM, "Robert Wilton" <rwilton@cisco.com> wrote:

    Reviewer: Robert Wilton
    Review result: Ready with Issues
    
    I have reviewed this document as part of the YANG doctors directorate's
    ongoing effort to review all IETF documents being processed by the IESG.  These
    comments were written with the intent of improving the operational aspects of
    the IETF drafts. Comments that are not addressed in last call may be included
    in AD reviews during the IESG review.  Document editors and WG chairs should
    treat these comments just like any other last call comments.
    
    This document and the associated YANG module looks like it is in good shape to
    me.
    
    The two minor issues that I had that I think need to be resolved are:
    - The section 3.4 handling subscriptions by admin users wasn't intuitive to me
    (relative to what is stated in draft-ietf-netconf-subscribed-notifications). 
    Specifically what should an admin user be allowed to do vs the client that
    initiated the subscription. - Section 4 on HTTP2 QoS seemed unclear to me.
<RR> See below for response on the issues above.
    
    I think that all my other comments are really just nits:
    
    1) Section 3.2 Discovery, last paragraph.
    
    Would it be better for this to reference draft-ietf-netconf-nmda-restconf,
    section 2 and '/yang-libary/datastore' draft-ietf-netconf-rfc7895bis, section 3?
<RR> I can add section 2 in the reference to nmda-restconf. I don't think the transport drafts need to reference 7895/bis, please note that YP already references 7895.
    
    2) RPC table in section 3.3.  The identity for "kill-subscription" should
    probably be "delete-subscription-error" since "kill-subscription-error" isn't
    defined.
<RR> Good catch.
    
    3) Diagram in 3.4.  It wasn't immediately obvious to me that the vertical lines
    in the lined up with connections (a) and (b).  I'm not sure whether it is worth
    adding a comment to make this more explicit.  I figured it out whilst reading
    the text below, perhaps most other readers would also do so.
<RR> I'll try to make it clearer.
    
    4) Section 3.4, bottom of page 7, "must be sent within (b)" -> "MUST be sent
    within (b)"
<RR> Yes.
    
    5) Section 3.4:
       o  RPCs modify-subscription, resync-subscription and delete-
          subscription can only be done by the same RESTCONF username
          [RFC8040] who did the establish-subscription, or by a RESTCONF
          username with the required administrative permissions.  The latter
          also has access to the kill-subscription RPC.
    
    Just to check, is it true that any RESTCONF username with the required
    permissions is allowed to invoke the "delete-subscription" RPC?  Or should this
    be restricted to same RESTCONF username?  In fact, I was wondering whether an
    administrator should be allowed to invoke modify-subscription or
    resync-subscription, or whether they should be restricted to kill-subscription
    only?
<RR> I do not see the benefit of restricting what an admin user can do. E.g. the admin may want to decrease the frequency of a periodic subscription. 
    
    6) Section 4 is unclear to me:
    
     - The paragraph starting "take any existing subscription "priority" ..."
     states that the "dscp" field is copied into the HTTP2 stream priority, but I
     couldn't find such a field in section 5.3 of RFC7540.  Hence, I was wondering
     whether this paragraph shouldn't instead be stating the the "weighting" field
     is copied into the HTTP2 stream priority header?
    
    E.g.
    OLD:
       o  take any existing subscription "priority", as specified by the
          "dscp" leaf node in
          [I-D.draft-ietf-netconf-subscribed-notifications], and copy it
          into the HTTP2 stream priority, [RFC7540] section 5.3, and
    
    NEW:
       o  take any existing subscription "priority", as specified by the
          "weighting" leaf node in
          [I-D.draft-ietf-netconf-subscribed-notifications], and copy it
          into the HTTP2 stream weight, [RFC7540] section 5.3, and
 <RR> Good catch.
   
    There is also no mention of how the "E" (Exclusive) bit should be set in the
    HTTP2 stream headers.  Is this an omission?
<RR> It is an omission, implied that it's not used. I can add text stating that it's set to 0.
    
    7) Section 6 doesn't contain any YANG Tree output.  Probably time to put that
    in, but I would suggest not putting in the entire tree output, just the
    relevant snippets.  If you want to include the full tree output then I would
    suggest putting in an appendix instead.  The text in this section describing
    the YANG model needs to be fixed since the YANG module doesn't actually define
    any identities.
<RR> I believe the YANG module was changed but not the text. Will fix and add the tree diagram.
    
    8) Section 7, YANG module comments
    
    Just nits:
    
    8.1) Check line length of the file, it looks like it goes over 69 characters.
     - In particular, the namespace statement might need to be split.
     - The module description text indentation looks off on the first line, and
     probably needs to be re-flowed. - Some of the other descriptions look wide.
    
    8.2) The description for "subscription-modified" doesn't quite scan (as it goes
    over the line break).
    
    9) One of the filter examples appendix A.3 is clearly over 72 characters,
    suggest spliting.
<RR> Ack.

Regards,
Reshad.
    
    Thanks,
    Rob