IETF Logo Mail Archive

Re: [Netconf] Comments on draft-ietf-netconf-netconf-event-notifications-13

"Eric Voit (evoit)" <evoit@cisco.com> Tue, 09 October 2018 19:45 UTC

Return-Path: <evoit@cisco.com>
X-Original-To: netconf@ietfa.amsl.com
Delivered-To: netconf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2782612F1A6 for <netconf@ietfa.amsl.com>; Tue, 9 Oct 2018 12:45:00 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.955
X-Spam-Level:
X-Spam-Status: No, score=-14.955 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.456, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iyb12fraj3zp for <netconf@ietfa.amsl.com>; Tue, 9 Oct 2018 12:44:58 -0700 (PDT)
Received: from alln-iport-6.cisco.com (alln-iport-6.cisco.com [173.37.142.93]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B237C12D7F8 for <netconf@ietf.org>; Tue, 9 Oct 2018 12:44:57 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=17084; q=dns/txt; s=iport; t=1539114297; x=1540323897; h=from:to:subject:date:message-id:references:in-reply-to: mime-version; bh=PSD+BFDe2juesCNyM1MiURpTw7mDIUFsscghSZ+jAz8=; b=UD4O85jkCR5V5hQXgsQuU2CScFiwSYF05574EnzBx0NfWj+OgIg3vlc6 jfwAlevvbl/WUlw3KdmIATAM22o6Zs+zrc90ef3QXGVac57eAthqnNcq9 /KV67XydyIXumwVMwbiM96rxfpOMoiNl3fXlau7f5P4vuI+zeo5oQS3ny s=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0ADAADKA71b/5BdJa1jGQEBAQEBAQEBAQEBAQcBAQEBAQGBUQQBAQEBAQsBgQ5NKmZ/KAqDa4gVjDSCDZEvhUCBegsBARgBDIRHAheEIyE0DQ0BAwEBAgEBAm0cDIU5AQEBAQMjCiEYERICAQgRBAEBDQEdAgICLwEdCAIEAQ4EAQcVBII1SwGBHWQPpTyBLoocizkXgUE/gRKDEoMQCwEBAQEBF4FVgnOCVwKOEoYGiQ1RCQKGTYlzH49/jCmJJwIRFIElHTiBVXAVgycJCoITF4NGhRSFPm8BD4sjgR8BAQ
X-IronPort-AV: E=Sophos;i="5.54,361,1534809600"; d="scan'208,217";a="183011094"
Received: from rcdn-core-8.cisco.com ([173.37.93.144]) by alln-iport-6.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Oct 2018 19:44:56 +0000
Received: from XCH-RTP-014.cisco.com (xch-rtp-014.cisco.com [64.101.220.154]) by rcdn-core-8.cisco.com (8.15.2/8.15.2) with ESMTPS id w99Jiu8B012162 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL) for <netconf@ietf.org>; Tue, 9 Oct 2018 19:44:56 GMT
Received: from xch-rtp-013.cisco.com (64.101.220.153) by XCH-RTP-014.cisco.com (64.101.220.154) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 9 Oct 2018 15:44:55 -0400
Received: from xch-rtp-013.cisco.com ([64.101.220.153]) by XCH-RTP-013.cisco.com ([64.101.220.153]) with mapi id 15.00.1395.000; Tue, 9 Oct 2018 15:44:56 -0400
From: "Eric Voit (evoit)" <evoit@cisco.com>
To: "Tim Jenkins (timjenki)" <timjenki@cisco.com>, "netconf@ietf.org" <netconf@ietf.org>
Thread-Topic: Comments on draft-ietf-netconf-netconf-event-notifications-13
Thread-Index: AQHUYACzG8KxJWVjlk27RN+m4ai5C6UXTMLQ
Date: Tue, 09 Oct 2018 19:44:56 +0000
Message-ID: <508e6cbdc098440dac584164a0233fa9@XCH-RTP-013.cisco.com>
References: <4BA5CDFE-C86F-4ADA-BBBA-A9801F565655@cisco.com>
In-Reply-To: <4BA5CDFE-C86F-4ADA-BBBA-A9801F565655@cisco.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.118.56.234]
Content-Type: multipart/alternative; boundary="_000_508e6cbdc098440dac584164a0233fa9XCHRTP013ciscocom_"
MIME-Version: 1.0
X-Outbound-SMTP-Client: 64.101.220.154, xch-rtp-014.cisco.com
X-Outbound-Node: rcdn-core-8.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/netconf/QFZN_YBgPGJ_4T8oc8xTNt6v_kk>
Subject: Re: [Netconf] Comments on draft-ietf-netconf-netconf-event-notifications-13
X-BeenThere: netconf@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Network Configuration WG mailing list <netconf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netconf>, <mailto:netconf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netconf/>
List-Post: <mailto:netconf@ietf.org>
List-Help: <mailto:netconf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netconf>, <mailto:netconf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 09 Oct 2018 19:45:00 -0000

Thanks Tim.   In-line...

From: Netconf <netconf-bounces@ietf.org> On Behalf Of Tim Jenkins (timjenki)
Sent: Tuesday, October 9, 2018 2:49 PM
To: netconf@ietf.org
Subject: [Netconf] Comments on draft-ietf-netconf-netconf-event-notifications-13

All,

I have reviewed https://tools.ietf.org/html/draft-ietf-netconf-netconf-event-notifications-13 and while I have minor comments, I support this moving forward.

My minor comments are:

* In section 2, should there be a statement that there are no additional terms defined?

<Eric> Added the statement.

* Section 5: Suggest rephrasing this
"For a dynamic subscription a "modify-subscription", "delete-
   subscription", or "resynch-subscription" RPC MUST be sent using same
   the NETCONF session"
to
   "For a dynamic subscription, the "modify-subscription", "delete-
   subscription", or "resynch-subscription" RPCs MUST be sent using same
   the NETCONF session".
because two of them can be used multiple times per subscription.

<eric> Updated.   Made it:
“For a dynamic subscription, any "modify-subscription", "delete-subscription", or "resynch-subscription" RPCs MUST be sent using the same NETCONF session”

* Section A.4: I'm not sure how useful the XPath specification would as examples of filters, since the filters are so specific the what the stream provides.

<eric> This section was requested by Martin, and recently added.  The value is that it becomes possible to link an event notification from an existing YANG model (i.e., RFC-8347), to the syntax of how filters can be continuously changes.

* References: It looks like some of the links to outside items are inconsistent. For example, the first two are different in both heading and reference (one to datatracker).

<eric> unified the formatting.  I think this will just become RFC links when all is complete here (i.e., through the queue), so not sure if this will impact the end product.

Eric

Thanks,

Tim

--
Cisco Systems Canada Co.
2000 Innovation Drive
Kanata, ON, Canada, K2K 3E8
Preferences <http://www.cisco.com/offer/subscribe/?sid=000478326>
Unsubscribe <http://www.cisco.com/offer/unsubscribe/?sid=000478327>
Privacy <http://www.cisco.com/web/siteassets/legal/privacy.html>

v2.23.0 | Report a Bug | By Email