Re: [netconf] WGLC: draft-ietf-netconf-https-notif-06

"maqiufang (A)" <maqiufang1@huawei.com> Thu, 04 February 2021 07:28 UTC

Return-Path: <maqiufang1@huawei.com>
X-Original-To: netconf@ietfa.amsl.com
Delivered-To: netconf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 677F33A1373 for <netconf@ietfa.amsl.com>; Wed, 3 Feb 2021 23:28:42 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.899
X-Spam-Level:
X-Spam-Status: No, score=-1.899 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id acrBTmvQrgNA for <netconf@ietfa.amsl.com>; Wed, 3 Feb 2021 23:28:40 -0800 (PST)
Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B57733A1372 for <netconf@ietf.org>; Wed, 3 Feb 2021 23:28:39 -0800 (PST)
Received: from fraeml702-chm.china.huawei.com (unknown [172.18.147.200]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4DWVP42rXXz67kkV for <netconf@ietf.org>; Thu, 4 Feb 2021 15:22:16 +0800 (CST)
Received: from dggeme719-chm.china.huawei.com (10.1.199.115) by fraeml702-chm.china.huawei.com (10.206.15.51) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2106.2; Thu, 4 Feb 2021 08:28:31 +0100
Received: from dggeme770-chm.china.huawei.com (10.3.19.116) by dggeme719-chm.china.huawei.com (10.1.199.115) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2106.2; Thu, 4 Feb 2021 15:28:30 +0800
Received: from dggeme770-chm.china.huawei.com ([10.8.68.58]) by dggeme770-chm.china.huawei.com ([10.8.68.58]) with mapi id 15.01.2106.006; Thu, 4 Feb 2021 15:28:30 +0800
From: "maqiufang (A)" <maqiufang1@huawei.com>
To: Kent Watsen <kent+ietf@watsen.net>, "netconf@ietf.org" <netconf@ietf.org>
Thread-Topic: [netconf] WGLC: draft-ietf-netconf-https-notif-06
Thread-Index: AQHW91XvRUspf6oo7ECvf5qPey2iLapBK5iAgAHPkYCAAfb+AIACqp3Q
Date: Thu, 4 Feb 2021 07:28:30 +0000
Message-ID: <cb57b46caf25410dacb1e37b6ce91393@huawei.com>
References: <3F58C70C-C0AD-4FBA-9E89-650CC347FEF6.ref@yahoo.com> <3F58C70C-C0AD-4FBA-9E89-650CC347FEF6@yahoo.com> <01000177588220b4-e69a027b-360a-4e2b-af1c-e681d9bd881e-000000@email.amazonses.com> <A979E7E5-1F85-4D6D-8560-1321589800B9@yahoo.com> <0100017764e15a93-b0ee5a7e-cf50-436c-be80-9cc488e5f7e4-000000@email.amazonses.com>
In-Reply-To: <0100017764e15a93-b0ee5a7e-cf50-436c-be80-9cc488e5f7e4-000000@email.amazonses.com>
Accept-Language: zh-CN, en-US
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.136.100.25]
Content-Type: multipart/alternative; boundary="_000_cb57b46caf25410dacb1e37b6ce91393huaweicom_"
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/netconf/VOv89A9FLyIiRD70hjP4nSu8gRE>
Subject: Re: [netconf] WGLC: draft-ietf-netconf-https-notif-06
X-BeenThere: netconf@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NETCONF WG list <netconf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netconf>, <mailto:netconf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netconf/>
List-Post: <mailto:netconf@ietf.org>
List-Help: <mailto:netconf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netconf>, <mailto:netconf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Feb 2021 07:28:43 -0000

Hi, Kent:

I have read the latest version and find it more flexible.
Here comes a few suggestions:

1、 You have got a wrong link at the end of section 1.1. It supposed to be Appendix A.2, rather than Section 8.2.

2、 It seems that you are mix-using HTTP and HTTPS somewhere, for example,  "The protocol consists of two HTTP-based target resources presented by the receiver"(Should be “HTTPS-based”, I think).

3、 Section 3.3/4.2: Will the receiver return a HTTP 200/204 definitely? Should we consider some other extreme situations( e.g., not supported/implemented) ? Just my individual opinion.:)

4、 Section 4.3: You should replace "<event-class>fault</fault>" with "<event-class>fault</event-class>".

Qiufang Ma

From: netconf [mailto:netconf-bounces@ietf.org] On Behalf Of Kent Watsen
Sent: Wednesday, February 3, 2021 6:34 AM
To: netconf@ietf.org
Subject: Re: [netconf] WGLC: draft-ietf-netconf-https-notif-06

NETCONF,

      The just posted -07 addresses issues raised thus far.
      https://tools.ietf.org/html/draft-ietf-netconf-https-notif-07

Henning, Eric, Reshad,


      Please re-review as your comments are important to us.

Everyone else,

      The hasn’t been many reviews as yet.  Please review this
      version, as it is significantly better (ready for publication?)
      than the prevision version.

K.




On Feb 1, 2021, at 11:33 AM, Reshad Rahman <reshad@yahoo.com<mailto:reshad@yahoo.com>> wrote:

Good with me.

Regards,
Reshad.

From: Kent Watsen <kent+ietf@watsen.net<mailto:kent+ietf@watsen.net>>
Date: Sunday, January 31, 2021 at 7:54 AM
To: Reshad Rahman <reshad@yahoo.com<mailto:reshad@yahoo.com>>
Cc: "netconf@ietf.org<mailto:netconf@ietf.org>" <netconf@ietf.org<mailto:netconf@ietf.org>>, "draft-ietf-netconf-https-notif@ietf.org<mailto:draft-ietf-netconf-https-notif@ietf.org>" <draft-ietf-netconf-https-notif@ietf.org<mailto:draft-ietf-netconf-https-notif@ietf.org>>
Subject: Re: [netconf] WGLC: draft-ietf-netconf-https-notif-06


I've reviewed this document and I think the document will be ready once the changes planned by the authors (regarding notification-messages) are made.

Thanks, but a couple more problems:

1) the URLs are bad.  Specifically, the example in the “Learning Receiver Capabilities” section uses a nonsensical URL (‘/‘).   The authors propose to instead use a sub-resource to the user-configured “path” (e.g., GET /some/path/capabilities) and move the POST URL to another sub-resource (e.g., /some/path/relay-notification).  [see below for more on this]

2) the media-types are bad: “application/yang-data+[xml/json]” is used for notifications, which is wrong since they are not YANG-defined, and the custom media-types for capabilities (application/ietf-https-notif-cap+[xml/json]) is a way overkill.  The authors propose to use “application/[xml/json]” for both cases.




I have a question on the following YANG description. Section 4.1 mentions 'path-absolute' for the URI but the description below says "Relative URI...". Should this description be clarified/corrected or am I missing something?

            augment "transport/tls/tls/http-client-parameters" {
              leaf path {
                type string;
                description
                  "Relative URI to the target resource.";
              }
              description
                "Augmentation to add a path to the target resource.";
            }

Agreed.  How about this?

        leaf path {
          type string;
          mandatory true;
          description
            "URI prefix to the target resources.  Under this
             path the receiver must support both the 'capabilities'
             and 'relay-notification' resource targets, as described
             in RFC XXXX.";
        }
So, if path==“/som/path”, capability-discovery would be to "/some/path/capabilities” and notifications would be sent to “/some/path/relay-notification”.

Thoughts?


Formatting nit:
           Trust anchors (i.e. CA certs) that are used to authenticat\
 e

Fixed, but the other example cannot be fixed because the “xmlns” strings alone are too long, and XML doesn’t internally support folding, and the “string” type doesn’t allows for whitespace (include ‘\n’) both at the beginning and end of strings (recall my request for rfc6991-bis to define a “token” type that would enable the parser to discard any found, so our examples could more often be manually-folded).

K.