Re: [Netconf] Review of draft-ietf-netconf-restconf-notif-11

"Reshad Rahman (rrahman)" <rrahman@cisco.com> Tue, 08 January 2019 21:30 UTC

Return-Path: <rrahman@cisco.com>
X-Original-To: netconf@ietfa.amsl.com
Delivered-To: netconf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CD80E13117D for <netconf@ietfa.amsl.com>; Tue, 8 Jan 2019 13:30:24 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.5
X-Spam-Level:
X-Spam-Status: No, score=-14.5 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id m1zE_9LDDkuK for <netconf@ietfa.amsl.com>; Tue, 8 Jan 2019 13:30:22 -0800 (PST)
Received: from alln-iport-5.cisco.com (alln-iport-5.cisco.com [173.37.142.92]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 211DE130F96 for <netconf@ietf.org>; Tue, 8 Jan 2019 13:30:22 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=23504; q=dns/txt; s=iport; t=1546983022; x=1548192622; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=ap9l9qgzVeSamfGpWdBgnP9aPjoomkd/sIR+mwMIa8E=; b=iuRUOpYLoL43HNmsXop08XCDGYqKOJ0cer3TkhXSbb6VZRgAsRvY9ESK NP9bwjnZIqWwMq6SIh7goqVdqcZzI5Aq2RJIUgtaCdZR1diI5963zKFA/ 7DSqXk5smY8JBWJKBuuBrjOpjOxN8RktvidKTO+V0O1brVXfGHwgcYhLt M=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0ADAAAOFjVc/5ldJa1jGQEBAQEBAQE?= =?us-ascii?q?BAQEBAQcBAQEBAQGBUQQBAQEBAQsBgQ1NKWaBAicKg3aIGo1UJZdwFIFnCwE?= =?us-ascii?q?BIwmEQAIXgXsiNAkNAQMBAQIBAQJtHAyFSgEBAQQjVhACAQgOAwMBAg4dAgI?= =?us-ascii?q?CMB0IAQEEAQ0FgldLAYEdZA+pWYEvhC0BgROEaAWMIh0XgUA/gREnDBOCTIM?= =?us-ascii?q?eAoEmJQYwGIJRMYImAolThgEZhkuLLwkChxaKYBiBY4Ukim6JaoQTdYs1AhE?= =?us-ascii?q?UgScfOIFWcBVlAYJBgicXiF+FP3IBgSeHJyuBAQGBHgEB?=
X-IronPort-AV: E=Sophos;i="5.56,455,1539648000"; d="scan'208,217";a="222680321"
Received: from rcdn-core-2.cisco.com ([173.37.93.153]) by alln-iport-5.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Jan 2019 21:30:15 +0000
Received: from XCH-RCD-005.cisco.com (xch-rcd-005.cisco.com [173.37.102.15]) by rcdn-core-2.cisco.com (8.15.2/8.15.2) with ESMTPS id x08LUEjg004793 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Tue, 8 Jan 2019 21:30:15 GMT
Received: from xch-rcd-005.cisco.com (173.37.102.15) by XCH-RCD-005.cisco.com (173.37.102.15) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 8 Jan 2019 15:30:14 -0600
Received: from xch-rcd-005.cisco.com ([173.37.102.15]) by XCH-RCD-005.cisco.com ([173.37.102.15]) with mapi id 15.00.1395.000; Tue, 8 Jan 2019 15:30:14 -0600
From: "Reshad Rahman (rrahman)" <rrahman@cisco.com>
To: Qin Wu <bill.wu@huawei.com>, "netconf@ietf.org" <netconf@ietf.org>
Thread-Topic: Review of draft-ietf-netconf-restconf-notif-11
Thread-Index: AdSnFQ5Z3HWr5jjfQbudBX+zb68cBQAjKpOA
Date: Tue, 8 Jan 2019 21:30:13 +0000
Message-ID: <250CDB6D-657A-4604-B663-B17EFB515B80@cisco.com>
References: <B8F9A780D330094D99AF023C5877DABA9B1CA6D8@nkgeml513-mbx.china.huawei.com>
In-Reply-To: <B8F9A780D330094D99AF023C5877DABA9B1CA6D8@nkgeml513-mbx.china.huawei.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/10.10.5.181209
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [161.44.212.36]
Content-Type: multipart/alternative; boundary="_000_250CDB6D657A4604B663B17EFB515B80ciscocom_"
MIME-Version: 1.0
X-Outbound-SMTP-Client: 173.37.102.15, xch-rcd-005.cisco.com
X-Outbound-Node: rcdn-core-2.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/netconf/Wd6EusDevOxIhSNIz7kGBPZ1CdU>
Subject: Re: [Netconf] Review of draft-ietf-netconf-restconf-notif-11
X-BeenThere: netconf@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Network Configuration WG mailing list <netconf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netconf>, <mailto:netconf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netconf/>
List-Post: <mailto:netconf@ietf.org>
List-Help: <mailto:netconf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netconf>, <mailto:netconf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Jan 2019 21:30:25 -0000

Hi Qin,

Thanks for doing the review.

Please see inline <RR>.

From: Qin Wu <bill.wu@huawei.com>
Date: Tuesday, January 8, 2019 at 12:43 AM
To: "netconf@ietf.org" <netconf@ietf.org>
Cc: Kent Watsen <kwatsen@juniper.net>et>, "Reshad Rahman (rrahman)" <rrahman@cisco.com>
Subject: Review of draft-ietf-netconf-restconf-notif-11

Hi:
I am assigned as acting shepherd to assist Kent to review draft-ietf-netconf-restconf-notif-11
and have the following comments:
1.Clean up configured subscription specific notification such as subscription-modified, subscription-terminated. My impression is subscription-
modified, subscription-terminated as state change notification are only applicable to configured subscription. If the intention is to introduce
notification corresponding to establish-subscription or modify-subscription, separate notification name should be made.
<RR> Based on the discussions between yourself and Eric on netconf-notif (changes being made in 1.3 of SN), is this now closed?

2.Coexist of event stream discovery support
   by querying the "streams" container of ietf-subscribed-
   notification.yang and event stream discovery Support by querying the
   "streams" container of ietf-restconf-monitoring.yang in [RFC8040] should be discussed and
<RR> I’ll add some text which says something along the lines of “If module ietf-restconf-monitoring.yang is also supported, the streams which are in ietf-subscribed-notifications.yang SHOULD also be in ietf-restconf-monitoring.yang.”


3. Additional text is required to discuss how  the server ensure only said
client accesses the resource via URL in the security consideration section.
<RR> I will add some text which explains that the URL is encrypted, and also that user credentials can be used (similar to what is mentioned in section 3.4 wrt credentials required for RPCs modify-subscription etc). This is inline with discussions which occurred during WGLC.


4. Run ID nits tool and found 2 errors and 8 warnings as follows:
"
  Checking nits according to https://www.ietf.org/id-info/checklist :
  ----------------------------------------------------------------------------

  ** There are 10 instances of too long lines in the document, the longest
     one being 37 characters in excess of 72.


  Miscellaneous warnings:
  ----------------------------------------------------------------------------

  == The copyright year in the IETF Trust and authors Copyright Line does not
     match the current year

  == Line 206 has weird spacing: '...ription  estab...'

  == Line 225 has weird spacing: '... stream   esta...'

  == Line 228 has weird spacing: '...ription    ret...'

  == Line 230 has weird spacing: '... stream   modi...'

  -- The document date (December 13, 2018) is 25 days in the past.  Is this
     intentional?


  Checking references for intended status: Proposed Standard
  ----------------------------------------------------------------------------

     (See RFCs 3967 and 4897 for information about using normative references
     to lower-maturity documents in RFCs)

  == Unused Reference: 'RFC5277' is defined on line 535, but no explicit
     reference was found in the text

  == Unused Reference: 'RFC7230' is defined on line 559, but no explicit
     reference was found in the text

  == Outdated reference: A later version (-20) exists of
     draft-ietf-netconf-subscribed-notifications-13

  ** Obsolete normative reference: RFC 5246 (Obsoleted by RFC 8446)

"
 <RR> Will run ID nits and fix.

4. There are 7 errors in YANG validation output.
<RR> The errors are due to an issue in yanglint which has been fixed in 0.16.69 but datatracker is using 0.14.80. See https://trac.tools.ietf.org/tools/ietfdb/ticket/2667

5. Tree diagram output doesn’t show in the section 6.
<RR> Ack.

Regards,
Reshad.

Note than I have talked with authors on most of these comments. I believe a new version will
Come soon to address these comments.

-Qin