IETF Logo Mail Archive

Re: [netconf] WGLC: draft-ietf-netconf-notification-capabilities-11

Mahesh Jethanandani <mjethanandani@gmail.com> Thu, 12 March 2020 21:28 UTC

Return-Path: <mjethanandani@gmail.com>
X-Original-To: netconf@ietfa.amsl.com
Delivered-To: netconf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E8CE33A0433; Thu, 12 Mar 2020 14:28:19 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.097
X-Spam-Level:
X-Spam-Status: No, score=-2.097 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5wAjVk3CQCha; Thu, 12 Mar 2020 14:28:17 -0700 (PDT)
Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 670D83A0408; Thu, 12 Mar 2020 14:28:17 -0700 (PDT)
Received: by mail-pf1-x42b.google.com with SMTP id l184so3894182pfl.7; Thu, 12 Mar 2020 14:28:17 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=8gEIQNWQhirjFLy5+fFhNVhE2pDZHdFDHCn09u+LtCw=; b=upSJ1Mcdk5rSdlRFKI94GUQeyxTjwCEjpxpcq4S7lzx2w2WmzRX0uc37pUFKTutqQq ERYRFDVPM389bc68fkJ8JA4jmEOHBdVEOrBwOS3rpZCE0HD/XYryIE38enj20rVFD0k7 ucfwGaw3CvVhE+6/8jMhQa9nihlHRXm+pssZcjL7TgNFjUAV7T/g/05xwkw71+OMTm7S E1LtyblwZgvfEM71M9ul9BxupNgoctgHl07aYlVoSyY9VnFf5hn0vPhPN5FHyvH99N9J ahO/SjElLm7Y++eJE59jqp7wzzvvx25fy9GMIyFZGFSzHfcQt8PyEaht6atLR9M/6zqF tXIA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=8gEIQNWQhirjFLy5+fFhNVhE2pDZHdFDHCn09u+LtCw=; b=dJu9z7/YfA640Dal/P81dA2D4ogm6lQ0vJI1WLd3sGLTlcOBy4srl33rze5KJugaQu Zf3/ZL0dyniqsgcCess+RqDlkZSp8+hxvupDARz64i0xTETXnpFEq0/p/rKgCB2mQx/a Ds+A3+EObWf7P9fc5NPn8rZ4yVyYZPwPGd31Vsk2FCGtxqkqBYsb5h+4r3p/VsCq8s8F 9T0g2t2+458+FWfFYSj8P6+g1zeSjAr9aycI1MTcZrBiwA55Q4Tglh7zmlpHcDfIPKcW 1ZMRj5BB9bC5drnSoTbZBl5V9eL2y0stit5Yrd8fB69Vzgslp9fxWoPiQkpDni3lmpnm DPBg==
X-Gm-Message-State: ANhLgQ29mty8AAU1nFew86L1ss72XDFhgdZj6F3IRwjCMEsP+IvlXkph GJeVuLncOrq8N18h4r+2db7aw4yO
X-Google-Smtp-Source: ADFU+vtpIdDWN01ataA/tIVRpEtALNctwL+HE6CwyN/XKayuL9Q+O21GVQ8LbMdq+AydOKJZ686MIA==
X-Received: by 2002:a62:e808:: with SMTP id c8mr10344106pfi.111.1584048496582; Thu, 12 Mar 2020 14:28:16 -0700 (PDT)
Received: from ?IPv6:2601:647:5600:5020:7884:520e:258a:46a0? ([2601:647:5600:5020:7884:520e:258a:46a0]) by smtp.gmail.com with ESMTPSA id 4sm58788310pfn.90.2020.03.12.14.28.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Mar 2020 14:28:15 -0700 (PDT)
From: Mahesh Jethanandani <mjethanandani@gmail.com>
Message-Id: <BA3FC250-756F-4379-84EA-FB9704AF1714@gmail.com>
Content-Type: multipart/alternative; boundary="Apple-Mail=_7DEFD63D-5FDB-4614-8CD9-3E790E9B1195"
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
Date: Thu, 12 Mar 2020 14:28:12 -0700
In-Reply-To: <DB7PR07MB4011FFD19CF805CFC456CCC1F0FF0@DB7PR07MB4011.eurprd07.prod.outlook.com>
Cc: Kent Watsen <kent+ietf@watsen.net>, "netconf@ietf.org" <netconf@ietf.org>, yang-doctors@ietf.org
To: Balázs Lengyel <balazs.lengyel@ericsson.com>
References: <0100017055c347e5-13b624a9-04c0-4ba5-8a53-26a80f079607-000000@email.amazonses.com> <0100017055e833dd-1a2ecac4-53e4-4bb7-aab9-f75516c5fd38-000000@email.amazonses.com> <01000170a78abdde-66112ceb-d466-4c72-ad18-6058ef07ab02-000000@email.amazonses.com><53B69FD5-0834-4943-A33A-1596FD3434BD@gmail.com> <DB7PR07MB4011FFD19CF805CFC456CCC1F0FF0@DB7PR07MB4011.eurprd07.prod.outlook.com>
X-Mailer: Apple Mail (2.3445.9.1)
Archived-At: <https://mailarchive.ietf.org/arch/msg/netconf/Zx0C64SqT_JTX6x6XnVO8tcTrmg>
Subject: Re: [netconf] WGLC: draft-ietf-netconf-notification-capabilities-11
X-BeenThere: netconf@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NETCONF WG list <netconf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netconf>, <mailto:netconf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netconf/>
List-Post: <mailto:netconf@ietf.org>
List-Help: <mailto:netconf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netconf>, <mailto:netconf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 12 Mar 2020 21:28:20 -0000

[Adding yang-doctors]

Hi Balazs,


On Mar 10, 2020, at 2:06 AM, Balázs Lengyel <balazs.lengyel@ericsson.com> wrote:

Finally, have all the examples in the appendix been validated?
BALAZS: Yes, they have been loaded into a live Confd server.

I bring this up because I ran into issues when validating the https-notif model using ietf-subscribed-notification module, something that you also import. Here is what I see when I try to use yanglint to validate your example. In this case, I named your example as examples-notification-capabilities-1.xml.

bash-3.2$ yanglint -s -i -t auto -p /Volumes/External/git/iana/yang-parameters/ ietf-system-capabilities@2020-03-08.yang ietf-notification-capabilities@2020-03-09.yang examples-notification-capabilities-1.xml 
err : Invalid keyword "require-instance".
err : Module "ietf-subscribed-notifications" parsing failed.
err : Importing "ietf-subscribed-notifications" module into "ietf-yang-push" failed.
err : Module "ietf-yang-push" parsing failed.
err : Importing "ietf-yang-push" module into "ietf-notification-capabilities" failed.
err : Module "ietf-notification-capabilities" parsing failed.

At first I thought the issue was with yanglint, because just like you I used confd and it did not complain. But folks over at libyang tell me that this was discussed as part of their issue  #881 <https://github.com/CESNET/libyang/issues/881> and the conclusion was that you cannot put require-instance in a derived type based on this <https://tools.ietf.org/html/rfc7950#section-9.9.3> text.

Who is correct in their assertion, libyang or confd/RFC8639?

In case anyone is wondering which ietf-subsciribed-notifications module is being imported, here it is:

bash-3.2$ ls ../iana/yang-parameters/ietf-subscribed-notifications@2019-09-09.yang <mailto:iana/yang-parameters/ietf-subscribed-notifications@2019-09-09.yang>

Cheers.

BTW, even if I comment out the ‘require-instance’ statement, yanglint complains about other issues with ietf-subscribed-notifications, which I will bring up in a separate thread.


Mahesh Jethanandani
mjethanandani@gmail.com

v2.23.0 | Report a Bug | By Email