Re: [netconf] RFC 6241 Ambiguity

Mahesh Jethanandani <mjethanandani@gmail.com> Wed, 15 May 2019 21:33 UTC

Return-Path: <mjethanandani@gmail.com>
X-Original-To: netconf@ietfa.amsl.com
Delivered-To: netconf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 18CA21200D8 for <netconf@ietfa.amsl.com>; Wed, 15 May 2019 14:33:36 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.989
X-Spam-Level:
X-Spam-Status: No, score=-1.989 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_REMOTE_IMAGE=0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wQ31jjtAwYFl for <netconf@ietfa.amsl.com>; Wed, 15 May 2019 14:33:33 -0700 (PDT)
Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9A9301200A2 for <netconf@ietf.org>; Wed, 15 May 2019 14:33:32 -0700 (PDT)
Received: by mail-wr1-x433.google.com with SMTP id l2so1029537wrb.9 for <netconf@ietf.org>; Wed, 15 May 2019 14:33:32 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=e3qZ/p/1HHyLE8XJgttbkkqAPPuqEUImJHu65MhgU4Q=; b=Duy4ZAXXu2jMtEiI+jdF+KDoSJ35V7cTE4QPMaRNVAtofxOpFIEkds70KLW1x/r64R p2UECJ5fkF/qUNQy7uvgJSYOaxCRILDbaoqXyD+Q73wyPLzMkspe9EYNo+z/QSK2Meuf iGvzAGFIfK2EZNX3/cji6Jfko6ZTTbMyQD94bJOfcXou8vZRAAvatSrQDMM6CMR6ffHM oqaY7Kg/SXjz7jxNEAKgr3MLk0dxjj4aOWQC9zq3R1uEw58102CG/ujKiIKw3h3iww1N BriG+Eiwuize1Q5p5OOg7nJtfsa4j5+zYmKdCYJhKwofhpizAWXZw6GzcBF6uAGKJJKH b4tg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=e3qZ/p/1HHyLE8XJgttbkkqAPPuqEUImJHu65MhgU4Q=; b=soAdpp2mLuj2yeXv5WzhQx8a1fuMFMPL+l/FVc/IK02e4YTbwpiFU5zgzZeDovCxGn xOfzO9GqE10JGx5y3gKGpjZQZXynG/Q+ve53SWRfdutsK2WsI1bwDEAsDqA4SE8+UBH6 tVKwVmRJPGjfa1zNq9OdYGgJSQkjo/t7zn+YgVLFOp2mBdq/zRxg/geMIIjUfOwvF4hF gxnMrfaelOVUCrLOtNqmbsi+4Z2oxb04GLuQG7xKMgM8tHlr/y0IikMBpg3/gLn8N0Es hGFEmKggQLuSvK9JcPtNs7u6quNsK5iwlM/7n2KnOASqCw/uBR9qofyE91CMcmIyMv5h C28g==
X-Gm-Message-State: APjAAAWoYL/c5fC32AI2OTQBv/+IG9smtoSz/jnLGtH7fe8SMHKxWhk1 UrheaeEE9PBzCc2liJDlYmQ4FlP4
X-Google-Smtp-Source: APXvYqz7ZnL1bX4tejovzKaPobo91FeQ+eMRnJeewpc5DnZ7BaRUyJcQfp11bJ1QQFcZzJBpFrbGRg==
X-Received: by 2002:adf:9bd2:: with SMTP id e18mr15154842wrc.210.1557956011020; Wed, 15 May 2019 14:33:31 -0700 (PDT)
Received: from [10.33.123.214] ([66.170.99.1]) by smtp.gmail.com with ESMTPSA id v5sm6464669wra.83.2019.05.15.14.33.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 May 2019 14:33:30 -0700 (PDT)
From: Mahesh Jethanandani <mjethanandani@gmail.com>
Message-Id: <76ED75C8-AA1A-4A03-A382-0DE834C914A1@gmail.com>
Content-Type: multipart/alternative; boundary="Apple-Mail=_C28EB8E6-8CCE-4EB4-919A-4CD4115CE27A"
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
Date: Wed, 15 May 2019 14:33:27 -0700
In-Reply-To: <emdf557a96-2926-4d87-83f9-2f8216ed652e@morpheus>
Cc: Kent Watsen <kent@watsen.net>, "netconf@ietf.org" <netconf@ietf.org>
To: Jonathan Hansford <jonathan@hansfords.net>
References: <em35e87021-fa76-4888-a383-8b34e960175f@morpheus> <0100016aa75956af-70018fb1-15f8-4394-8ffd-4f4d5b2d7b3f-000000@email.amazonses.com> <CABCOCHScSp8AEjcgSd7tX-Va45y51CxK-b_hO4nd3SzW9rTUKA@mail.gmail.com> <eme2e51d99-6140-4142-b89f-db5e4c6e2a88@morpheus> <0100016ab7a9af7e-cd7f776e-79e1-42a4-9c5d-d04aed0d8fa1-000000@email.amazonses.com> <emdf557a96-2926-4d87-83f9-2f8216ed652e@morpheus>
X-Mailer: Apple Mail (2.3445.9.1)
Archived-At: <https://mailarchive.ietf.org/arch/msg/netconf/dDv9qjoOem9Pe8w-PR9nhgCWgK8>
Subject: Re: [netconf] RFC 6241 Ambiguity
X-BeenThere: netconf@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NETCONF WG list <netconf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netconf>, <mailto:netconf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netconf/>
List-Post: <mailto:netconf@ietf.org>
List-Help: <mailto:netconf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netconf>, <mailto:netconf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 15 May 2019 21:33:36 -0000


> On May 15, 2019, at 3:24 AM, Jonathan Hansford <jonathan@hansfords.net> wrote:
> 
> Kent,
> 
> I don't think Erratum 5397 should be deleted. Though the original section 7.8 makes no mention of confirmed commits, section 7.9 does, but does not differentiate between a vanilla confirmed commit and a persistent confirmed commit. Since a persistent confirmed commit is still a type of confirmed commit, without clarification the second paragraph of the description would seem to apply. 

I would agree.

> 
> With the diff, should that be against the original text or the original erratum?

The diff is building on top of the original erratum. I would think a diff w.r.t. to the original erratum would make sense.

> 
> Thanks,
> 
> Jonathan
> 
> 
> On 14/05/2019 19:45:12, "Kent Watsen" <kent@watsen.net <mailto:kent@watsen.net>> wrote:
> 
>>  
>>> So I need to contact the RFC Editor to correct Erratum 5397, with the relevant text in sections 7.8 and 7.9 being changed to something like:
>>>  
>>> 7.8: "If a NETCONF server receives a <close-session> request while processing a confirmed commit (Section 8.4) for that session, unless the confirmed commit is a persistent confirmed commit, it MUST restore the configuration to its state before the confirmed commit was issued. A persistent confirmed commit MUST survive session termination."
>>>  
>>> 7.9: "If a NETCONF server receives a <kill-session> request while processing a confirmed commit (Section 8.4) for the session to be killed, unless the confirmed commit is a persistent confirmed commit, it MUST restore the configuration to its state before the confirmed commit was issued. A persistent confirmed commit MUST survive session termination."
>>  
>> Ideally, Errata 5397 is deleted (because I think that it's clear that Section 8.4 overrides the 7.8 behavior) but, if we have to patch the errata, I might suggests:
>>  
>> For Section 7.8
>> OLD (in RFC 6241)
>>  
>> The server will release any locks
>> and resources associated with the session and gracefully close any
>> associated connections.
>>  
>> NEW:
>>  
>> The server will release any locks
>> and resources, associated with the session and gracefully close any
>> associated connections. As an exception to the previous sentence, if
>> the session is processing a persistent confirmed commit (Section 8.4),
>> the resources necessary for supporting confirmed commit are not released.
>>  
>> For Section 7.9:
>> OLD (in RFC 6241)
>>  
>> If a NETCONF server receives a <kill-session> request while
>> processing a confirmed commit (Section 8.4), it MUST restore the
>> configuration to its state before the confirmed commit was issued.
>>  
>> NEW:
>> What you have above seems fine, though I'd leave off the last sentence.
>>  
>>  
>>> I also need to contact the RFC Editor to correct Erratum 3821 to change:
>>>  
>>> If the session issuing a sequence of one or more confirmed commits is
>>> terminated for any reason before the confirm timeout expires, the server
>>> MUST restore the configuration to its state before the sequence of
>>> confirmed commits was issued, unless the last confirmed commit also
>>> included a <persist> element.
>>>  
>>> If the device reboots for any reason before the confirm timeout
>>> expires, the server MUST restore the configuration to its state
>>> before the sequence of confirmed commits was issued.
>>>  
>>> to something like:
>>>  
>>> If the session issuing a sequence of one or more confirmed commits is
>>> terminated for any reason before the confirm timeout expires, the server
>>> MUST restore the configuration to its state before the sequence of
>>> confirmed commits was issued, unless the confirmed commit is a
>>> persistent confirmed commit.
>>>  
>>> If the device reboots for any reason before the confirm timeout
>>> expires, unless a persistent confirmed commit is in progress, the
>>> server MUST restore the configuration to its state before the
>>> sequence of confirmed commits was issued.
>>>  
>>> A persistent confirmed commit MUST survive session termination.
>>>  
>>  
>> This seems okay but, again, I'd leave out the last sentence.
>>  
>>  
>> Side note: huge errata are hard to read without a diff. If a lot of text, then the NEW (or the NOTES) should include a diff highlighting exactly what changed.
>>  
>> Kent // contributor
>>  
>>  
>>  
>>> Are those errata OK?
>>>  
>>  
> 
> 
>  <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=emailclient>	Virus-free. www.avast.com <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=emailclient> <x-msg://76/#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>_______________________________________________
> netconf mailing list
> netconf@ietf.org <mailto:netconf@ietf.org>
> https://www.ietf.org/mailman/listinfo/netconf <https://www.ietf.org/mailman/listinfo/netconf>

Mahesh Jethanandani
mjethanandani@gmail.com