Re: [netconf] [netconf-wg/https-notif] Should the receivers container be moved under the augment statement and the leafref renamed? (#2)

Martin Bjorklund <mbj@tail-f.com> Tue, 19 November 2019 15:18 UTC

Return-Path: <mbj@tail-f.com>
X-Original-To: netconf@ietfa.amsl.com
Delivered-To: netconf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 34B9C12092C for <netconf@ietfa.amsl.com>; Tue, 19 Nov 2019 07:18:55 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CsafREaDTDst for <netconf@ietfa.amsl.com>; Tue, 19 Nov 2019 07:18:53 -0800 (PST)
Received: from mail.tail-f.com (mail.tail-f.com [46.21.102.45]) by ietfa.amsl.com (Postfix) with ESMTP id 7543C1200C4 for <netconf@ietf.org>; Tue, 19 Nov 2019 07:18:53 -0800 (PST)
Received: from localhost (h-4-44.A165.priv.bahnhof.se [158.174.4.44]) by mail.tail-f.com (Postfix) with ESMTPSA id 986801AE018B for <netconf@ietf.org>; Tue, 19 Nov 2019 16:18:51 +0100 (CET)
Date: Tue, 19 Nov 2019 16:18:51 +0100
Message-Id: <20191119.161851.678459934233941550.mbj@tail-f.com>
To: netconf@ietf.org
From: Martin Bjorklund <mbj@tail-f.com>
In-Reply-To: <netconf-wg/https-notif/issues/2/555352822@github.com>
References: <netconf-wg/https-notif/issues/2@github.com> <netconf-wg/https-notif/issues/2/555352822@github.com>
X-Mailer: Mew version 6.8 on Emacs 25.2
Mime-Version: 1.0
Content-Type: Text/Plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/netconf/eE7tvTqUtuGqGKxN0jD5yVlbNj0>
Subject: Re: [netconf] [netconf-wg/https-notif] Should the receivers container be moved under the augment statement and the leafref renamed? (#2)
X-BeenThere: netconf@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NETCONF WG list <netconf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netconf>, <mailto:netconf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netconf/>
List-Post: <mailto:netconf@ietf.org>
List-Help: <mailto:netconf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netconf>, <mailto:netconf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Nov 2019 15:18:55 -0000

Hi,

[What is the process when we have github issues?  I thought that
github would be used to track them, but discussion would be on the
ML?.  Right now I simply reply to the email I got.  Don't know where
it will end up.]

[Turns out it didn't go to the ML, hence this email!]


Mahesh Jethanandani <notifications@github.com> wrote:
> The reason to not move the receiver container under the augment is so
> as to allow the leafref to point to multiple receivers.

I don't understand this reason.

Since this is not a stand-alone model, I think it should augment
/sn:subscriptions.  In some way it doesn't matter what nodes are
called and where they are located, but having descriptive names and
keep related nodes under common subtrees helps the understanding of
models.

> Also no comments/objections were received on keeping the node
> 'receiver' as 'receiver'

You are right that the namespace ensures that there won't be a
conflict, but I think that the node names should be descriptive by
themselves.  The namespace / module name is there to ensure
uniqueness, but the model will be easier to understand and use if the
node names are descriptive.  Note that it is quite common that
implementations use these models to render CLIs as well.

Do you think that the model will be worse if we make the suggested
changes?


/martin