Re: [Netconf] Invalid when-stmts in yang-push

Andy Bierman <andy@yumaworks.com> Thu, 29 November 2018 21:52 UTC

MIME-Version: 1.0
References: <CABCOCHRAa91=S2fx7+gZZwZiNq5byC7HSoR4Sm+Ogk7GMKK0Vg@mail.gmail.com> <CABCOCHTEQ9B31S9V6Kv+XuE4ZRNXNx1wQeYeJ06pvJZhb87taA@mail.gmail.com>
In-Reply-To: <CABCOCHTEQ9B31S9V6Kv+XuE4ZRNXNx1wQeYeJ06pvJZhb87taA@mail.gmail.com>
From: Andy Bierman <andy@yumaworks.com>
Date: Thu, 29 Nov 2018 13:52:03 -0800
Message-ID: <CABCOCHSBoXYtUcOPJqNkUvzx2GFX9w5=-N1J66sz4m8S=HFFtg@mail.gmail.com>
To: Netconf <netconf@ietf.org>
Content-Type: multipart/alternative; boundary="000000000000151937057bd4b26d"
Archived-At: <https://mailarchive.ietf.org/arch/msg/netconf/eNG4QBOVzvicD4kvbQ6TAx2tHBU>
Subject: Re: [Netconf] Invalid when-stmts in yang-push
Precedence: list

Hi,

I think this diff fixes the yang-push module.
It looks like the augment to modify-subscription used the wrong grouping
because the 'datastore' leaf was missing.

365c365
<       when "../sn:target/yp:datastore";
---
>       when "yp:datastore";
572c572
<     when "sn:target/yp:datastore";
---
>     when "yp:datastore";
616c616
<     when "sn:target/yp:datastore";
---
>     when "yp:datastore";
632c632
<       uses selection-filter-objects;
---
>       uses datastore-criteria;
816c816
<     when "sn:target/yp:datastore";
---
>     when "yp:datastore";


Andy



On Wed, Nov 28, 2018 at 3:03 PM Andy Bierman <andy@yumaworks.com> wrote:

>
>
> On Wed, Nov 28, 2018 at 2:48 PM Andy Bierman <andy@yumaworks.com> wrote:
>
>> Hi,
>>
>> During implementation of yang-push-20 our developer found that
>> the when-stmts for establish-subscription are always false.
>>
>>
>> E.g. line 365:
>>     choice update-trigger {
>>       when "../sn:target/yp:datastore";
>>
>> The node 'target' is a choice. The node 'datastore' is a case.
>> Since the when-stmt is looking for data nodes not schema nodes,
>> the node-set is always empty.
>>
>>
>> There are 4 occurrences:
>>
>> Warning: no child node 'ietf-subscribed-notifications:target' found for
>> parent 'ietf-subscribed-notifications:subscriptions'
>> XPath: ../sn:target/yp:datastore
>> ietf-yang-push.yang:365.15: warning(1032): no child node available
>>
>> Warning: no child node 'ietf-subscribed-notifications:target' found for
>> parent 'ietf-subscribed-notifications:input'
>> XPath: sn:target/yp:datastore
>> ietf-yang-push.yang:572.10: warning(1032): no child node available
>>
>> Warning: no child node 'ietf-subscribed-notifications:target' found for
>> parent 'ietf-subscribed-notifications:input'
>> XPath: sn:target/yp:datastore
>> ietf-yang-push.yang:616.10: warning(1032): no child node available
>>
>> Warning: no child node 'ietf-subscribed-notifications:target' found for
>> parent 'ietf-subscribed-notifications:subscription'
>> XPath: sn:target/yp:datastore
>> ietf-yang-push.yang:816.10: warning(1032): no child node available
>>
>>
>
> pyang is also reporting these warnings:
>
> ietf-yang-push.yang:365: warning: XPath for "../sn:target/yp:datastore"
> does not exist
> ietf-yang-push.yang:572: warning: XPath for "sn:target/yp:datastore" does
> not exist
> ietf-yang-push.yang:616: warning: XPath for "sn:target/yp:datastore" does
> not exist
> ietf-yang-push.yang:816: warning: XPath for "sn:target/yp:datastore" does
> not exist
>
>
> Andy
>
>

[Netconf] Invalid when-stmts in yang-push Andy Bierman
Re: [Netconf] Invalid when-stmts in yang-push Andy Bierman
Re: [Netconf] Invalid when-stmts in yang-push Andy Bierman
Re: [Netconf] Invalid when-stmts in yang-push Eric Voit (evoit)
Re: [Netconf] Invalid when-stmts in yang-push Kent Watsen
Re: [Netconf] Invalid when-stmts in yang-push Reshad Rahman (rrahman)