[Netconf] comments on draft-ietf-netconf-subscribed-notifications-12

Martin Bjorklund <mbj@tail-f.com> Thu, 07 June 2018 15:32 UTC

Return-Path: <mbj@tail-f.com>
X-Original-To: netconf@ietfa.amsl.com
Delivered-To: netconf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4914F130F3B for <netconf@ietfa.amsl.com>; Thu, 7 Jun 2018 08:32:18 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.901
X-Spam-Level:
X-Spam-Status: No, score=-1.901 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id d1hZCX7hUlmP for <netconf@ietfa.amsl.com>; Thu, 7 Jun 2018 08:32:15 -0700 (PDT)
Received: from mail.tail-f.com (mail.tail-f.com [46.21.102.45]) by ietfa.amsl.com (Postfix) with ESMTP id BC56B130F53 for <netconf@ietf.org>; Thu, 7 Jun 2018 08:32:14 -0700 (PDT)
Received: from localhost (unknown [173.38.220.61]) by mail.tail-f.com (Postfix) with ESMTPSA id 02FD81AE0309 for <netconf@ietf.org>; Thu, 7 Jun 2018 17:32:13 +0200 (CEST)
Date: Thu, 07 Jun 2018 17:32:13 +0200 (CEST)
Message-Id: <20180607.173213.944977899308364449.mbj@tail-f.com>
To: netconf@ietf.org
From: Martin Bjorklund <mbj@tail-f.com>
X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/netconf/kmeMVTBNcmmSqnd8w6u0RFJwKi8>
Subject: [Netconf] comments on draft-ietf-netconf-subscribed-notifications-12
X-BeenThere: netconf@ietf.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: Network Configuration WG mailing list <netconf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netconf>, <mailto:netconf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netconf/>
List-Post: <mailto:netconf@ietf.org>
List-Help: <mailto:netconf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netconf>, <mailto:netconf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Jun 2018 15:32:19 -0000

Hi,

I checked draft-ietf-netconf-subscribed-notifications-12 (and to some
extent draft-ietf-netconf-subscribed-notifications-13 in github) wrt
my previous LC comments and new text.  Here are my additional
comments:



o  Section 1.4

  This is a left-over from my previous review; you accepted the
  proposed change, but it seems you forgot to change the text.

  OLD:

     o  the one way operation of [RFC5277], Section 4 is used.

  NEW:

     o  the <notification> message defined in [RFC5277] is still used.


o  Section 1.4

  Also a left-over.

  OLD:

   o  a publisher MAY implement both the Notification Management Schema
      and RPCs defined in [RFC5277] and this new document concurrently,
      in order to support old clients.  However the use of both
      alternatives on a single transport session is prohibited.

  NEW:

   o  a publisher MAY implement both the Notification Management Schema
      and RPCs defined in [RFC5277] and this new document concurrently,
      in order to support old clients.


o  Section 2.3

  s/"QoS" feature/"qos" feature/  (twice)


o  Section 2.4.5

  OLD:

   "subscriptions/subscription/receivers/receiver/address".

  NEW:

   "/subscriptions/subscription/receivers/receiver/address".


o  Section 2.7.6

  OLD:

   This notification indicates that a configured subscription, which
   includes a "stop-time", has successfully finished passing event
   records upon the reaching of that time.

  NEW:

   This notification indicates that a subscription that includes a
   "stop-time" has successfully finished passing event records upon
   the reaching of that time.


o  Section 4

  It seems you changed the state names from "active" to "ACTIVE",
  etc, i.e., all caps.  The 6087bis guidelines say that lower case
  should be used.

  My suggestion is to change to lower case in the model (which was in
  -10 that was in LC), and change ACTIVE to "active" in the text
  body.  (which I proposed in my LC review as well)


o  Section 4

  You have:

          leaf pushed-notifications {
            type yang:counter64;
            config false;
            description
              "Operational data which provides the number of update
               notification messages pushed to a receiver.";
          }

  Is this a left-over from previous versions?  This document doesn't
  define YANG push, and it doesn't define the term "update
  notification message".

  Should it simply be notifications-sent, with description "A count of
  the number of notifications sent to the receiver."?


o  Section 4

    leaf encoding  should have "if-feature configured;"

    (it is dependent on ../transport, which has the if-feature)


    Also, the description for this leaf is in -12:

        "The type of encoding for the subscribed data. If not
        included as part of the RPC, the encoding MUST be set by the
        publisher to be the encoding used by this RPC.";

   and in the not-yet-published -13 (from github):

        "The type of encoding for the subscribed data.   If not
        included, the encoding used will be the default for one
        encoding expected with a transport.";

   I can't parse from "the encoding used ...".



/martin