Re: [netconf] draft-ietf-netconf-keystore-09.txt

[Kent Watsen <[e-mail]>]

> Yes, but I believe that these SHOULD statements should also be 
> included on the description statement of 'cert' leafs as well as they 
> may get overlooked, if they are only to be found in the description 
> statement on the groupings.

Good idea.  I just added this as well:

  grouping end-entity-cert-grouping {
     description
       "An end entity certificate, and a notification for when
-       it is about to (or already has) expire.";
+       it is about to (or already has) expire.  Implementations
+       SHOULD assert that, where used, the end entity certificate
+       contains the expected public key.";



> It would be a possible solution, but that is something for the future though.

True, but we do what we can to make the future better  :)
https://github.com/netmod-wg/yang-next/issues/84



> Yes, copy/paste is always an option, but this also has its drawbacks, 
> including having multiple duplicate definitions within the YANG model; 
> the opportunity to modify the copy, intentionally or unintentionally, 
> such as to change the names of leafs; but most importantly copying and 
> pasting would mean that copy will not follow any changes made to 
> the original grouping, such as corrections and the addition of new 
> nodes in newer revisions, meaning additional maintenance and possible 
> discrepancies across YANG models going forward.  
> And this is why I am a keen user of groupings to ensure consistency 
> across models, even though it makes the YANG modules even harder to 
> read. If something is the same then it should always be the same 
> wherever is appears in the model and using a grouping does just that.

Okay, let's see what we can do.  Firstly, please see my response just now in the other thread where I'm suggesting the remove the `action` statements entirely (via an idea similar to "crypt-hash").   If accepted, then we only have to create "data-only" groupings for those groupings that containing `notification` statements. 

Kent // contributor