Re: [netconf] Review comments on draft-ietf-netconf-udp-notif

Tianran Zhou <zhoutianran@huawei.com> Mon, 08 November 2021 12:37 UTC

Return-Path: <zhoutianran@huawei.com>
X-Original-To: netconf@ietfa.amsl.com
Delivered-To: netconf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A078E3A0E8C; Mon, 8 Nov 2021 04:37:00 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.918
X-Spam-Level:
X-Spam-Status: No, score=-1.918 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ef0TjtTqSIzH; Mon, 8 Nov 2021 04:36:56 -0800 (PST)
Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EC7133A0E87; Mon, 8 Nov 2021 04:36:55 -0800 (PST)
Received: from fraeml736-chm.china.huawei.com (unknown [172.18.147.200]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4HnrFz3bVLz688Fd; Mon, 8 Nov 2021 20:36:39 +0800 (CST)
Received: from kwepeml100006.china.huawei.com (7.221.188.192) by fraeml736-chm.china.huawei.com (10.206.15.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.15; Mon, 8 Nov 2021 13:36:52 +0100
Received: from kwepeml500004.china.huawei.com (7.221.188.141) by kwepeml100006.china.huawei.com (7.221.188.192) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.15; Mon, 8 Nov 2021 20:36:50 +0800
Received: from kwepeml500004.china.huawei.com ([7.221.188.141]) by kwepeml500004.china.huawei.com ([7.221.188.141]) with mapi id 15.01.2308.015; Mon, 8 Nov 2021 20:36:50 +0800
From: Tianran Zhou <zhoutianran@huawei.com>
To: Mahesh Jethanandani <mjethanandani@gmail.com>, "draft-ietf-netconf-udp-notif@ietf.org" <draft-ietf-netconf-udp-notif@ietf.org>
CC: Netconf <netconf@ietf.org>
Thread-Topic: Review comments on draft-ietf-netconf-udp-notif
Thread-Index: AQHX1DyRJA0/gypCuU2KqKtZamET/Kv5cNyA
Date: Mon, 08 Nov 2021 12:36:50 +0000
Message-ID: <4a5c424a36d245b386789b3775cb43de@huawei.com>
References: <12D5318C-D645-477A-8651-31D4C35C34D4@gmail.com>
In-Reply-To: <12D5318C-D645-477A-8651-31D4C35C34D4@gmail.com>
Accept-Language: zh-CN, en-US
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.112.40.195]
Content-Type: multipart/alternative; boundary="_000_4a5c424a36d245b386789b3775cb43dehuaweicom_"
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/netconf/nUyL9aBXoUTnnorWGWIeunEbRqY>
Subject: Re: [netconf] Review comments on draft-ietf-netconf-udp-notif
X-BeenThere: netconf@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NETCONF WG list <netconf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netconf>, <mailto:netconf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netconf/>
List-Post: <mailto:netconf@ietf.org>
List-Help: <mailto:netconf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netconf>, <mailto:netconf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Nov 2021 12:37:01 -0000

Hi Mahesh,

Thanks very much for your detailed review and comments.
Please see in line for my reply.

Cheers,
Tianran

From: Mahesh Jethanandani [mailto:mjethanandani@gmail.com]
Sent: Monday, November 8, 2021 6:21 AM
To: draft-ietf-netconf-udp-notif@ietf.org
Cc: Netconf <netconf@ietf.org>
Subject: Review comments on draft-ietf-netconf-udp-notif

Hi authors of draft-ietf-netconf-udp-notif,

Here are some of my comments on the -04 version of the draft.

Nits:

  *   Please give the draft a more descriptive description for the short title rather than unyte-udp-notif. Something like "UDP-based Subscription”.
  *   S/DTLS is layered next tot/DTLS is layered on top of/
ZTR> I agree with your suggestions.

Comments (major and minor):


  *   In Section 1 there is an inherent assumption that the network processors/line cards have network access to the receiver. I think that requirement needs to be made explicit. Otherwise, routing all messages through an internal consolidator might be the only option. BTW, I believe the option to route notification messages through a internal consolidator should be kept as an option for UDP transport in case the line cards cannot route out of the box.
ZTR>Yes, it’s a good suggestion. I will add this to the new revision.

  *   In Section 2, it is not clear who is responsible for sending the notification to the publisher that the receiver is ready to receive notifications.
ZTR> I am sorry, I do not remember the configure subscription clear. What’s defined generic in RFC8639 about how the publisher know the receiver? Or the publisher does not need to deal with this anyway?

  *   In Section 3.1, TLS is specified as a transport protocol. I think you mean TCP or HTTP2 over TCP.
ZTR> This I would like to leave it to Pierre.

  *   There is use of term ’notification message” and “Notification Messages”. What is the difference? If you are using a pre-defined term, can you add a definition and nomenclature section that brings in the reference. If you are defining a new term, can you add a definition in the document.
ZTR> In my opinion, no difference. I would like to add a ref from existing definition.

  *   In Section 3.2, it is better for the Ver field to have an initial version of 1 instead of 0 to distinguish from a value that my not have been set.
ZTR> Is this normal? I do not mind to do this.

  *   Section 6.1. Not clear on the statement “Since UDP is an unreliable transport, with DTLS, an originator or a relay may not realize ..”. What has DTLS got to do with the unreliability of the transport protocol?
ZTR> This I would like to leave it to Pierre.

  *   Section 6.2. Is the draft asking for assignment of a well known port for UDP based transport?
ZTR> Yes. This is what we request from IANA.

  *   Section 8.

     *   Has the model been compiled with pyang and yanglint? See compilation outputs below.
ZTR> I noticed this. But it seems from “ietf-subscribed-notifications”. Do you know what’s happened?
I also noticed the datatracker shows 4 errors. It seems the same errors exist in draft-ietf-netconf-https-notif. Could anyone help on this?

     *   File name has a date that is different from the revision date in the model.
     *   Please add references to the models that are imported into this model in the draft itself. They are there in the model, but not in the draft itself.
     *   How about support for retransmission timeout value in the YANG model?
ZTR> I do not understand this. What’s this suggestion?

     *   Change WG reference to  <https://datatracker.ietf.org/wg/netconf>
     *   Remove the prefix “mailto:” It is great in a HTML document, but does not help in a YANG model.
     *   Update Copyright year to 2021.
     *   Indentations are off the model. Please fix.
     *   If the grouping “target-receiver” is not going to reused anywhere else, please remove it and inline it within the augment statement.
ZTR> Others received. I will update. Many thanks!

$ pyang -f tree ietf-udp-notif@2021-10-18.yang<mailto:ietf-udp-notif@2021-10-18.yang>
ietf-udp-notif@2021-10-18.yang<mailto:ietf-udp-notif@2021-10-18.yang>:120: warning: node "ietf-subscribed-notifications::transport" is not found in "ietf-subscribed-notifications::subscriptions”
$ yanglint ietf-udp-notif@2021-10-18.yang<mailto:ietf-udp-notif@2021-10-18.yang>
libyang warn: Schema node "transport" for parent "/ietf-subscribed-notifications:subscriptions" not found; in expr "derived-from(../../../transport" with context node "/ietf-subscribed-notifications:subscriptions/subscription/receivers/receiver”.

Thanks

Mahesh Jethanandani
mjethanandani@gmail.com<mailto:mjethanandani@gmail.com>